1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 2F3B96DE0298
\r
6 for <notmuch@notmuchmail.org>; Tue, 23 Jun 2015 13:33:33 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.18 tagged_above=-999 required=5 tests=[AWL=0.180]
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 7xngYn-58THb for <notmuch@notmuchmail.org>;
\r
16 Tue, 23 Jun 2015 13:33:31 -0700 (PDT)
\r
17 Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
\r
19 by arlo.cworth.org (Postfix) with ESMTPS id C9EA06DE028A
\r
20 for <notmuch@notmuchmail.org>; Tue, 23 Jun 2015 13:33:30 -0700 (PDT)
\r
21 Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
\r
22 4.80) (envelope-from <david@tethera.net>)
\r
23 id 1Z7UrN-0006FM-0J; Tue, 23 Jun 2015 20:31:57 +0000
\r
24 Received: (nullmailer pid 16804 invoked by uid 1000); Tue, 23 Jun 2015
\r
26 From: David Bremner <david@tethera.net>
\r
27 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
28 Subject: Re: [PATCH] emacs: tree: mark read change
\r
29 In-Reply-To: <1433843467-32398-1-git-send-email-markwalters1009@gmail.com>
\r
30 References: <1433843467-32398-1-git-send-email-markwalters1009@gmail.com>
\r
31 User-Agent: Notmuch/0.20.1+2~g5e37568 (http://notmuchmail.org) Emacs/24.4.1
\r
32 (x86_64-pc-linux-gnu)
\r
33 Date: Tue, 23 Jun 2015 22:31:38 +0200
\r
34 Message-ID: <87si9iyxn9.fsf@maritornes.cs.unb.ca>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.18
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Tue, 23 Jun 2015 20:33:33 -0000
\r
51 Mark Walters <markwalters1009@gmail.com> writes:
\r
53 > The mark read code for tree mode did not get updated in the recent
\r
54 > changes. This updates it to match. Since the user can customize the
\r
55 > mark read logic we just call the show logic in the message pane.
\r
58 > An alternative would be to mark any message explicitly viewed in
\r
59 > tree-mode as read. That would be simpler but I think this is better as
\r
60 > it deals with user customized mark read functions -- for example if
\r
61 > the user has a customized function that only marks a message read if
\r
62 > the whole message is viewed then this version will do the same in tree
\r
65 At first I was leery of the chaining of hooks, but now that I
\r
66 noticed/experienced the bug, it makes more sense to me. I'm considering
\r
67 rolling a bug fix release with this (I imagine the bug is pretty
\r
68 annoying for people using only notmuch-tree), so I'd like a bit more
\r
69 feedback before merging it.
\r