1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0F85F431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 12:14:28 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2gPqkKPdDa-S for <notmuch@notmuchmail.org>;
\r
16 Sat, 4 Feb 2012 12:14:27 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 418DB431FAE
\r
19 for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 12:14:27 -0800 (PST)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id D8C9568055; Sat, 4 Feb 2012 22:14:25 +0200 (EET)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,
\r
24 notmuch@notmuchmail.org
\r
25 Subject: Re: Bug: emacs 23.2 doesn't like ido-completing-read
\r
26 In-Reply-To: <8762fmeq4i.fsf@qmul.ac.uk>
\r
27 References: <871uqijdy4.fsf@qmul.ac.uk>
\r
28 <cun4nvdil63.fsf@hotblack-desiato.hh.sledj.net>
\r
29 <87pqe14hjh.fsf@qmul.ac.uk> <8762fmeq4i.fsf@qmul.ac.uk>
\r
30 User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sat, 04 Feb 2012 22:14:25 +0200
\r
36 Message-ID: <m2bopefja6.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 04 Feb 2012 20:14:28 -0000
\r
53 On Sat, 04 Feb 2012 12:31:57 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
\r
55 > I hadn't realised before but this also goes wrong if you use the prefix
\r
56 > argument to mail (eg ctrl-u m). The current code seems to mess up the
\r
57 > mini-buffer and even closing the buffer does not get out of it.
\r
59 > Changing ido-completing-read read to completing-read seems to fix the
\r
60 > problem entirely. Since this will affect most debian stable users (*) I
\r
61 > think we should fix it. The trivial patch below works for me but other solutions
\r
62 > may be better as they could maintain the benefits of ido-completing-read
\r
63 > (eg that it shows the possibilities).
\r
69 > (*) Perhaps only those who have more than one email address.
\r
71 > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
72 > index 023645e..41f82c2 100644
\r
73 > --- a/emacs/notmuch-mua.el
\r
74 > +++ b/emacs/notmuch-mua.el
\r
75 > @@ -191,7 +191,7 @@ the From: header is already filled in by notmuch."
\r
76 > ;; Now prompt the user, either for an email address only or for a full identity.
\r
79 > - (ido-completing-read (concat "Sender address for " name ": ") addresses
\r
80 > + (completing-read (concat "Sender address for " name ": ") addresses
\r
81 > nil nil nil 'notmuch-mua-sender-history (car addresses))))
\r
82 > (concat name " <" address ">"))
\r
83 > (ido-completing-read "Send mail From: " notmuch-identities
\r
85 Should that other ido-completing-read be kept there -- it is the only
\r
86 one left after this patch...
\r