d0/eb35281a41475ccdf46bd7997eff8893872a55

   1 Return-Path: <daniel@schoepe.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5  by arlo.cworth.org (Postfix) with ESMTP id 946D26DE13F4\r
   6  for <notmuch@notmuchmail.org>; Fri,  7 Aug 2015 00:36:28 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at cworth.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.207\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.207 tagged_above=-999 required=5\r
  12  tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13  RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01,\r
  14  RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_WEB=0.614, SPF_PASS=-0.001]\r
  15  autolearn=disabled\r
  16 Received: from arlo.cworth.org ([127.0.0.1])\r
  17  by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
  18  with ESMTP id oBBjEt9tRNqq for <notmuch@notmuchmail.org>;\r
  19  Fri,  7 Aug 2015 00:36:26 -0700 (PDT)\r
  20 Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com\r
  21  [209.85.212.172])\r
  22  by arlo.cworth.org (Postfix) with ESMTPS id CABB16DE13E7\r
  23  for <notmuch@notmuchmail.org>; Fri,  7 Aug 2015 00:36:25 -0700 (PDT)\r
  24 Received: by wibhh20 with SMTP id hh20so54251705wib.0\r
  25  for <notmuch@notmuchmail.org>; Fri, 07 Aug 2015 00:36:24 -0700 (PDT)\r
  26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google;\r
  27  h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
  28  :mime-version:content-type;\r
  29  bh=Fd+divPZykzAv+3krtzugtjX+s+SYsjERjJteU15k/w=;\r
  30  b=e9Uvpm4TmXeRH7zy+U432IOMP1DLFiR6nJWIW2zhODEfAQ7nVG+8yWmYgnq9vnEVLk\r
  31  yWh0HM9fOEALK1bswkdZBU8R4f7tABVULt4/LChWJnk0VsH7s3VC4X3Lz9jXWyrxVIYt\r
  32  pFSe3jEraotZx5GLhO75NyolBXOc16tutNMTY=\r
  33 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  34  d=1e100.net; s=20130820;\r
  35  h=x-gm-message-state:from:to:subject:in-reply-to:references\r
  36  :user-agent:date:message-id:mime-version:content-type;\r
  37  bh=Fd+divPZykzAv+3krtzugtjX+s+SYsjERjJteU15k/w=;\r
  38  b=bwy5UQI+djX7l2H64Z0VbQVHaTFown1nXr+P7cPK5bW5Pe4RxQdNfggzQvHDdBKaiP\r
  39  7iVPus7SfwAkq8WYQDDttFGQXpM51tJhtykzUx770UwqxMM9140dpwcdgFloCKqIhwRQ\r
  40  q28Iak2W5+aEcIXeh5dhWJZCVbOX3Vdhms2zxnhss6Wnsp9L8rDRBEC6S1v1MSzOAa+0\r
  41  10Z0S04VMev4Wd07mo71aPzPGhIm14gkVhiZToDYl2w9brKc0dynlosO72dS/Lzw4c9k\r
  42  ZJkG62RHtm4H/1D6Lu2KBh/a9SEp4/b1aHDI2ZCWXy/QJioKIGfXBu2TQrMsv7h5q1Bk\r
  43  DA8w==\r
  44 X-Gm-Message-State:\r
  45  ALoCoQmUWrzV6ilrONfdwPd+N/Wj1MKc8T5BwhkSMyosFZc6jVnIjWbTlCXaLmLSkn330caS7/E5\r
  46 X-Received: by 10.180.19.65 with SMTP id c1mr3462238wie.15.1438932983582;\r
  47  Fri, 07 Aug 2015 00:36:23 -0700 (PDT)\r
  48 Received: from localhost (ip-80-226-24-9.vodafone-net.de. [80.226.24.9])\r
  49  by smtp.gmail.com with ESMTPSA id o9sm13269327wja.29.2015.08.07.00.36.20\r
  50  (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  51  Fri, 07 Aug 2015 00:36:22 -0700 (PDT)\r
  52 From: Daniel Schoepe <daniel@schoepe.org>\r
  53 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
  54 Subject: Re: [PATCH 2/6] lib: Add per-message last modification tracking\r
  55 In-Reply-To: <1433525318-23756-3-git-send-email-david@tethera.net>\r
  56 References: <1432936375-astroid-4-0i1n6yczs2-1520@strange>\r
  57  <1433525318-23756-1-git-send-email-david@tethera.net>\r
  58  <1433525318-23756-3-git-send-email-david@tethera.net>\r
  59 User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1\r
  60  (x86_64-unknown-linux-gnu)\r
  61 Date: Fri, 07 Aug 2015 09:36:18 +0200\r
  62 Message-ID: <878u9nk0st.fsf@schoepe.localhost>\r
  63 MIME-Version: 1.0\r
  64 Content-Type: text/plain\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.18\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69  <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71  <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76  <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Fri, 07 Aug 2015 07:36:28 -0000\r
  78 \r
  79 Hi,\r
  80 \r
  81 On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote:\r
  82 > +         /* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not\r
  83 > +          * track modification revisions.  Give all messages a\r
  84 > +          * revision of 1.\r
  85 > +          */\r
  86 > +         if (new_features & NOTMUCH_FEATURE_LAST_MOD)\r
  87 > +             _notmuch_message_upgrade_last_mod (message);\r
  88 > [..]\r
  89 > +/* Upgrade a message to support NOTMUCH_FEATURE_LAST_MOD.  The caller\r
  90 > + * must call _notmuch_message_sync. */\r
  91 > +void\r
  92 > +_notmuch_message_upgrade_last_mod (notmuch_message_t *message)\r
  93 > +{\r
  94 > +    /* _notmuch_message_sync will update the last modification\r
  95 > +     * revision; we just have to ask it to. */\r
  96 > +    message->modified = TRUE;\r
  97 > +}\r
  98 > +\r
  99 \r
 100 The comment in the first part says that message without LAST_MOD get a\r
 101 revision of 1, but as far as I can tell, _notmuch_message_sync will\r
 102 actually put the next revision number on the message. If this is what's\r
 103 happening, either the comment or the behavior should be changed,\r
 104 depending on what's intended.\r
 105 \r
 106 Best regards,\r
 107 Daniel\r