1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 9A66F431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 01:37:35 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id WshSGtR6uV+Q for <notmuch@notmuchmail.org>;
\r
17 Tue, 17 Apr 2012 01:37:31 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id A1782431FAE
\r
22 for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 01:37:31 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SK3ue-0002QC-1i; Tue, 17 Apr 2012 09:37:27 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SK3ud-00010S-MY; Tue, 17 Apr 2012 09:37:23 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions
\r
35 In-Reply-To: <20120416215112.15615.94985@thinkbox.jade-hamburg.de>
\r
37 <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
38 <1332291311-28954-2-git-send-email-4winter@informatik.uni-hamburg.de>
\r
39 <87fwcopu5g.fsf@qmul.ac.uk>
\r
40 <20120416215112.15615.94985@thinkbox.jade-hamburg.de>
\r
41 User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Tue, 17 Apr 2012 09:37:44 +0100
\r
44 Message-ID: <87pqb64uuf.fsf@qmul.ac.uk>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 X-Sender-Host-Address: 94.192.233.223
\r
48 X-QM-SPAM-Info: Sender has good ham record. :)
\r
49 X-QM-Body-MD5: 46f84ad4cd2a182d99bd7237e6c3a1e0 (of first 20000 bytes)
\r
50 X-SpamAssassin-Score: -1.8
\r
51 X-SpamAssassin-SpamBar: -
\r
52 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
54 spam. We require at least 5.0 points to mark a message as spam.
\r
55 This message scored -1.8 points.
\r
56 Summary of the scoring:
\r
57 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
59 * [138.37.6.40 listed in list.dnswl.org]
\r
60 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
61 provider * (markwalters1009[at]gmail.com)
\r
62 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
64 * 0.5 AWL AWL: From: address is in the auto white-list
\r
65 X-QM-Scan-Virus: ClamAV says the message is clean
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Tue, 17 Apr 2012 08:37:35 -0000
\r
80 On Mon, 16 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
\r
81 > Quoting Mark Walters (2012-03-31 19:17:15)
\r
82 >> Secondly, I think the patch series could be made clearer and easier to
\r
83 >> review. If you do it in three steps
\r
85 >> 1) change of notmuch_database_close to notmuch_database_destroy (just
\r
86 >> the function name change)
\r
87 >> 2) split the new notmuch_database_destroy into two as in the current
\r
89 >> 3) Make any changes (if there are any) of notmuch_database_destroy to
\r
90 >> notmuch_database_close.
\r
92 >> The advantage is that the first change is easy to test (essentially does
\r
93 >> it build) and then changes from notmuch_database_destroy to
\r
94 >> notmuch_database_close in step 3 are explicit rather than the current
\r
95 >> situation where we need to grep the code to see if some instances of
\r
96 >> notmuch_database_close were not changed to notmuch_database_destroy.
\r
98 > I don't buy it. The patch series first touches the library and
\r
99 > documentation and the lib compiles fine. The next patch updates the
\r
100 > cli tools, all of them compile fine afterwards.
\r
102 > Every patch addresses the issue component wise, this seems rather
\r
105 I will try an explain my concern better. I assume that the patch
\r
106 actually introduces a functional change : that is something somewhere in
\r
107 the code calls the new notmuch_database_close instead of
\r
108 notmuch_database_destroy [1]. In your current patch series someone
\r
109 reading the patches alone can't see the functional change: it comes from
\r
110 the occurrences of notmuch_database_close that you *don't* change to
\r
111 notmuch_database_destroy.
\r
113 Indeed, if the only change is to allow out-of-tree code access to the
\r
114 new notmuch_database_close function then doing the patch series as
\r
116 rename notmuch_database_close to notmuch_database_destroy
\r
118 Then split notmuch_database_destroy make it clearer. (And if the code
\r
119 compiles after step 1 then I know *all* occurrences of
\r
120 notmuch_database_close have been changed to notmuch_database_destroy).
\r
127 [1] Apart, of course, from notmuch_database_destroy.
\r