1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C40BE431FBC
\r
6 for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:49:23 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id MYISSDjxn1DD for <notmuch@notmuchmail.org>;
\r
17 Sat, 27 Oct 2012 10:49:20 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id C26DD431FAF
\r
22 for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:49:19 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1TSAVU-0001Zt-DO; Sat, 27 Oct 2012 18:49:12 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1TSAVU-0003qh-2z; Sat, 27 Oct 2012 18:49:12 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself
\r
34 In-Reply-To: <87txtfhl1j.fsf@betacantrips.com>
\r
35 References: <1351337200-18050-1-git-send-email-markwalters1009@gmail.com>
\r
36 <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>
\r
37 <87txtfhl1j.fsf@betacantrips.com>
\r
38 User-Agent: Notmuch/0.14+69~g024ea36 (http://notmuchmail.org) Emacs/23.4.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Sat, 27 Oct 2012 18:49:12 +0100
\r
41 Message-ID: <87d3034xgn.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 93.97.24.31
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: a57c5499b88c5782e17e5ad2d7938f13 (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: -1.8
\r
48 X-SpamAssassin-SpamBar: -
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored -1.8 points.
\r
53 Summary of the scoring:
\r
54 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
56 * [138.37.6.40 listed in list.dnswl.org]
\r
57 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
58 provider * (markwalters1009[at]gmail.com)
\r
59 * 0.5 AWL AWL: From: address is in the auto white-list
\r
60 X-QM-Scan-Virus: ClamAV says the message is clean
\r
61 X-BeenThere: notmuch@notmuchmail.org
\r
62 X-Mailman-Version: 2.1.13
\r
64 List-Id: "Use and development of the notmuch mail system."
\r
65 <notmuch.notmuchmail.org>
\r
66 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
68 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
69 List-Post: <mailto:notmuch@notmuchmail.org>
\r
70 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
71 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
73 X-List-Received-Date: Sat, 27 Oct 2012 17:49:23 -0000
\r
75 On Sat, 27 Oct 2012, Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> wrote:
\r
76 > Mark Walters <markwalters1009@gmail.com> writes:
\r
78 >> +(defvar notmuch-pick-json-parser nil
\r
79 >> + "Incremental JSON parser for the search process filter.")
\r
81 >> +(defun notmuch-pick-process-filter (proc string)
\r
82 >> + "Process and filter the output of \"notmuch show\" (for pick)"
\r
83 >> + (let ((results-buf (process-buffer proc))
\r
84 >> + (parse-buf (process-get proc 'parse-buf))
\r
85 >> + (inhibit-read-only t)
\r
87 >> + (if (not (buffer-live-p results-buf))
\r
88 >> + (delete-process proc)
\r
89 >> + (with-current-buffer parse-buf
\r
90 >> + ;; Insert new data
\r
91 >> + (save-excursion
\r
92 >> + (goto-char (point-max))
\r
93 >> + (insert string)))
\r
94 >> + (with-current-buffer results-buf
\r
95 >> + (save-excursion
\r
96 >> + (goto-char (point-max))
\r
97 >> + (while (not done)
\r
98 >> + (condition-case nil
\r
99 >> + (case notmuch-pick-process-state
\r
101 > This looks awfully familiar. Not looking too close, but why can't this
\r
102 > re-use the JSON parser from your other patch? Just not to rely on the
\r
103 > other patch series?
\r
105 I was not sure how long it would take to get the other series pushed,
\r
106 and I realised that in its latest incarnation notmuch-pick could be
\r
107 entirely in contrib so I thought that might be relatively easy to get
\r
110 If they both go in then I will submit a patch to make pick use the split
\r
111 out parser. Similarly, if id:"87ehnw84e5.fsf@qmul.ac.uk" or something
\r
112 similar goes in I can delete some code from pick.
\r