1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4B422429E40
\r
6 for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 15:49:46 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id nSa-iE1QiQEb for <notmuch@notmuchmail.org>;
\r
16 Sat, 21 Jan 2012 15:49:45 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id BC803431FAF
\r
20 for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 15:49:45 -0800 (PST)
\r
21 X-AuditID: 12074422-b7fd66d0000008f9-ee-4f1b4f19d6b2
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 6B.CE.02297.91F4B1F4; Sat, 21 Jan 2012 18:49:45 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q0LNniZ0024885;
\r
27 Sat, 21 Jan 2012 18:49:45 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0LNnheB014922
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Sat, 21 Jan 2012 18:49:44 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1RokgR-00006F-A2; Sat, 21 Jan 2012 18:49:19 -0500
\r
37 Date: Sat, 21 Jan 2012 18:49:19 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Jani Nikula <jani@nikula.org>
\r
40 Subject: Re: [PATCH] lib: Save filenames for files detected as "not an email
\r
41 file" in the database.
\r
42 Message-ID: <20120121234919.GM16740@mit.edu>
\r
43 References: <1327096827-5760-1-git-send-email-amdragon@mit.edu>
\r
44 <87lip0acfy.fsf@nikula.org>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Content-Disposition: inline
\r
48 In-Reply-To: <87lip0acfy.fsf@nikula.org>
\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsUixG6noivpL+1vMLeHz6JpurPF9ZszmR2Y
\r
52 PG7df83u8WzVLeYApigum5TUnMyy1CJ9uwSujJUPDzIXbOKt+PB8L2MD42muLkZODgkBE4nt
\r
53 j/6yQ9hiEhfurWcDsYUE9jFKfJib08XIBWRvYJRYdeMvI4Rzkkli9aRORoiqJYwSF5d6gNgs
\r
54 AqoSzy9+ZwWx2QQ0JLbtXw5WIyKgKLH55H4wm1lAWuLb72YmEFtYIFVi4bZGMJtXQEeiad9a
\r
55 li5GDqCZsRLHzuVBhAUlTs58wgLRqiVx499LJpASkDHL/3GAmJxAmxbOTgapEBVQkZhychvb
\r
56 BEahWUiaZyFpnoXQvICReRWjbEpulW5uYmZOcWqybnFyYl5eapGuqV5uZoleakrpJkZwOLso
\r
57 7WD8eVDpEKMAB6MSD2/CPkl/IdbEsuLK3EOMkhxMSqK8B72k/YX4kvJTKjMSizPii0pzUosP
\r
58 MUpwMCuJ8JZ1AZXzpiRWVqUW5cOkpDlYlMR51bXe+QkJpCeWpGanphakFsFkZTg4lCR4J/kB
\r
59 DRUsSk1PrUjLzClBSDNxcIIM5wEafgikhre4IDG3ODMdIn+KUVFKnHcaSEIAJJFRmgfXC0s3
\r
60 rxjFgV4RhmjnAaYquO5XQIOZgAZz5EmBDC5JREhJNTDyn805usZUyMVfdXfEhJLQNtF1Pg6F
\r
61 FrvjrZ4n6Im4qDK5+3h5566Uu++77SPjsUkdretFp09RLLr/Kmzumh3/DJ+F1jN1mLQmsLnW
\r
62 b2F87iegybxA/pfwb0lP/4mTNN1iuy8ZRu3/zin5/PX8Dd03cq4skdh7oYrXR1NhlY6NaVDk
\r
63 lFMTmpVYijMSDbWYi4oTAW1Npo8SAwAA
\r
64 Cc: notmuch@notmuchmail.org
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Sat, 21 Jan 2012 23:49:46 -0000
\r
79 Quoth Jani Nikula on Jan 22 at 1:00 am:
\r
80 > On Fri, 20 Jan 2012 17:00:27 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
81 > > Later runs of "notmuch new" won't scan these files again and won't
\r
84 > > Various programs (Dovecot, in my case) store indexes and caches and
\r
85 > > such in the maildir. Without this, notmuch persistently complains
\r
86 > > about such files.
\r
88 > Overall, sounds good and doing this automagically is nice. Superficially
\r
89 > the code looks sensible, but I didn't really dig into it. A few nasty
\r
90 > questions instead:
\r
92 > What happens if you delete a non-email file? Does the entry stay in the
\r
95 Phooey. I thought this worked, but you're right that it doesn't (I
\r
96 even wrote a test for this, but the test was based on a false
\r
97 assumption). Non-email files do get returned by the directory
\r
98 iterator, so without any changes, notmuch new will notice that they're
\r
99 gone. What I missed is that it then uses
\r
100 notmuch_database_find_message_by_filename to find the "message" and
\r
101 remove the filename, which won't work since there's no message to
\r
104 I'll have to think about this more.
\r
106 > What happens if you replace a non-email file with an email file?
\r
108 It will not notice because notmuch new only inspects directory mtimes.
\r
109 This would require checking the mtimes of every non-email in the
\r
110 database on every notmuch new.
\r
112 > Does it matter what happens above?
\r
114 > These are corner cases, but what remains in TODO suggests that it would
\r
115 > be difficult to debug and figure out if the above ever did happen to
\r
118 Yes. It's possible this needs to get a search syntax before it is
\r
119 acceptable for general use.
\r