1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DE9C6431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 26 May 2011 03:26:13 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id LzXnWO8-SdRy for <notmuch@notmuchmail.org>;
\r
17 Thu, 26 May 2011 03:26:13 -0700 (PDT)
\r
18 Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com
\r
19 [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id B5B00431FD0
\r
22 for <notmuch@notmuchmail.org>; Thu, 26 May 2011 03:26:12 -0700 (PDT)
\r
23 Received: by fxm8 with SMTP id 8so617414fxm.26
\r
24 for <notmuch@notmuchmail.org>; Thu, 26 May 2011 03:26:11 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=domainkey-signature:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=Y4Cms9TQr1yvlm2hJVfU4gVPDcKeeWLAujCOYE6x/EI=;
\r
29 b=CGVN9Vj1N8WPDtOgjLFU9qqeeYCytW+XJ0jksknW5aetlHsYW5NlMBMsV0U/LWRrNf
\r
30 tGvt0RqSmEuGu/K3F1Cg9a3BOgFw0aZC1zS0cnCbgZIkOYEFRqyJyNp4OE8UvgIue15x
\r
31 hY3gjor0ppVKdcB0I7lC5rmVhh7nmMJrCRZQk=
\r
32 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
33 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
34 :mime-version:content-type;
\r
35 b=lfz/SFlX250ZoxVRcH15zq3P5ffOcFnu1WcoaAAoejjxISnASYcNhzpp4Umpe7ni/M
\r
36 Diz5FujeBamV9a+x/VS290G7GG6wGvUVNKdpxOaUsAzyIH4LKCMHg7WhnQhbtbrlak3h
\r
37 7Qyjo6CsXVdLfdtnPzO2/Qu1NnIdj4HjqiuGg=
\r
38 Received: by 10.223.158.72 with SMTP id e8mr746763fax.39.1306405571357;
\r
39 Thu, 26 May 2011 03:26:11 -0700 (PDT)
\r
40 Received: from localhost ([91.144.186.21])
\r
41 by mx.google.com with ESMTPS id z21sm236584fan.40.2011.05.26.03.26.09
\r
42 (version=TLSv1/SSLv3 cipher=OTHER);
\r
43 Thu, 26 May 2011 03:26:09 -0700 (PDT)
\r
44 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
45 To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown
\r
47 in notmuch-show view.
\r
48 In-Reply-To: <87ipsy9sue.fsf@yoom.home.cworth.org>
\r
49 References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
50 <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com>
\r
51 <87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com>
\r
52 <87lixu9z5b.fsf@yoom.home.cworth.org> <87hb8ipeb0.fsf@gmail.com>
\r
53 <87ipsy9sue.fsf@yoom.home.cworth.org>
\r
54 User-Agent: Notmuch/0.5-216-g0104e23 (http://notmuchmail.org) Emacs/23.3.1
\r
55 (x86_64-pc-linux-gnu)
\r
56 Date: Thu, 26 May 2011 14:26:34 +0400
\r
57 Message-ID: <87d3j5pxk5.fsf@gmail.com>
\r
59 Content-Type: text/plain; charset=us-ascii
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.13
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Thu, 26 May 2011 10:26:14 -0000
\r
74 On Wed, 25 May 2011 18:02:49 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
75 > On Thu, 26 May 2011 03:10:11 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
76 > > On Wed, 25 May 2011 15:46:40 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
77 > > Well, emacs trunk is not broken :) The bug is in lisp code, so you can
\r
78 > > fix it in .emacs by redefining `isearch-range-invisible' function. I do
\r
81 > Oh, in that case we can fix this is notmuch emacs lisp by just defining
\r
82 > and using a fixed function. Is the broken function something we're
\r
83 > calling directly? Or is it being called indirectly? (being called by
\r
84 > other emacs lisp code that we are calling)?
\r
87 It is called indirectly. What is the best way to fix it? I imagine
\r
88 that we can replace `isearch-range-invisible' function with another one,
\r
89 which would call the fixed function if some special variable is set, or
\r
90 if we are searching in a notmuch-show view. Otherwise it would call the
\r
93 > If we can incorporate the fix, that would be great.
\r
95 > > Please consider pushing other patches from the series. They do not fix
\r
96 > > any bug, but do simplify the code. The last patch uses list for
\r
97 > > invisible overlay property as well. But it does not break isearch
\r
98 > > because we do not search in hidden messages.
\r
100 > Hmmm... we should probably do that. I'd like isearch in notmuch to
\r
101 > search anything that is hidden.
\r
104 That is easy to fix. I can do that once we are done with this stuff.
\r
106 > > BTW would be nice to have a set of known-to-fail tests, i.e. bugs that
\r
107 > > are not fixed yet. If we had it, the above test could be implemented
\r
108 > > and committed before we have the fix pushed.
\r
110 > We do! Use test_expect_equal_failure (yes, the name is horrible!)
\r
111 > instead of test_expect_equal and you should get what you want.
\r
114 I should look at it, thanks.
\r
122 > carl.d.worth@intel.com
\r
projects / notmuch-archives.git / blob