1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 40480431FBC
\r
6 for <notmuch@notmuchmail.org>; Thu, 26 Jan 2012 11:42:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Qd+WE92wFZWq for <notmuch@notmuchmail.org>;
\r
16 Thu, 26 Jan 2012 11:42:26 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 7C786431FAF
\r
20 for <notmuch@notmuchmail.org>; Thu, 26 Jan 2012 11:42:26 -0800 (PST)
\r
21 X-AuditID: 12074424-b7fae6d000000906-d9-4f21aca17ab9
\r
22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])
\r
23 by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id BD.88.02310.1ACA12F4; Thu, 26 Jan 2012 14:42:25 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0QJgP50013533;
\r
27 Thu, 26 Jan 2012 14:42:25 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0QJgOvR004440
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Thu, 26 Jan 2012 14:42:25 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1RqVCc-0002Md-2M; Thu, 26 Jan 2012 14:41:46 -0500
\r
37 Date: Thu, 26 Jan 2012 14:41:46 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Jani Nikula <jani@nikula.org>
\r
40 Subject: Re: [PATCH] emacs: add default value to notmuch-search-line-faces
\r
41 Message-ID: <20120126194146.GG1940@mit.edu>
\r
42 References: <1327605679-15213-1-git-send-email-jani@nikula.org>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 Content-Disposition: inline
\r
46 In-Reply-To: <1327605679-15213-1-git-send-email-jani@nikula.org>
\r
47 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
48 X-Brightmail-Tracker:
\r
49 H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hTV1l24RtHf4Ph6C4um6c4W12/OZHZg
\r
50 8rh1/zW7x7NVt5gDmKK4bFJSczLLUov07RK4Mi4uvsResFKoYt0HqwbG63xdjJwcEgImEgvm
\r
51 7WSHsMUkLtxbz9bFyMUhJLCPUWLfz3XsEM4GRok9N/9AOSeZJB7132QBaRESWMIocfR4FYjN
\r
52 IqAq0Xb1LdgoNgENiW37lzOC2CICihKbT+4Hs5kFpCW+/W5mArGFBbwkfp74CTaHV0BbYuu0
\r
53 +0wQM+0lWk/3sEHEBSVOznzCAtGrJXHj30ugGg6wOcv/cYCEOQUcJM4/+c8KYosKqEhMObmN
\r
54 bQKj0Cwk3bOQdM9C6F7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEvL7VI11wvN7NELzWldBMjKKTZ
\r
55 XVR2MDYfUjrEKMDBqMTD6zlJ0V+INbGsuDL3EKMkB5OSKO+nlUAhvqT8lMqMxOKM+KLSnNTi
\r
56 Q4wSHMxKIrx3vIByvCmJlVWpRfkwKWkOFiVxXg2td35CAumJJanZqakFqUUwWRkODiUJ3ler
\r
57 gRoFi1LTUyvSMnNKENJMHJwgw3mAhj8GqeEtLkjMLc5Mh8ifYlSUEuf9BZIQAElklObB9cJS
\r
58 zitGcaBXhHlfglTxANMVXPcroMFMQIOX6sqDDC5JREhJNTAmfChZbS/m53B54arY2rdfefWz
\r
59 zwi8klArS2mevHLNzd+H+q3cjh7k0Pl9uO6btuu+9cu5o7lZ5gQo/4oSEo07qfh8Y4dhadSq
\r
60 mGkTXxnurCv1Z8jyr85xzmfu9FSd4lNy8+z1ycueqUwINmhfI6EyKc+bx/PRh7q2LZ8YZKXZ
\r
61 a53OKDAqCyqxFGckGmoxFxUnAgD3c5ipFAMAAA==
\r
62 Cc: notmuch@notmuchmail.org
\r
63 X-BeenThere: notmuch@notmuchmail.org
\r
64 X-Mailman-Version: 2.1.13
\r
66 List-Id: "Use and development of the notmuch mail system."
\r
67 <notmuch.notmuchmail.org>
\r
68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
71 List-Post: <mailto:notmuch@notmuchmail.org>
\r
72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
75 X-List-Received-Date: Thu, 26 Jan 2012 19:42:27 -0000
\r
77 Quoth Jani Nikula on Jan 26 at 9:21 pm:
\r
78 > Add default value to notmuch-search-line-faces to show "unread"
\r
79 > messages in bold, and "flagged" messages in red, to have some visual
\r
80 > indication of important messages in search results. This should be
\r
81 > helpful for new users.
\r
83 > "unread" tag is quite obvious, and handled specially both in the lib
\r
84 > and emacs ui. "flagged" is synced to maildir F flag in the lib. If one
\r
85 > syncs the maildir to IMAP, this also translates to corresponding IMAP
\r
86 > flag. (This is "starred" in GMail and Android.)
\r
88 > Signed-off-by: Jani Nikula <jani@nikula.org>
\r
90 While I'm sure this can be bikeshod to death, I do have one legitimate
\r
91 concern (and one illegitimate).
\r
93 I completely agree with what you said on IRC, though, that setting
\r
94 this to non-nil is more about making this capability more discoverable
\r
95 to new users than trying to come up with the perfect faces.
\r
98 > emacs/notmuch.el | 3 ++-
\r
99 > 1 files changed, 2 insertions(+), 1 deletions(-)
\r
101 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
102 > index 6b2c252..551ea9d 100644
\r
103 > --- a/emacs/notmuch.el
\r
104 > +++ b/emacs/notmuch.el
\r
105 > @@ -662,7 +662,8 @@ This function advances the next thread when finished."
\r
106 > (goto-char (point-min))
\r
107 > (forward-line (1- notmuch-search-target-line))))))))
\r
109 > -(defcustom notmuch-search-line-faces nil
\r
110 > +(defcustom notmuch-search-line-faces '(("unread" :weight bold)
\r
112 As much as I would like this, many terminals don't visually
\r
113 distinguish between the default face and the default face in bold.
\r
115 > + ("flagged" :foreground "red"))
\r
117 Red is pretty universally used to indicate danger or a serious
\r
118 condition, while "flagged" is simply supposed to draw attention. I
\r
119 would say blue as a neutral and distinct indicator, but it also has
\r
120 poor visibility (I used to use blue, but found that when scanning my
\r
121 mail, I would habitually skip over flagged messages because they were
\r
122 dark, which was the opposite of what I wanted). Personally I've
\r
123 settled on yellow; it's visually distinct enough to be easily
\r
124 noticeable and bright enough that I don't skip over it, though it
\r
125 obviously wouldn't work on a light background.
\r
127 > "Tag/face mapping for line highlighting in notmuch-search.
\r
129 > Here is an example of how to color search results based on tags.
\r