1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 60B12431FC3
\r
6 for <notmuch@notmuchmail.org>; Sat, 2 Nov 2013 07:57:12 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id tNwyVCKu3Hx7 for <notmuch@notmuchmail.org>;
\r
16 Sat, 2 Nov 2013 07:57:06 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 4F72B431FAF
\r
21 for <notmuch@notmuchmail.org>; Sat, 2 Nov 2013 07:57:06 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1VccdL-0006RQ-I7; Sat, 02 Nov 2013 11:57:03 -0300
\r
25 Received: (nullmailer pid 6639 invoked by uid 1000); Sat, 02 Nov 2013
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH] test: fix compact backup / restore test
\r
30 In-Reply-To: <m2li172avu.fsf@guru.guru-group.fi>
\r
31 References: <1383350515-24320-1-git-send-email-david@tethera.net>
\r
32 <m2li172avu.fsf@guru.guru-group.fi>
\r
33 User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Sat, 02 Nov 2013 11:56:58 -0300
\r
36 Message-ID: <87a9hmsvgl.fsf@zancas.localnet>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 02 Nov 2013 14:57:12 -0000
\r
53 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
55 > On Sat, Nov 02 2013, David Bremner <david@tethera.net> wrote:
\r
57 >> It was looking in completely the wrong place for the backup and the
\r
58 >> (test) xapian database. Unfortunately test_begin_subtest hides the
\r
62 > LGTM. It took me a while noticing that also ${TEST_TMPDIR}
\r
63 > was changed to ${MAIL_DIR}
\r
65 Globally it makes me a bit nervous to be doing destructive operations on
\r
66 ${MAIL_DIR}, but that isn't specific to this patch. I wonder if it would
\r
67 be worth globally replacing the variable with something like
\r
68 TEST_MAIL_DIR just to make collision with user environment less
\r
69 likely. Or maybe it's enough just to be careful to override MAIL_DIR.
\r