1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E57A4429E28
\r
6 for <notmuch@notmuchmail.org>; Sun, 13 Nov 2011 00:44:19 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id BL4J0fXL4uml for <notmuch@notmuchmail.org>;
\r
16 Sun, 13 Nov 2011 00:44:19 -0800 (PST)
\r
17 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id E0B55429E27
\r
21 for <notmuch@notmuchmail.org>; Sun, 13 Nov 2011 00:44:18 -0800 (PST)
\r
22 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
23 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
24 pAD8iD4o022316; Sun, 13 Nov 2011 10:44:13 +0200
\r
25 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
26 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
\r
27 Austin Clements <amdragon@MIT.EDU>
\r
28 Subject: Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail
\r
30 In-Reply-To: <8739ds33qz.fsf@gmail.com>
\r
31 References: <yf6ipmr7dki.fsf@taco2.nixu.fi> <20111112024941.GY2658@mit.edu>
\r
32 <yf662iplkv3.fsf@taco2.nixu.fi> <20111112154128.GB2658@mit.edu>
\r
33 <yf639dthwx1.fsf@taco2.nixu.fi> <8739ds33qz.fsf@gmail.com>
\r
34 User-Agent: Notmuch/0.9+23~g556c5fa (http://notmuchmail.org) Emacs/23.3.1
\r
36 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
37 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
38 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
39 Date: Sun, 13 Nov 2011 10:44:13 +0200
\r
40 Message-ID: <yf6mxc0za1u.fsf@taco2.nixu.fi>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 Cc: notmuch@notmuchmail.org
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Sun, 13 Nov 2011 08:44:20 -0000
\r
58 On Sun, 13 Nov 2011 11:01:24 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
59 > On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
60 > > SO, in our cases there are 2 options:
\r
64 > > { echo QUIT > /dev/tcp/127.0.0.1/25025; } 2>/dev/null
\r
66 > > wait ${smtp_dummy_pid}
\r
72 > > kill ${smtp_dummy_pid}
\r
74 > > wait ${smtp_dummy_pid}
\r
76 > > in test-lib.sh *and* add that fflush (output) before free (line) in
\r
77 > > smtp-dummy.c function receive_data_to_file.
\r
79 > > folks! opinions!
\r
82 > I think we should add fflush(3) call to smtp-dummy in any case.
\r
84 True. In a separate patch.
\r
86 > As for sending QUIT over TCP vs kill, I prefer the former. On one hand,
\r
87 > kill is more reliable. But smtp-dummy must handle QUIT and it is a bug
\r
90 Me too, basically for the same reasons. It is also aesthetically nicer
\r
91 not to kill anything ;)
\r
93 > An unrelated issue: currently we discard test_emacs output in
\r
94 > emacs_deliver_message and other cases. Ideally we should not do that
\r
95 > because it may contain useful information. We should capture the output
\r
96 > and print it in case of error, at least.
\r
98 I agree. And if id:"<1309487028-18786-1-git-send-email-dmitry.kurochkin@gmail.com>"
\r
99 is applied before creating new patch based on this then these 2 apply cleanly.
\r