1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2B6AD431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Dec 2012 06:47:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 5G3ETPjWz6z7 for <notmuch@notmuchmail.org>;
\r
16 Sun, 2 Dec 2012 06:47:21 -0800 (PST)
\r
17 Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com
\r
18 [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 76DF4431FAE
\r
21 for <notmuch@notmuchmail.org>; Sun, 2 Dec 2012 06:47:21 -0800 (PST)
\r
22 Received: by mail-lb0-f181.google.com with SMTP id ge1so1792623lbb.26
\r
23 for <notmuch@notmuchmail.org>; Sun, 02 Dec 2012 06:47:20 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type:x-gm-message-state;
\r
28 bh=w95pW4lesVOiMnQbtOaYbBia5XNZ/gajsqNgV/Xdf74=;
\r
29 b=mznj0jkaNEB8MQh903n/9sIQfrHtekld2VucdGg4/m+Jd9tTXc0KCzO3Cs5s45yYjU
\r
30 kJV+R0RllTxgHIRU9c3wSM1W0JuyTOnMdUTAdjno3KpTnl76Xi8qVnBbtlECc57gyPMc
\r
31 PMelQSQbau1ABF5NM0IsqQB3gZ2Ti4TaEec4feVweYUYWwzDEvXkQqQGtXunKVWmqlqz
\r
32 g5mNg6+uVRR47S0wHGNZelqDvaAPpBg+q2Frfx/39vfD9Beqn/pP/p2yznkPxP1ePXFR
\r
33 6ayTokCV0UV4X2vtNjRgw7y2BYEVcb8qWFbQoh0TjWfRy2O5pQWy6Fo78nBPjB4YGDbL
\r
35 Received: by 10.152.108.197 with SMTP id hm5mr6769487lab.45.1354459639951;
\r
36 Sun, 02 Dec 2012 06:47:19 -0800 (PST)
\r
37 Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.
\r
39 by mx.google.com with ESMTPS id gt17sm4099896lab.6.2012.12.02.06.47.18
\r
40 (version=SSLv3 cipher=OTHER); Sun, 02 Dec 2012 06:47:19 -0800 (PST)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: david@tethera.net, notmuch@notmuchmail.org
\r
43 Subject: Re: V2 of batch-tagging plus new dump/restore
\r
44 In-Reply-To: <1353792017-31459-1-git-send-email-david@tethera.net>
\r
45 References: <1353792017-31459-1-git-send-email-david@tethera.net>
\r
46 User-Agent: Notmuch/0.14+124~g3b17402 (http://notmuchmail.org) Emacs/23.4.1
\r
48 Date: Sun, 02 Dec 2012 16:47:16 +0200
\r
49 Message-ID: <87r4n8cxzf.fsf@nikula.org>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
53 ALoCoQk0JL5a8LFMHTKbtj9d/AXROLOdoH3bnXeoc4kG1GICqEfBP6QIPV894VsQlKXP7LU5+6fJ
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Sun, 02 Dec 2012 14:47:26 -0000
\r
71 Good job! And thanks for resurrecting batch tagging.
\r
73 Apart from a few actual bugs and a bag of nitpicks, I think this looks
\r
74 very good overall. And I don't think any of the issues are very
\r
75 difficult to fix (some of the nitpicks you can just outright ignore; use
\r
76 your discretion). We should definitely get this done for the next
\r
83 On Sat, 24 Nov 2012, david@tethera.net wrote:
\r
84 > this obsoletes: id:1353265498-3839-1-git-send-email-david@tethera.net
\r
86 > Changes based on Mark's review
\r
88 > - add commments for each function in tag-util.h
\r
90 > - inline tag_op_list_from_string in the one place it was called
\r
92 > - remove NULL terminator from tag_op_list (for mark); along with
\r
93 > tag_op_list_t being opaque, I thought is was ok to leave off the
\r
94 > comment on ops. But I could be convinced.
\r
96 > - make tag_op_list_t typedef opaque
\r
98 > - add BE_GENEROUS flag to parser. Currently this enables empty tags.
\r
100 > - handle blank lines and comments in restore and batch tagging
\r
102 > - fixed the commit message about "notmuch-new"
\r
104 > Changes based on Ethan's review:
\r
106 > - remove the dreaded . from first line of commit messages
\r
108 > - convert if on l49 of database-test.c into explicit return on error
\r
110 > - add comments and parens for num_tags and this_mid_len in random_corpus.c
\r
112 > - add check for message-id's less than length 1. I wasn't sure why we
\r
113 > would disallow all message ids of length 1.
\r
115 > - remove declaration of parse_tag_stream
\r
117 > - explain "query_string += 3"
\r
119 > - fix typo in notmuch-dump.1
\r
121 > _______________________________________________
\r
122 > notmuch mailing list
\r
123 > notmuch@notmuchmail.org
\r
124 > http://notmuchmail.org/mailman/listinfo/notmuch
\r