1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 346D9431FD9
\r
6 for <notmuch@notmuchmail.org>; Wed, 23 Jan 2013 09:25:49 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id J07Z3jpF00Ea for <notmuch@notmuchmail.org>;
\r
16 Wed, 23 Jan 2013 09:25:48 -0800 (PST)
\r
17 Received: from mail-la0-f46.google.com (mail-la0-f46.google.com
\r
18 [209.85.215.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 546E4431FAE
\r
21 for <notmuch@notmuchmail.org>; Wed, 23 Jan 2013 09:25:48 -0800 (PST)
\r
22 Received: by mail-la0-f46.google.com with SMTP id fq12so6630168lab.33
\r
23 for <notmuch@notmuchmail.org>; Wed, 23 Jan 2013 09:25:46 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=x-received:from:to:cc:subject:in-reply-to:references:user-agent
\r
27 :date:message-id:mime-version:content-type:x-gm-message-state;
\r
28 bh=vF41OE51BPGhq5L+CiRI4RdPpn1A1ysyWJ4A05+pDbI=;
\r
29 b=KcwaMGvRzq6j0R3PR6wl9jn07dF8WoK8alttSwsdF6w9ubBOgwh13YL6bi6TK5XNPF
\r
30 /zJpaMXKogFy6crQXxdEtieqoDMPJb6WXYWP8JhHKQDfJdfXNEqgHHZw7nfvNojOm5YI
\r
31 x9OjtW80W+kWWRyEq02wxwA4RDPW6jNu0iprjspIfY02vdkiAy55c5gvPxUYg5m+X7BP
\r
32 hk+ZFMM+vNzlK+cahi7VKvbLQQi3hv4hXPPPZpMAof8NdPiXVaJIW+UeduD9lfy9h/4D
\r
33 zxq2Ri6+mF+x9stOwSpFrs3BZ339Byj/fr9twk3E+4bowzwaB7DHGFXu/vkVz5A0rKpu
\r
35 X-Received: by 10.152.105.17 with SMTP id gi17mr2015177lab.46.1358961945413;
\r
36 Wed, 23 Jan 2013 09:25:45 -0800 (PST)
\r
37 Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi.
\r
39 by mx.google.com with ESMTPS id z4sm8676437lbn.17.2013.01.23.09.25.42
\r
40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
41 Wed, 23 Jan 2013 09:25:44 -0800 (PST)
\r
42 From: Jani Nikula <jani@nikula.org>
\r
43 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
44 Subject: Re: [PATCH 1/1] test/test-lib.sh: use vt100 as dtach terminal if TERM
\r
46 In-Reply-To: <1358933736-300-1-git-send-email-tomi.ollila@iki.fi>
\r
47 References: <1358933736-300-1-git-send-email-tomi.ollila@iki.fi>
\r
48 User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/24.2.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Wed, 23 Jan 2013 19:25:39 +0200
\r
51 Message-ID: <87fw1r6cbw.fsf@nikula.org>
\r
53 Content-Type: text/plain
\r
55 ALoCoQn47Iwi0uXp2SQ+5NynLm56NcJ/N/wZlG7DTLzpc9MpCh5xCMn0KDOmf9MCbzdJMOQYHujk
\r
56 Cc: tomi.ollila@iki.fi
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Wed, 23 Jan 2013 17:25:49 -0000
\r
71 On Wed, 23 Jan 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
72 > The TERM environment variable is set to 'dumb' when running tests, but
\r
73 > the original value of it is stored for echoing colors and running (emacs
\r
77 > (somewhat interactively) in detached session. Emacs requires some
\r
78 > terminal control sequences to be available for interactive operation.
\r
79 > In case original TERM is (also) 'dumb' (or nonexistent) emacs cannot run
\r
80 > interactively. To fix this problem dtach (and emacs as it's child
\r
81 > process) is run with TERM=vt100 in case original TERM was nonexistent or
\r
82 > dumb. This way there is a chance to run emacs tests with different user
\r
83 > terminals and potentially find problems there.
\r
85 > test/test-lib.sh | 9 +++++++--
\r
86 > 1 file changed, 7 insertions(+), 2 deletions(-)
\r
88 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
89 > index 6ce3b31..3bc67f7 100644
\r
90 > --- a/test/test-lib.sh
\r
91 > +++ b/test/test-lib.sh
\r
92 > @@ -41,6 +41,10 @@ esac
\r
93 > # Keep the original TERM for say_color and test_emacs
\r
94 > ORIGINAL_TERM=$TERM
\r
96 > +# dtach(1) provides more capable terminal environment to anything
\r
97 > +# that requires more than dumb terminal...
\r
98 > +[ x"${TERM:-dumb}" = xdumb ] && DTACH_TERM=vt100 || DTACH_TERM=$TERM
\r
100 That's just a tiny bit more trickery than I usually like... but then
\r
101 it's shell after all... :)
\r
104 > # For repeatability, reset the environment to known value.
\r
107 > @@ -996,9 +1000,10 @@ test_emacs () {
\r
109 > server_name="notmuch-test-suite-$$"
\r
110 > # start a detached session with an emacs server
\r
111 > - # user's TERM is given to dtach which assumes a minimally
\r
112 > + # user's TERM (or 'vt100' om case user's term is nonexistent
\r
113 > + # or 'dumb') is given to dtach which assumes a minimally
\r
117 Otherwise LGTM, and works as advertised.
\r
122 > # VT100-compatible terminal -- and emacs inherits that
\r
123 > - TERM=$ORIGINAL_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" \
\r
124 > + TERM=$DTACH_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" \
\r
125 > sh -c "stty rows 24 cols 80; exec '$TMP_DIRECTORY/run_emacs' \
\r
126 > --no-window-system \
\r
127 > $load_emacs_tests \
\r
131 > _______________________________________________
\r
132 > notmuch mailing list
\r
133 > notmuch@notmuchmail.org
\r
134 > http://notmuchmail.org/mailman/listinfo/notmuch
\r