c6/7e034889ad2edee7350d2f06727da9e5f51daa

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id C5BD7431FD0\r
   6         for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 16:33:27 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id 43WkgASZWzUB for <notmuch@notmuchmail.org>;\r
  16         Sun,  8 Dec 2013 16:33:20 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu\r
  18         [18.7.68.34])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 33B52431FCB\r
  20         for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 16:33:20 -0800 (PST)\r
  21 X-AuditID: 12074422-b7f9d6d000000bc0-ad-52a50fcf1ab9\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         (using TLS with cipher AES256-SHA (256/256 bits))\r
  24         (Client did not present a certificate)\r
  25         by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
  26         id 27.6A.03008.FCF05A25; Sun,  8 Dec 2013 19:33:19 -0500 (EST)\r
  27 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  28         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id rB90XIfW018130; \r
  29         Sun, 8 Dec 2013 19:33:19 -0500\r
  30 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  31         (authenticated bits=0)\r
  32         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  33         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id rB90XG80008050\r
  34         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  35         Sun, 8 Dec 2013 19:33:17 -0500\r
  36 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  37         (envelope-from <amdragon@mit.edu>)\r
  38         id 1Vpomh-0006QM-SI; Sun, 08 Dec 2013 19:33:15 -0500\r
  39 Date: Sun, 8 Dec 2013 19:33:15 -0500\r
  40 From: Austin Clements <amdragon@MIT.EDU>\r
  41 To: Tomi Ollila <tomi.ollila@iki.fi>\r
  42 Subject: Re: [PATCH v3 part 3/3] test: implement and document\r
  43         NOTMUCH_TEST_QUIET variable usage\r
  44 Message-ID: <20131209003315.GA24583@mit.edu>\r
  45 References: <1385399299-12936-1-git-send-email-tomi.ollila@iki.fi>\r
  46         <1386247560-31903-1-git-send-email-tomi.ollila@iki.fi>\r
  47 MIME-Version: 1.0\r
  48 Content-Type: text/plain; charset=us-ascii\r
  49 Content-Disposition: inline\r
  50 In-Reply-To: <1386247560-31903-1-git-send-email-tomi.ollila@iki.fi>\r
  51 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  52 X-Brightmail-Tracker:\r
  53  H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hTV1j3PvzTI4Gi7lsX1mzOZLd6snMfq\r
  54         wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGUc3jeRpeA1e8W/bYsZGxhb2LoYOTkkBEwk\r
  55         Nmxbzgxhi0lcuLceKM7FISQwm0li9sw5LBDOBkaJXbOeMkE4p5gkmiZfZYRwljBKrHqzgh2k\r
  56         n0VARWL67AWsIDabgIbEtv3LGUFsEaD4g7b1YHFmAWmJb7+bmUBsYYFEiTlXz4Lt5hXQkejs\r
  57         2Qs2R0igWuJMzz+ouKDEyZlPWCB6tSRu/HsJ1MsBNmf5Pw6QMKeAs8TBl1fBxosCrZpychvb\r
  58         BEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuqV5uZoleakrpJkZQYLO7\r
  59         KO1g/HlQ6RCjAAejEg/vCtalQUKsiWXFlbmHGCU5mJREeSdzA4X4kvJTKjMSizPii0pzUosP\r
  60         MUpwMCuJ8CqdWBIkxJuSWFmVWpQPk5LmYFES573FYR8kJJCeWJKanZpakFoEk5Xh4FCS4H3H\r
  61         BzRUsCg1PbUiLTOnBCHNxMEJMpwHaHgUSA1vcUFibnFmOkT+FKOilDgvJzB1CAmAJDJK8+B6\r
  62         YYnnFaM40CvCvJdB2nmASQuu+xXQYCagwZOuLgIZXJKIkJJqYOSXneF45+c35zVac/ek3rKf\r
  63         mJNfJaUh/LZX5OVM59iHe2tmT94W3H7x+3cDgbafnnksSsrdmWyd1Rm35Re9maDm/O3o2plr\r
  64         mBc+WX9jr6Xct9qLWv5Rpy5yaKz9Knswr+nXkpfl4iIFxtldfZxH1SJf64gENBsu0b7YqX1h\r
  65         e+MJi022/pMDHymxFGckGmoxFxUnAgBv37V+FwMAAA==\r
  66 Cc: notmuch@notmuchmail.org\r
  67 X-BeenThere: notmuch@notmuchmail.org\r
  68 X-Mailman-Version: 2.1.13\r
  69 Precedence: list\r
  70 List-Id: "Use and development of the notmuch mail system."\r
  71         <notmuch.notmuchmail.org>\r
  72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  73         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  75 List-Post: <mailto:notmuch@notmuchmail.org>\r
  76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  78         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  79 X-List-Received-Date: Mon, 09 Dec 2013 00:33:28 -0000\r
  80 \r
  81 v3 LGTM.\r
  82 \r
  83 Quoth Tomi Ollila on Dec 05 at  2:46 pm:\r
  84 > When NOTMUCH_TEST_QUIET environment variable is set to non-null value\r
  85 > messages when new test script starts and when test PASSes are disabled.\r
  86 > This eases picking the cases when tests FAIL (as those are still printed).\r
  87 > ---\r
  88 > \r
  89 > Diffdiff of part 3 to previous.\r
  90 > \r
  91 > | diff --git a/test/test-lib.sh b/test/test-lib.sh\r
  92 > | index 9d4a807..d8e0d91 100644\r
  93 > | --- a/test/test-lib.sh\r
  94 > | +++ b/test/test-lib.sh\r
  95 > | @@ -733,9 +733,7 @@ test_failure_ () {\r
  96 > |             return\r
  97 > |     fi\r
  98 > |     test_failure=$(($test_failure + 1))\r
  99 > | -   if test -n "$NOTMUCH_TEST_QUIET"; then\r
 100 > | -           print_test_description\r
 101 > | -   fi\r
 102 > | +   print_test_description\r
 103 > |     test_failure_message_ "FAIL" "$test_subtest_name" "$@"\r
 104 > |     test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }\r
 105 > |     return 1\r
 106 > \r
 107 > \r
 108 >  test/README      | 8 ++++++++\r
 109 >  test/basic       | 4 ++--\r
 110 >  test/test-lib.sh | 9 ++++++++-\r
 111 >  3 files changed, 18 insertions(+), 3 deletions(-)\r