1 Return-Path: <fcarrijo@yahoo.com.br>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DF1F7431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 9 Dec 2009 11:09:06 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id I6G5tez2wLao for <notmuch@notmuchmail.org>;
\r
11 Wed, 9 Dec 2009 11:09:06 -0800 (PST)
\r
12 Received: from n21.bullet.mail.mud.yahoo.com (n21.bullet.mail.mud.yahoo.com
\r
14 by olra.theworths.org (Postfix) with SMTP id 2A3EC431FAE
\r
15 for <notmuch@notmuchmail.org>; Wed, 9 Dec 2009 11:09:06 -0800 (PST)
\r
16 Received: from [68.142.200.226] by n21.bullet.mail.mud.yahoo.com with NNFMP;
\r
17 09 Dec 2009 19:09:05 -0000
\r
18 Received: from [68.142.201.245] by t7.bullet.mud.yahoo.com with NNFMP;
\r
19 09 Dec 2009 19:09:05 -0000
\r
20 Received: from [127.0.0.1] by omp406.mail.mud.yahoo.com with NNFMP;
\r
21 09 Dec 2009 19:09:05 -0000
\r
22 X-Yahoo-Newman-Id: 697716.31531.bm@omp406.mail.mud.yahoo.com
\r
23 Received: (qmail 37591 invoked from network); 9 Dec 2009 19:09:05 -0000
\r
24 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.br;
\r
25 h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:Message-ID:MIME-Version:Content-Type;
\r
26 b=RxkbrVWN6JJuc9S+enZ+lC2qiai87cNDRp+fJEut4UYmdvZS9Yn0uU3hAJH8WhBr3ZO9euaNBOY9zvJBodKyL5Wuz37JHvkv+jJ6mItqF24uhtLstkPSUQIoxqyX13HUpBVAKvnPWb7xXNNcpuUUgjeQhIE+IRrzZZRUOAhsHYc= ;
\r
27 Received: from 189.27.100.158.dynamic.adsl.gvt.net.br (fcarrijo@189.27.100.158
\r
29 by smtp141.mail.mud.yahoo.com with SMTP; 09 Dec 2009 11:09:05 -0800 PST
\r
30 X-Yahoo-SMTP: NgkT36eswBAymTD26_IxCjMQ0A5a
\r
31 X-YMail-OSG: l_x0eLYVM1nlLhxSA3td7W3.eYzSPVkejuNGmeFvcAIdbs.uGAQkKhMQMb8agMdffopGvmLyIf..DxiJ_PsAQkOfA8l0NqlgpMF1GSyUvhRkLAOYLg5oDmqWPbLtmwo2l5SuOaJu0RE6J6wvmQM7YKXT_i_HhJcGnsciK2GxkqSkEyg4l07XlJYQCDNCizQWfz5KA77Yi31QmKNfZoKASZTDuwp.3.BO7qcUPn72GvOU6f0t9KempoCuB9lO63h5jnexxVgizkjBzzx1s.tDb0TIeN2.veCc.iqda7YGaJqyC.p2Uvbrg.6nDS7f5FGl4Q--
\r
32 X-Yahoo-Newman-Property: ymail-3
\r
33 From: Fernando Carrijo <fcarrijo@yahoo.com.br>
\r
34 To: notmuch@notmuchmail.org
\r
35 Date: Wed, 09 Dec 2009 17:09:01 -0200
\r
36 Message-ID: <877hswyng2.fsf@yahoo.com.br>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 Subject: [notmuch] [PATCH] Nuke the remainings of
\r
40 _notmuch_message_add_thread_id.
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.12
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Wed, 09 Dec 2009 19:09:07 -0000
\r
56 The function _notmuch_message_add_thread_id has been removed
\r
57 from the private interface of notmuch. There's no reason for
\r
58 one to keep a declaration of its prototype in the code base.
\r
59 Also, lets update a commentary that referenced that function
\r
60 and escaped from previous scrutiny.
\r
62 Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
\r
64 lib/database.cc | 9 ++++-----
\r
65 lib/notmuch-private.h | 4 ----
\r
66 2 files changed, 4 insertions(+), 9 deletions(-)
\r
68 diff --git a/lib/database.cc b/lib/database.cc
\r
69 index 23ddd4a..b6c4d07 100644
\r
70 --- a/lib/database.cc
\r
71 +++ b/lib/database.cc
\r
72 @@ -855,12 +855,11 @@ _notmuch_database_link_message_to_children (notmuch_database_t *notmuch,
\r
74 * We first look at 'message_file' and its link-relevant headers
\r
75 * (References and In-Reply-To) for message IDs. We also look in the
\r
76 - * database for existing message that reference 'message'.p
\r
77 + * database for existing message that reference 'message'.
\r
79 - * The end result is to call _notmuch_message_add_thread_id with one
\r
80 - * or more thread IDs to which this message belongs, (including
\r
81 - * generating a new thread ID if necessary if the message doesn't
\r
82 - * connect to any existing threads).
\r
83 + * The end result is to call _notmuch_message_ensure_thread_id which
\r
84 + * generates a new thread ID if the message doesn't connect to any
\r
85 + * existing threads.
\r
87 static notmuch_status_t
\r
88 _notmuch_database_link_message (notmuch_database_t *notmuch,
\r
89 diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
\r
90 index 0c340a7..116f63d 100644
\r
91 --- a/lib/notmuch-private.h
\r
92 +++ b/lib/notmuch-private.h
\r
93 @@ -194,10 +194,6 @@ _notmuch_message_set_filename (notmuch_message_t *message,
\r
94 const char *filename);
\r
97 -_notmuch_message_add_thread_id (notmuch_message_t *message,
\r
98 - const char *thread_id);
\r
101 _notmuch_message_ensure_thread_id (notmuch_message_t *message);
\r