c3/bd6cd42999cb257d52e2b3a38adb2adbfa34b6

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 620A1431FC0\r
   6         for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:17:53 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id Y6Exg21L3DP9 for <notmuch@notmuchmail.org>;\r
  16         Wed, 18 Jul 2012 13:17:53 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id B4C8F431FAE\r
  20         for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:17:52 -0700 (PDT)\r
  21 X-AuditID: 12074425-b7f9b6d0000008c4-77-500719ef5ce6\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id E7.55.02244.FE917005; Wed, 18 Jul 2012 16:17:52 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q6IKHoQc019065; \r
  27         Wed, 18 Jul 2012 16:17:51 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6IKHmOe022111\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Wed, 18 Jul 2012 16:17:50 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1Sragu-00019T-5r; Wed, 18 Jul 2012 16:17:48 -0400\r
  37 Date: Wed, 18 Jul 2012 16:17:48 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Adrien Bustany <adrien@bustany.org>\r
  40 Subject: Re: [PATCH 1/7] go: Use iota in enum bindings\r
  41 Message-ID: <20120718201748.GS31670@mit.edu>\r
  42 References: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
  43         <1342636475-16057-2-git-send-email-adrien@bustany.org>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain; charset=us-ascii\r
  46 Content-Disposition: inline\r
  47 In-Reply-To: <1342636475-16057-2-git-send-email-adrien@bustany.org>\r
  48 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  49 X-Brightmail-Tracker:\r
  50  H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1v0gyR5gMP0bk8X6O2vZLK7fnMns\r
  51         wOTx8cA9Jo9nq24xBzBFcdmkpOZklqUW6dslcGV8uHuJveAcT8Wv/c1MDYzdXF2MnBwSAiYS\r
  52         11/uZYKwxSQu3FvP1sXIxSEksI9RYk/LFFaQhJDABkaJ3uYIiMRJJokp5/exQjhLGCUeNn4B\r
  53         a2cRUJXY+OokmM0moCGxbf9yRhBbREBdYkdnO5jNLCAt8e13M1ANB4ewgJnE1+u1IGFeAR2J\r
  54         v3c2Qy2rltj0dg0rRFxQ4uTMJywQrVoSN/69BGsFGbP8HwdImFPAWeLHzl3sILaogIrElJPb\r
  55         2CYwCs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdC30cjNL9FJTSjcxgoKa\r
  56         3UV1B+OEQ0qHGAU4GJV4eB/sYg0QYk0sK67MPcQoycGkJMr7SYg9QIgvKT+lMiOxOCO+qDQn\r
  57         tfgQowQHs5II7wNBoBxvSmJlVWpRPkxKmoNFSZz3RspNfyGB9MSS1OzU1ILUIpisDAeHkgSv\r
  58         NDB6hQSLUtNTK9Iyc0oQ0kwcnCDDeYCG84LU8BYXJOYWZ6ZD5E8x6nJce3jrFqMQS15+XqqU\r
  59         OO8bCaAiAZCijNI8uDmwZPSKURzoLWFePpBRPMBEBjfpFdASJqAl3MVsIEtKEhFSUg2MRbM2\r
  60         SsWwKXBbuDYefXaJ3/tU+ox5/ZuCg+40hBx/WvA++rgU2+W1t/s+vS4I/iFiN+E0810/0U83\r
  61         r21L1j20KJPnftBbqycr1d5kBzZf3OZQq36j9tCcHzYVQp8dbmsx3eIt49l7apO0fqXZ43zL\r
  62         06J7Hr2Wnx0fs6nt5W0xD/E+hmu3an+sU2Ipzkg01GIuKk4EAAaF7lEhAwAA\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Wed, 18 Jul 2012 20:17:53 -0000\r
  77 \r
  78 Hah.  I guess nobody has tried to modify a notmuch database using the\r
  79 Go bindings.\r
  80 \r
  81 Could this instead assign the constants to\r
  82 C.NOTMUCH_DATABASE_MODE_READ_ONLY, etc, rather than duplicating their\r
  83 values?  It would be nice to do that for the Status values as well\r
  84 (which are correctly using iota, at least).\r
  85 \r
  86 Quoth Adrien Bustany on Jul 18 at  9:34 pm:\r
  87 > Using iota is the correct way to get the values in the enum increment\r
  88 > automatically. The old code would just set all the enum values to 0.\r
  89 > ---\r
  90 >  bindings/go/src/notmuch/notmuch.go |    6 +++---\r
  91 >  1 files changed, 3 insertions(+), 3 deletions(-)\r
  92 > \r
  93 > diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go\r
  94 > index 00bd53a..ecd7418 100644\r
  95 > --- a/bindings/go/src/notmuch/notmuch.go\r
  96 > +++ b/bindings/go/src/notmuch/notmuch.go\r
  97 > @@ -86,7 +86,7 @@ type Filenames struct {\r
  98 >  type DatabaseMode C.notmuch_database_mode_t\r
  99 >  \r
 100 >  const (\r
 101 > -     DATABASE_MODE_READ_ONLY DatabaseMode = 0\r
 102 > +     DATABASE_MODE_READ_ONLY DatabaseMode = iota\r
 103 >       DATABASE_MODE_READ_WRITE\r
 104 >  )\r
 105 >  \r
 106 > @@ -386,7 +386,7 @@ func (self *Database) CreateQuery(query string) *Query {\r
 107 >  type Sort C.notmuch_sort_t\r
 108 >  \r
 109 >  const (\r
 110 > -     SORT_OLDEST_FIRST Sort = 0\r
 111 > +     SORT_OLDEST_FIRST Sort = iota\r
 112 >       SORT_NEWEST_FIRST\r
 113 >       SORT_MESSAGE_ID\r
 114 >       SORT_UNSORTED\r
 115 > @@ -774,7 +774,7 @@ func (self *Message) GetFileName() string {\r
 116 >  type Flag C.notmuch_message_flag_t\r
 117 >  \r
 118 >  const (\r
 119 > -     MESSAGE_FLAG_MATCH Flag = 0\r
 120 > +     MESSAGE_FLAG_MATCH Flag = iota\r
 121 >  )\r
 122 >  \r
 123 >  /* Get a value of a flag for the email corresponding to 'message'. */\r