1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 174E9431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 2 Sep 2014 13:22:55 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id H-d5P1e0EcAk for <notmuch@notmuchmail.org>;
\r
16 Tue, 2 Sep 2014 13:22:47 -0700 (PDT)
\r
17 Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
\r
18 [209.85.212.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 7D1B4431FAF
\r
21 for <notmuch@notmuchmail.org>; Tue, 2 Sep 2014 13:22:47 -0700 (PDT)
\r
22 Received: by mail-wi0-f172.google.com with SMTP id n3so15034708wiv.17
\r
23 for <notmuch@notmuchmail.org>; Tue, 02 Sep 2014 13:22:44 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=Je4N5AHSKw1qdJdvezbJBqzWHgl/9fYGqaSM7BCZ2JM=;
\r
29 b=ilq50w+pu1w3b10utn5h70vzY3935Mgr0diLb24fR1QkSZy0Dhp3VjJd1xkpJ3rPLi
\r
30 BHo3z8hiCVGRDMiBoN0kOKcBS9xmd7tADmWl7ZovLVov++FD8CTYDjzY5izU0C/XK97j
\r
31 vfFUs7xxkVYKuDN87y69eheOqGEdRFHOGUXy3TAa1PCxurMLaaB9lREGnRyqt6Su0zbx
\r
32 CRdyaB5+BxH2unR8pJnORjPqdN7x4CnwC2hckulf0naU3Y82Lo06m2fdKJmH3RLjcg7p
\r
33 UJw/0K/eyqO6rGLy+2kpBIkqfWgEuSsnimegw6paNuR8ZFgfX0UzLF2nFOOxjULEIzs/
\r
36 ALoCoQnh63qRzygOVaDvRoWMNYl5fu7f/7g+ziJWF57E3+ZkzIOD3htACXv/SBiV99CvW/B9Wt1I
\r
37 X-Received: by 10.180.100.202 with SMTP id fa10mr24800810wib.32.1409689364746;
\r
38 Tue, 02 Sep 2014 13:22:44 -0700 (PDT)
\r
39 Received: from localhost (dsl-hkibrasgw2-58c374-75.dhcp.inet.fi.
\r
40 [88.195.116.75]) by mx.google.com with ESMTPSA id
\r
41 am1sm11680220wjc.29.2014.09.02.13.22.43 for <multiple recipients>
\r
42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
43 Tue, 02 Sep 2014 13:22:44 -0700 (PDT)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH v2] emacs: jump: sort-order bugfix
\r
47 In-Reply-To: <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>
\r
48 References: <1409661049-23417-1-git-send-email-markwalters1009@gmail.com>
\r
49 <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>
\r
50 User-Agent: Notmuch/0.18.1+65~g9f0f30f (http://notmuchmail.org) Emacs/24.3.1
\r
51 (x86_64-pc-linux-gnu)
\r
52 Date: Tue, 02 Sep 2014 23:22:42 +0300
\r
53 Message-ID: <87tx4pvkkt.fsf@nikula.org>
\r
55 Content-Type: text/plain
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Tue, 02 Sep 2014 20:22:55 -0000
\r
70 On Tue, 02 Sep 2014, Mark Walters <markwalters1009@gmail.com> wrote:
\r
71 > default-value needs its argument to be quoted.
\r
73 > Slightly strangely default-value of 't or nil is 't or nil
\r
74 > respectively so the code
\r
76 > (default-value notmuch-search-oldest-first)
\r
78 > just gives the current value of notmuch-search-oldest-first rather
\r
79 > than intended default-value of this variable.
\r
81 > The symptom is that if you are in a search buffer and use notmuch jump
\r
82 > to run a saved search which does not have an explicitly set sort order
\r
83 > then the sort order of the saved-search is inherited from the current
\r
84 > search buffer rather than being the default search order.
\r
86 > Thanks to Jani for finding the bug.
\r
88 This fixes the issue, thanks for the patch.
\r
96 > This time with a fuller commit message.
\r
98 > (Part of the reason I did not send more before is I had not checked
\r
99 > what the exact outcome of the buggy code was: it was obvious what the
\r
100 > code was intended to do, and that with the extra quote it
\r
101 > would do what it was intended to do.)
\r
113 > emacs/notmuch-jump.el | 2 +-
\r
114 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
116 > diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el
\r
117 > index 5eb0949..0193f8c 100644
\r
118 > --- a/emacs/notmuch-jump.el
\r
119 > +++ b/emacs/notmuch-jump.el
\r
120 > @@ -51,7 +51,7 @@ (defun notmuch-jump-search ()
\r
121 > (case (plist-get saved-search :sort-order)
\r
122 > (newest-first nil)
\r
124 > - (otherwise (default-value notmuch-search-oldest-first)))))
\r
125 > + (otherwise (default-value 'notmuch-search-oldest-first)))))
\r
126 > (push (list key name
\r
127 > `(lambda () (notmuch-search ',query ',oldest-first)))
\r
132 > _______________________________________________
\r
133 > notmuch mailing list
\r
134 > notmuch@notmuchmail.org
\r
135 > http://notmuchmail.org/mailman/listinfo/notmuch
\r