1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 52B92431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 11 Oct 2013 08:15:54 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id iO9aUefRIVrb for <notmuch@notmuchmail.org>;
\r
16 Fri, 11 Oct 2013 08:15:48 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 833BA431FAE
\r
21 for <notmuch@notmuchmail.org>; Fri, 11 Oct 2013 08:15:48 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1VUeRJ-0007N0-9d; Fri, 11 Oct 2013 12:15:41 -0300
\r
25 Received: (nullmailer pid 28207 invoked by uid 1000); Fri, 11 Oct 2013
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Tomi Ollila <tomi.ollila@iki.fi>, Ben Gamari <bgamari.foss@gmail.com>,
\r
29 notmuch@notmuchmail.org
\r
30 Subject: Re: [PATCH 1/3] database: Add notmuch_database_compact_close
\r
31 In-Reply-To: <m2ob6xw4bw.fsf@guru.guru-group.fi>
\r
32 References: <1380745848-4972-1-git-send-email-bgamari.foss@gmail.com>
\r
33 <1380745848-4972-2-git-send-email-bgamari.foss@gmail.com>
\r
34 <m2ob6xw4bw.fsf@guru.guru-group.fi>
\r
35 User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1
\r
36 (x86_64-pc-linux-gnu)
\r
37 Date: Fri, 11 Oct 2013 12:15:37 -0300
\r
38 Message-ID: <878uxzq1nq.fsf@unb.ca>
\r
40 Content-Type: text/plain
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Fri, 11 Oct 2013 15:15:54 -0000
\r
55 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
57 > From functionality point if view this looks safe to me.
\r
58 > A followup patch could provide more information to the user
\r
59 > is any of the following attemts fail, e.g.
\r
61 > - if removing old database out of the way how to remove the new
\r
62 > compacted database which can be considered as garbage now -- or
\r
63 > how to rename it (which is a bit dangerous due to potential races)
\r
65 > - if moving compacted database fails how to restore backup database...
\r
66 > ... or how to move compacted database to where it was supposed to be
\r
67 > moved so that database is usable...
\r
69 > ... if the database is missing is new created from scratch, also in case
\r
70 > there already is .notmuch directory ?
\r
72 > ... should the database open try to open database from these alternative
\r
73 > names in case opening from original name fails ?
\r
75 > another, small change:
\r
77 > case "${xapian_version}" in
\r
78 > - 0.*|1.[01].*|1.2.[0-5])
\r
79 > + 0.*|1.[01].*|1.2.[0-5]|1.2.[0-5][^0-9]*)
\r
80 > printf "No (only available with Xapian > 1.2.6).\n" ;;
\r
82 > someone might do version like 1.2.4-abc but probably not 1.2.04 (nor 1.2a.4)
\r
84 > (side note: case $x in [^...]) works with bash (and ksh&zsh, but not with dash)
\r
86 OK, let's leave those merged, and clean up these issues before the next
\r