1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 96B86431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 17 May 2012 12:09:30 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id dh8H9tC4TvhE for <notmuch@notmuchmail.org>;
\r
16 Thu, 17 May 2012 12:09:29 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 4907C431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 17 May 2012 12:09:29 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 1AB9D100639; Thu, 17 May 2012 22:09:36 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH 1/3] NEWS: Insert markdown formatting commands in 0.13
\r
26 In-Reply-To: <87boln639t.fsf@zancas.localnet>
\r
27 References: <1337146745-21525-1-git-send-email-tomi.ollila@iki.fi>
\r
28 <m28vgsbn3r.fsf@guru.guru-group.fi>
\r
29 <87boln639t.fsf@zancas.localnet>
\r
30 User-Agent: Notmuch/0.13~rc1+23~gefd2384 (http://notmuchmail.org) Emacs/23.1.1
\r
31 (x86_64-redhat-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Thu, 17 May 2012 22:09:35 +0300
\r
36 Message-ID: <m2bolm62vk.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Thu, 17 May 2012 19:09:30 -0000
\r
53 On Thu, May 17 2012, David Bremner <david@tethera.net> wrote:
\r
55 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
57 >> id:"1337152910-22371-4-git-send-email-tomi.ollila@iki.fi"
\r
58 >> id:"1337152910-22371-5-git-send-email-tomi.ollila@iki.fi"
\r
59 >> id:"1337152910-22371-6-git-send-email-tomi.ollila@iki.fi"
\r
60 >> id:"1337152910-22371-7-git-send-email-tomi.ollila@iki.fi"
\r
62 > I pushed those to release. I'll merge them to master after a bit;
\r
63 > hopefully we'll figure out that reply encoding thing and do a bug fix
\r
66 I got it working by doing this:
\r
68 --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
\r
69 diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
\r
70 index 7fa441a..7523bb6 100644
\r
71 --- a/emacs/notmuch-lib.el
\r
72 +++ b/emacs/notmuch-lib.el
\r
73 @@ -244,7 +244,9 @@ the given type."
\r
74 current buffer, if possible."
\r
75 (let ((display-buffer (current-buffer)))
\r
77 - (let* ((charset (plist-get part :content-charset))
\r
78 + ;; (let* ((charset (or (plist-get part :content-charset) "utf-8"))
\r
79 + ;; (let* ((charset (or (plist-get part :content-charset) "latin-1"))
\r
80 + (let* ((charset (or (plist-get part :content-charset) 'gnus-decoded))
\r
81 (handle (mm-make-handle (current-buffer) `(,content-type (charset . ,charset)))))
\r
82 ;; If the user wants the part inlined, insert the content and
\r
83 ;; test whether we are able to inline it (which includes both
\r
84 --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
\r
86 (using "latin-1" also provided desired results... but with "utf-8" results
\r
87 were the same as with default 'nil)
\r
89 But, for consistency (with `notmuch show ...` handling), when content-type
\r
90 is "text/plain" (and as `notmuch reply --format=json` provides text/plain
\r
91 content inline) we should use the construct
\r
92 `(insert (notmuch-get-bodypart-content msg part nth ...)` to insert that
\r
93 content (as done before f6c170fabca8f39e74705e3813504137811bf162 and is
\r
94 also done in `notmuch-show-insert-part-text/plain`).
\r
96 If anyone is faster than me to provide patch what would be fine ;)
\r