1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3512D431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 10 Feb 2012 00:40:49 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 5eLEd2Brl8D8 for <notmuch@notmuchmail.org>;
\r
17 Fri, 10 Feb 2012 00:40:48 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id BC150431FAE
\r
22 for <notmuch@notmuchmail.org>; Fri, 10 Feb 2012 00:40:47 -0800 (PST)
\r
23 Received: by bkcjk7 with SMTP id jk7so2542739bkc.26
\r
24 for <notmuch@notmuchmail.org>; Fri, 10 Feb 2012 00:40:44 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type:content-transfer-encoding;
\r
28 bh=ThjjcjlffsiZN4LGTUQTvyPPPC6vruZiPr+/eBAiEGU=;
\r
29 b=DxO604tu+7CHKSnPipOfx+uXRj1rJoV79Ripe4scNkNwdPOsv+BjJ8Z9Chxcj8A4fJ
\r
30 JhfqV+tgoBuhTCtrU/u2PRAL9u6DEx6IsyhyUEju02M0qmjsXcENrdpP4q2yn8D6feQo
\r
31 g949zUodWiLBVZ4Ty8rSZ44DpasJg2L/qV8YM=
\r
32 Received: by 10.205.127.141 with SMTP id ha13mr2201628bkc.28.1328863244884;
\r
33 Fri, 10 Feb 2012 00:40:44 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id ez5sm15429007bkc.15.2012.02.10.00.40.43
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Fri, 10 Feb 2012 00:40:43 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
40 Subject: Re: [PATCH v4 2/4] reply: Add a JSON reply format.
\r
42 <CAMoJFUshAUAO6hnYWefXgdBdZe3qavgWokLC8du3VWGYDb9RUQ@mail.gmail.com>
\r
43 References: <1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca>
\r
44 <1328746916-25447-1-git-send-email-awg+notmuch@xvx.ca>
\r
45 <1328746916-25447-3-git-send-email-awg+notmuch@xvx.ca>
\r
46 <87mx8sa2tj.fsf@gmail.com>
\r
47 <CAMoJFUshAUAO6hnYWefXgdBdZe3qavgWokLC8du3VWGYDb9RUQ@mail.gmail.com>
\r
48 User-Agent: Notmuch/0.11.1+167~g6e72434 (http://notmuchmail.org) Emacs/23.3.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Fri, 10 Feb 2012 12:39:23 +0400
\r
51 Message-ID: <8762ff9j5w.fsf@gmail.com>
\r
53 Content-Type: text/plain; charset=utf-8
\r
54 Content-Transfer-Encoding: quoted-printable
\r
55 Cc: notmuch@notmuchmail.org
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Fri, 10 Feb 2012 08:40:50 -0000
\r
72 On Thu, 9 Feb 2012 21:27:29 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.ca> w=
\r
76 > On Thu, Feb 9, 2012 at 00:22, Dmitry Kurochkin
\r
77 > <dmitry.kurochkin@gmail.com> wrote:
\r
78 > >> Reply now enforces that only one message is returned, as the semantics
\r
79 > >> of replying to multiple messages are not wel-defined.
\r
83 > Oops! git filter-branch to the rescue :-).
\r
85 > >> Show is modified such that --format=3Djson no longer implies
\r
86 > >> --entire-thread, as MUAs will use --format=3Djson when constructing
\r
87 > >> replies. The man page is updated to reflect this change.
\r
89 > > I did not look into details. =C2=A0But I am surprised that user needs t=
\r
91 > > notmuch show --format=3Djson to make reply. =C2=A0I would expect notmuc=
\r
93 > > to provide all required info (except for bodies).
\r
95 > I agree, it would be ideal to include the data from show --format=3Djson
\r
96 > in the reply JSON. I started down the path of implementing this, but
\r
97 > realized it requires either copying quite a bit of code from show or
\r
98 > factoring it out, and both options felt kind of dirty. I'd like show
\r
99 > and reply to share a function that produces the JSON-formatted body of
\r
100 > a message, but it doesn't feel right to expose the entire JSON format
\r
101 > and all the functions that go with it from notmuch-show.c and put the
\r
102 > structure and all the prototypes in notmuch-client.h.
\r
107 > Will Austin's show rewrite make this easier/cleaner? Or am I being too
\r
108 > squeamish about moving code?
\r
113 > > Anyway, I think you should put this change in a separate patch.
\r
115 > Yeah, if I leave it as is it changes a default behavior, so a separate
\r
116 > patch would probably be a good idea.
\r
118 > > Also, we clearly need a NEWS entry for it and user-customizable Emacs
\r
119 > > variable changes. =C2=A0Though it can be done after this series is push=
\r
123 > I don't think there are any emacs customization changes here, unless
\r
124 > we want to implement the notmuch mode config file that was discussed
\r
125 > before to give message-citation-line-format and other things nice
\r
126 > defaults. Or are you suggesting that there should be some new
\r
127 > customization options? (One I can think of would be the list of
\r
128 > preferred types for multipart/alternative display, which right now is
\r
129 > hardcoded in notmuch-show.el.)
\r
132 No. I thought there were some user-customizable variables that were
\r
133 moved to notmuch-lib and renamed. If that is correct, it would not hurt
\r
134 to document these changes.
\r
136 > > Thank you for this work, it is much appreciated.
\r
138 > Thanks for taking the time to review these patches! I think as a
\r
139 > result of everyone's reviews I've pushed the series toward what I
\r
140 > envisioned/wanted in the first place, rather than the kinda kludgey
\r
141 > thing I did initially.
\r
144 No need to thank me for review, I did not do it :)
\r
146 > Amusingly, I've started a new job since I wrote the original patch and
\r
147 > no longer receive much HTML-only email, but I like this patch series
\r
148 > enough to see it through anyway :-).
\r
150 Congratulations with the new job :)
\r