1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C97BA429E39
\r
6 for <notmuch@notmuchmail.org>; Mon, 2 Jan 2012 05:15:06 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id yw+NPM3fTIij for <notmuch@notmuchmail.org>;
\r
16 Mon, 2 Jan 2012 05:15:06 -0800 (PST)
\r
17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 1CA86431FD0
\r
21 for <notmuch@notmuchmail.org>; Mon, 2 Jan 2012 05:15:05 -0800 (PST)
\r
22 Received: from pps.filterd (mail-gw3 [127.0.0.1])
\r
23 by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q02DF3hV005358;
\r
24 Mon, 2 Jan 2012 15:15:03 +0200
\r
25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
26 by mail-gw3.nixu.fi with ESMTP id 114cs0wwtv-1
\r
27 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
28 Mon, 02 Jan 2012 15:15:02 +0200
\r
29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
30 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
31 q02DF1CV002155; Mon, 2 Jan 2012 15:15:01 +0200
\r
32 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
33 To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 2/2] python: make the result of Message.get_replies() more
\r
37 <1324473302-10869-3-git-send-email-4winter@informatik.uni-hamburg.de>
\r
38 References: <87sjm79e3d.fsf@SSpaeth.de>
\r
39 <1324473302-10869-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
40 <1324473302-10869-3-git-send-email-4winter@informatik.uni-hamburg.de>
\r
41 User-Agent: Notmuch/0.10.2+157~g442d405 (http://notmuchmail.org) Emacs/23.3.1
\r
43 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
44 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
45 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
46 Date: Mon, 02 Jan 2012 15:15:01 +0200
\r
47 Message-ID: <yf6ipkuz1nu.fsf@taco2.nixu.fi>
\r
49 Content-Type: text/plain; charset=us-ascii
\r
50 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
\r
51 1.0.211, 0.0.0000 definitions=2012-01-02_03:2012-01-02, 2012-01-02,
\r
52 1970-01-01 signatures=0
\r
53 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
\r
54 ipscore=0 suspectscore=0
\r
55 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
\r
57 scancount=1 engine=6.0.2-1012030000 definitions=main-1201020085
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Mon, 02 Jan 2012 13:15:07 -0000
\r
72 On Wed, 21 Dec 2011 14:15:02 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
\r
73 > Formerly Message.get_replies() returned an iterator or None forcing
\r
74 > users to check the result before iterating over it leading to strange
\r
75 > looking code at the call site.
\r
77 > Fix this flaw by adding an EmptyMessagesResult class that behaves like
\r
78 > the Messages class but immediatly raises StopIteration if used as an
\r
79 > iterator and returning objects of this type from Message.get_replies()
\r
80 > to indicate that there are no replies.
\r
82 > bindings/python/notmuch/message.py | 22 +++++++++++++++-------
\r
83 > 1 files changed, 15 insertions(+), 7 deletions(-)
\r
85 LGTM, but does this break any current software using this API ?
\r