c0/c445604fce912430c959765f1127c6171d356c

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id DC82C431FD0\r
   6         for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:29:14 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id 97q9FPo2PChx for <notmuch@notmuchmail.org>;\r
  16         Tue, 27 Dec 2011 19:29:12 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
  18         [18.9.25.14])\r
  19         by olra.theworths.org (Postfix) with ESMTP id B5A1C431FB6\r
  20         for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:29:12 -0800 (PST)\r
  21 X-AuditID: 1209190e-b7f7c6d0000008c3-d0-4efa8d0809bc\r
  22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
  23         by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 87.24.02243.80D8AFE4; Tue, 27 Dec 2011 22:29:12 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id pBS3TBDS027702; \r
  27         Tue, 27 Dec 2011 22:29:12 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBS3T8Wr009667\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Tue, 27 Dec 2011 22:29:11 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RfkDF-0001Qb-Iy; Tue, 27 Dec 2011 22:29:57 -0500\r
  37 Date: Tue, 27 Dec 2011 22:29:57 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: David Edmondson <dme@dme.org>\r
  40 Subject: Re: [PATCH] emacs: Don't attempt to colour tags in\r
  41         `notmuch-show-mode'.\r
  42 Message-ID: <20111228032957.GB30150@mit.edu>\r
  43 References: <1325004434-24583-1-git-send-email-dme@dme.org>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain; charset=us-ascii\r
  46 Content-Disposition: inline\r
  47 In-Reply-To: <1325004434-24583-1-git-send-email-dme@dme.org>\r
  48 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  49 X-Brightmail-Tracker:\r
  50  H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT0eXo/eVn0L9a3GLfnS1MFtdvzmR2\r
  51         YPLY9fwvk8ezVbeYA5iiuGxSUnMyy1KL9O0SuDK2LvjHUtDOXfH12T2mBsbjHF2MHBwSAiYS\r
  52         x7/odzFyApliEhfurWfrYuTiEBLYxyhxvqWHHcLZwCjx8eNCqMxJJomrS7YwQThLGCUaj59n\r
  53         B+lnEVCVOHf4JjOIzSagIbFt/3JGEFtEQFHi/7cVYDXMAtIS3343M4HYwgJBEuunXgGzeQV0\r
  54         JK6t7gOzhQSsJaZ9XsMGEReUODnzCQtEr5bEjX8vmUDOBpmz/B8HSJhTwEZi88uvYK2iAioS\r
  55         U05uY5vAKDQLSfcsJN2zELoXMDKvYpRNya3SzU3MzClOTdYtTk7My0st0jXWy80s0UtNKd3E\r
  56         CAprTkm+HYxfDyodYhTgYFTi4b319qefEGtiWXFl7iFGSQ4mJVFer65ffkJ8SfkplRmJxRnx\r
  57         RaU5qcWHGCU4mJVEeC0fAJXzpiRWVqUW5cOkpDlYlMR51bTe+QkJpCeWpGanphakFsFkZTg4\r
  58         lCR4DXuAhgoWpaanVqRl5pQgpJk4OEGG8wAN9wWp4S0uSMwtzkyHyJ9iVJQS52UBSQiAJDJK\r
  59         8+B6YWnnFaM40CvCvHogVTzAlAXX/QpoMBPQ4DjlHyCDSxIRUlINjFzZITlZhw5/E7XyOHpy\r
  60         ec4L//dWyk/97OewWd+frvr2F8MP+/nMmtOVnCyjNKY3v9jJXBy2pUur4ZVQddKsDzsDtjMY\r
  61         WtcyNp6t9/rns8xphebrxmPzv7msm7N4mgRnovWslR9Pfm1LvdO+w3HphXXbJs97uO+HhMUN\r
  62         A0vWwOKbM6e4XC+XPqfEUpyRaKjFXFScCAC4kDIeFgMAAA==\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Wed, 28 Dec 2011 03:29:15 -0000\r
  77 \r
  78 LGTM.\r
  79 \r
  80 Quoth David Edmondson on Dec 27 at  4:47 pm:\r
  81 > The tags were coloured using text properties. Unfortunately that text\r
  82 > (the header line) also has an overlay, which overrides the text\r
  83 > properties. There's not point in applying text properties that will\r
  84 > never be seen.\r
  85 > ---\r
  86 >  emacs/notmuch-show.el |    8 ++------\r
  87 >  1 files changed, 2 insertions(+), 6 deletions(-)\r
  88 > \r
  89 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
  90 > index 8c9d846..24f0b40 100644\r
  91 > --- a/emacs/notmuch-show.el\r
  92 > +++ b/emacs/notmuch-show.el\r
  93 > @@ -221,10 +221,7 @@ indentation."\r
  94 >      (goto-char (notmuch-show-message-top))\r
  95 >      (if (re-search-forward "(\\([^()]*\\))$" (line-end-position) t)\r
  96 >       (let ((inhibit-read-only t))\r
  97 > -       (replace-match (concat "("\r
  98 > -                              (propertize (mapconcat 'identity tags " ")\r
  99 > -                                          'face 'notmuch-tag-face)\r
 100 > -                              ")"))))))\r
 101 > +       (replace-match (concat "(" (mapconcat 'identity tags " ") ")"))))))\r
 102 >  \r
 103 >  (defun notmuch-show-clean-address (address)\r
 104 >    "Try to clean a single email ADDRESS for display.  Return\r
 105 > @@ -278,8 +275,7 @@ message at DEPTH in the current thread."\r
 106 >           " ("\r
 107 >           date\r
 108 >           ") ("\r
 109 > -         (propertize (mapconcat 'identity tags " ")\r
 110 > -                     'face 'notmuch-tag-face)\r
 111 > +         (mapconcat 'identity tags " ")\r
 112 >           ")\n")\r
 113 >      (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face)))\r
 114 >  \r