1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7E1CA429E49
\r
6 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 14:55:48 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id Ce2ORFEyS5gc for <notmuch@notmuchmail.org>;
\r
17 Sun, 29 Jan 2012 14:55:48 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id BCA1F431E64
\r
22 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 14:55:47 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so864948bke.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 14:55:43 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=oSGkgX0ZZFqN78HpgiDOmXBegxIko5DOVA40Fdfzdk4=;
\r
29 b=kbfZRMD68rEBnpS4Yt3boc9jFyoOYjaI07TLysjApuCZSHWqpVMsEKwsd8VZ9U9SIx
\r
30 J8QtJ7W0h0kizIzFZ+bQoaPbD5/sswdBfMec3QpnjLKZ8wpR6yYS7kz5YTnWNIpyxk/a
\r
31 8PMl6WtpHPAxT7LGhgNe6hn80EaNs7XYEZXx8=
\r
32 Received: by 10.204.156.5 with SMTP id u5mr7574879bkw.84.1327877743660;
\r
33 Sun, 29 Jan 2012 14:55:43 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id ev5sm33296240bkb.4.2012.01.29.14.55.41
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sun, 29 Jan 2012 14:55:42 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Austin Clements <amdragon@MIT.EDU>
\r
40 Subject: Re: [PATCH 1/6] emacs: move tag format validation to `notmuch-tag'
\r
42 In-Reply-To: <20120129213427.GF17991@mit.edu>
\r
43 References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <20120129213427.GF17991@mit.edu>
\r
45 User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Mon, 30 Jan 2012 02:54:32 +0400
\r
48 Message-ID: <87fwey86hj.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 Cc: notmuch@notmuchmail.org
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Sun, 29 Jan 2012 22:55:48 -0000
\r
68 On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
69 > One philosophical nit below, but not enough to hold this up.
\r
71 > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
\r
72 > > Before the change, tag format validation was done in
\r
73 > > `notmuch-search-operate-all' function only. The patch moves it down
\r
74 > > to `notmuch-tag', so that all users of that function get input
\r
77 > > emacs/notmuch.el | 12 ++++++------
\r
78 > > 1 files changed, 6 insertions(+), 6 deletions(-)
\r
80 > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
81 > > index 72f78ed..84d7d0a 100644
\r
82 > > --- a/emacs/notmuch.el
\r
83 > > +++ b/emacs/notmuch.el
\r
84 > > @@ -522,6 +522,12 @@ Note: Other code should always use this function alter tags of
\r
85 > > messages instead of running (notmuch-call-notmuch-process \"tag\" ..)
\r
86 > > directly, so that hooks specified in notmuch-before-tag-hook and
\r
87 > > notmuch-after-tag-hook will be run."
\r
88 > > + ;; Perform some validation
\r
89 > > + (when (null tags) (error "No tags given"))
\r
91 > Since this is a non-interactive function and hence is meant to be
\r
92 > invoked programmatically, I would expect it to accept zero tags.
\r
93 > Unlike the following check, this is a UI-level check and thus, I
\r
94 > believe, belongs in interactive functions (even if that requires a
\r
95 > little duplication).
\r
98 Agreed. Though I would hate to add the same check to each tag
\r
99 operation. Perhaps this check can go to
\r
100 `notmuch-select-tags-with-completion'?
\r
102 This is not the main patch in the series. So I think I would prefer not
\r
103 to make v2 because of this issue. If we come up with a good (i.e. no
\r
104 duplication) solution, I will prepare a separate patch for it.
\r
109 > > + (mapc (lambda (tag)
\r
110 > > + (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag)
\r
111 > > + (error "Tag must be of the form `+this_tag' or `-that_tag'")))
\r
113 > > (run-hooks 'notmuch-before-tag-hook)
\r
114 > > (apply 'notmuch-call-notmuch-process
\r
115 > > (append (list "tag") tags (list "--" query)))
\r
116 > > @@ -890,12 +896,6 @@ characters as well as `_.+-'.
\r
117 > > (interactive (notmuch-select-tags-with-completion
\r
118 > > "Operations (+add -drop): notmuch tag "
\r
120 > > - ;; Perform some validation
\r
121 > > - (when (null actions) (error "No operations given"))
\r
122 > > - (mapc (lambda (action)
\r
123 > > - (unless (string-match-p "^[-+][-+_.[:word:]]+$" action)
\r
124 > > - (error "Action must be of the form `+this_tag' or `-that_tag'")))
\r
126 > > (apply 'notmuch-tag notmuch-search-query-string actions))
\r
128 > > (defun notmuch-search-buffer-title (query)
\r