1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 39137431FC0
\r
6 for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 14:00:26 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id V-TwCPDis0Ci for <notmuch@notmuchmail.org>;
\r
16 Tue, 30 Jul 2013 14:00:17 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id A0D96431FBF
\r
19 for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 14:00:17 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 38D70100033;
\r
22 Wed, 31 Jul 2013 00:00:08 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] emacs: bugfix attachment content-type as mime-type
\r
27 In-Reply-To: <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>
\r
28 References: <87li4om623.fsf@qmul.ac.uk>
\r
29 <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>
\r
30 User-Agent: Notmuch/0.15.2+225~g6062adf (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Wed, 31 Jul 2013 00:00:07 +0300
\r
36 Message-ID: <m2txjbepbc.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Tue, 30 Jul 2013 21:00:26 -0000
\r
53 On Tue, Jul 30 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
55 > Notmuch puts attachments in as declared content-type except when the
\r
56 > content-type is application/octet-stream it tries to guess the type
\r
57 > from the filename/extension. This means that viewing a pdf (for
\r
58 > example) which is sent as application/octet-strem invokes the pdf
\r
59 > viewer rather than just offering to save the part.
\r
61 > Recent changes to the attachment handling (commit 1546387d) changed
\r
62 > (broke) this. This patch stores the calculated mime-type with the part
\r
63 > and changes the attachment part handlers can use it instead.
\r
65 > This seems to fix the bug for me. I am not sure I like the naming
\r
66 > (mime-type/content-type). Maybe it would be better to be explicit with
\r
67 > something like calculated-content-type but probably that should be a
\r
68 > more wholesale renaming.
\r
70 I tested this (before and after applying the patch), using notmuch
\r
71 remotely and viewing id:87ppu0t7yf.fsf@qmul.ac.uk .
\r
72 Before applying emacs promted me an output file, after applying xdg-open
\r
73 was executed - which executed evince to show the pdf document in that email.
\r
75 If this restores the behaviour that was experienced with notmuch 0.15(.2)
\r
76 then this imho is a good fix to be applied quickly before 0.16 is released...
\r