bf/8775ddbcf7cad95065e65f4f129551709c19aa

   1 Return-Path: <dme@dme.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 4FF98431FBF\r
   6         for <notmuch@notmuchmail.org>; Fri, 28 Nov 2014 23:53:49 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.699\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001]\r
  13         autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id PlTk86p7-tFH for <notmuch@notmuchmail.org>;\r
  17         Fri, 28 Nov 2014 23:53:36 -0800 (PST)\r
  18 Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com\r
  19         [209.85.212.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 6824D431FAE\r
  22         for <notmuch@notmuchmail.org>; Fri, 28 Nov 2014 23:53:34 -0800 (PST)\r
  23 Received: by mail-wi0-f173.google.com with SMTP id r20so20282508wiv.0\r
  24         for <notmuch@notmuchmail.org>; Fri, 28 Nov 2014 23:53:33 -0800 (PST)\r
  25 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  26         d=1e100.net; s=20130820;\r
  27         h=x-gm-message-state:to:subject:in-reply-to:references:user-agent\r
  28         :from:date:message-id:mime-version:content-type;\r
  29         bh=aHyD7ci8CJVuqQ/P36yGz1Vxkw8jXKN95bFUX4rEGBs=;\r
  30         b=ZKTeyKt9J4tFs75bIBHsDoHqADXHB9n51KU5sRlzugQC24pxcoAIS8DBacRyZDkLcF\r
  31         Tluz5wHNz1aw1zulfDuNAv7H2uO6FcGQ8fpnzdbL5i5GWQMoXqkWPMC+FparWkE20w4s\r
  32         YaScjIBg9BO4sghBjQMIORrcIc76OulAQVMzK/SvFdlp5YZEjEcG1HE+KLcO6p+wRi4H\r
  33         Ew8vF8N1e6kAofv7aGYQnBRoxoveOmycbR2CIIZ92olyCKAjj2L/WYhbY1+X5F80Jed4\r
  34         s56ePRXsMcknhinRAcEPVfZoYt9bj8WP6ytvCUt1mINzZnQr1r1nOWSIH3ZrxPPTuCU6\r
  35         +rqw==\r
  36 X-Gm-Message-State:\r
  37  ALoCoQl6d4/1Qkfb5BoI6lHht37VDi/d5Nj0ebNN5TZ58xd2Z1APnDmuSwACQCAKXhqvkCzGWyW9\r
  38 X-Received: by 10.194.248.195 with SMTP id yo3mr30029629wjc.60.1417247613126; \r
  39         Fri, 28 Nov 2014 23:53:33 -0800 (PST)\r
  40 Received: from disaster-area.hh.sledj.net\r
  41         ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])\r
  42         by mx.google.com with ESMTPSA id j2sm18052059wjs.28.2014.11.28.23.53.31\r
  43         for <multiple recipients>\r
  44         (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  45         Fri, 28 Nov 2014 23:53:32 -0800 (PST)\r
  46 Received: from localhost (30000@localhost [local]);\r
  47         by localhost (OpenSMTPD) with ESMTPA id 9ab8c14c;\r
  48         Sat, 29 Nov 2014 07:53:30 +0000 (UTC)\r
  49 To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org\r
  50 Subject: Re: [PATCH] emacs: Added "is:<tag>" style completion\r
  51         to      notmuch-read-query.\r
  52 In-Reply-To: <1417219835-92141-1-git-send-email-cceleri@cs.stanford.edu>\r
  53 References: <1417219835-92141-1-git-send-email-cceleri@cs.stanford.edu>\r
  54 User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\r
  55         (x86_64-pc-linux-gnu)\r
  56 From: David Edmondson <dme@dme.org>\r
  57 Date: Sat, 29 Nov 2014 07:53:30 +0000\r
  58 Message-ID: <cunk32efnnp.fsf@gargravarr.hh.sledj.net>\r
  59 MIME-Version: 1.0\r
  60 Content-Type: text/plain\r
  61 X-BeenThere: notmuch@notmuchmail.org\r
  62 X-Mailman-Version: 2.1.13\r
  63 Precedence: list\r
  64 List-Id: "Use and development of the notmuch mail system."\r
  65         <notmuch.notmuchmail.org>\r
  66 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  67         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  68 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  69 List-Post: <mailto:notmuch@notmuchmail.org>\r
  70 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  71 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  73 X-List-Received-Date: Sat, 29 Nov 2014 07:53:49 -0000\r
  74 \r
  75 On Sat, Nov 29 2014, Charles Celerier wrote:\r
  76 > The notmuch-search-terms man page states that "tag:<tag>" is equivalent\r
  77 > to "is:<tag>". Completion for "is:<tag>" style searches is now supported\r
  78 > in the Emacs interface.\r
  79 >\r
  80 > Signed-off-by: Charles Celerier <cceleri@cs.stanford.edu>\r
  81 > ---\r
  82 >  emacs/notmuch.el | 8 +++++---\r
  83 >  1 file changed, 5 insertions(+), 3 deletions(-)\r
  84 >\r
  85 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
  86 > index 218486a..e4b77c7 100644\r
  87 > --- a/emacs/notmuch.el\r
  88 > +++ b/emacs/notmuch.el\r
  89 > @@ -855,13 +855,15 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."\r
  90 >    "Read a notmuch-query from the minibuffer with completion.\r
  91 >  \r
  92 >  PROMPT is the string to prompt with."\r
  93 > +  (setq all-tags\r
  94 > +        (mapcar (lambda (tag) (notmuch-escape-boolean-term tag))\r
  95 > +                (process-lines notmuch-command "search"\r
  96 >                  "--output=tags" "*")))\r
  97 \r
  98 Should use a `let' binding rather than `setq'. Otherwise, looks good.\r
  99 \r
 100 >    (lexical-let\r
 101 >        ((completions\r
 102 >       (append (list "folder:" "path:" "thread:" "id:" "date:" "from:" "to:"\r
 103 >                     "subject:" "attachment:")\r
 104 > -             (mapcar (lambda (tag)\r
 105 > -                       (concat "tag:" (notmuch-escape-boolean-term tag)))\r
 106 > -                     (process-lines notmuch-command "search" "--output=tags" "*")))))\r
 107 > +             (mapcar (lambda (tag) (concat "tag:" tag)) all-tags)\r
 108 > +             (mapcar (lambda (tag) (concat "is:" tag)) all-tags))))\r
 109 >      (let ((keymap (copy-keymap minibuffer-local-map))\r
 110 >         (current-query (case major-mode\r
 111 >                          (notmuch-search-mode (notmuch-search-get-query))\r
 112 > -- \r
 113 > 2.1.2\r
 114 >\r
 115 > _______________________________________________\r
 116 > notmuch mailing list\r
 117 > notmuch@notmuchmail.org\r
 118 > http://notmuchmail.org/mailman/listinfo/notmuch\r