1 Return-Path: <bart@oxygen.jukie.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E8D25431FC0
\r
6 for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 18:21:56 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id LERX+1WsTl+u for <notmuch@notmuchmail.org>;
\r
11 Fri, 27 Nov 2009 18:21:56 -0800 (PST)
\r
12 Received: from tau.jukie.net (tau.jukie.net [216.239.93.128])
\r
13 by olra.theworths.org (Postfix) with ESMTP id C34B3431FBC
\r
14 for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 18:21:55 -0800 (PST)
\r
15 Received: from oxygen.jukie.net (oxygen.jukie.net [10.10.10.8])
\r
16 by tau.jukie.net (Postfix) with ESMTP id 34995C008F5;
\r
17 Fri, 27 Nov 2009 21:21:55 -0500 (EST)
\r
18 Received: by oxygen.jukie.net (Postfix, from userid 1000)
\r
19 id 662B62053465E; Fri, 27 Nov 2009 21:21:15 -0500 (EST)
\r
20 To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
\r
21 References: <1259124875-28212-1-git-send-email-bart@jukie.net>
\r
22 <1259124875-28212-2-git-send-email-bart@jukie.net>
\r
23 <1259124875-28212-3-git-send-email-bart@jukie.net>
\r
24 <87iqcvbgaw.fsf@yoom.home.cworth.org>
\r
25 From: Bart Trojanowski <bart@jukie.net>
\r
26 In-Reply-To: <87iqcvbgaw.fsf@yoom.home.cworth.org>
\r
27 Message-Id: <20091128022115.662B62053465E@oxygen.jukie.net>
\r
28 Date: Fri, 27 Nov 2009 21:21:15 -0500 (EST)
\r
29 Subject: Re: [notmuch] [PATCH 2/3] have _notmuch_thread_create mark which
\r
30 messages matched the query
\r
31 X-BeenThere: notmuch@notmuchmail.org
\r
32 X-Mailman-Version: 2.1.12
\r
34 List-Id: "Use and development of the notmuch mail system."
\r
35 <notmuch.notmuchmail.org>
\r
36 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
37 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
38 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
39 List-Post: <mailto:notmuch@notmuchmail.org>
\r
40 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
41 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
43 X-List-Received-Date: Sat, 28 Nov 2009 02:21:57 -0000
\r
45 On Fri, 27 Nov 2009 17:15:35 -0800, Carl Worth <cworth@cworth.org> wrote:
\r
46 > This is a very useful feature, Bart. Thanks for coding it up. And it's a
\r
47 > nicely-implemented patch series as well.
\r
49 Thanks. I've found it very handy.
\r
51 > By the way, do you think that this support obviates the
\r
52 > --only-matching-messages option for "notmuch search" or does anyone
\r
55 I personally don't have much use for it (in the notmuch.vim UI). However, I
\r
56 can see it being useful if someone reads the messages on the terminal, maybe
\r
57 using some less verbose output format.
\r
59 > Or maybe the right fix is to make "notmuch show" display only matching
\r
60 > messages by default, (which will likely be more friendly to a user
\r
61 > manually typing "notmuch show" at the command line). And then make the
\r
62 > user-interfaces pass an "--entire-thread" option (or so) to get the
\r
65 Sure, I'll fix up the patch and submit it in a bit.
\r
67 > If we're going to make the command-line user-interface usable on its
\r
68 > own, then I definitely want to make it be the user interfaces that have
\r
69 > to pass extra-long command-line options to get what they want.
\r
71 Agreed. I still think we could use some templating for the different output
\r
72 modes. Maybe it will be important enough for soemone to implement :)
\r
74 > One quick point on naming:
\r
76 > > /* Message flags */
\r
77 > > typedef enum _notmuch_message_flag {
\r
78 > > + NOTMUCH_MSG_FLAG_MATCHING_SEARCH,
\r
79 > > } notmuch_message_flag_t;
\r
81 > I like my enum values to match their type name without abbreviation. I
\r
82 > also like internals (like this enum value) to match the way they are
\r
83 > exposed in the interface, (which in this case is "match"). So I'd like
\r
84 > the above value to instead be:
\r
86 > NOTMUCH_MESSAGE_FLAG_MATCH
\r
88 OK. Patch is in flight.
\r
94 email sent from notmuch.vim plugin
\r