1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CBCA4431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 17 Aug 2012 11:55:06 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id CqPg6kmHNjK4 for <notmuch@notmuchmail.org>;
\r
16 Fri, 17 Aug 2012 11:55:06 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 28F0F431FAF
\r
20 for <notmuch@notmuchmail.org>; Fri, 17 Aug 2012 11:55:06 -0700 (PDT)
\r
21 X-AuditID: 1209190d-b7fd56d000000933-64-502e9387e696
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id FA.BC.02355.7839E205; Fri, 17 Aug 2012 14:55:03 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q7HIt2se013183;
\r
27 Fri, 17 Aug 2012 14:55:03 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q7HIt16J014141
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Fri, 17 Aug 2012 14:55:02 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1T2RhF-0007PJ-0x; Fri, 17 Aug 2012 14:55:01 -0400
\r
37 Date: Fri, 17 Aug 2012 14:55:00 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
40 Subject: Re: [PATCH 2/2] test: emacs: run list-processes after
\r
41 accept-process-output in emacs 23.1
\r
42 Message-ID: <20120817185500.GP11179@mit.edu>
\r
43 References: <1344165182-29246-1-git-send-email-tomi.ollila@iki.fi>
\r
44 <1344165182-29246-2-git-send-email-tomi.ollila@iki.fi>
\r
45 <20120813151613.GN11179@mit.edu>
\r
46 <m27gsz2se2.fsf@guru.guru-group.fi>
\r
48 Content-Type: text/plain; charset=us-ascii
\r
49 Content-Disposition: inline
\r
50 In-Reply-To: <m27gsz2se2.fsf@guru.guru-group.fi>
\r
51 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
52 X-Brightmail-Tracker:
\r
53 H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42IRYrdT122frBdg8P+qtcX1mzOZLd6snMfq
\r
54 wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGXcm3OSqaBPvGLvxo0sDYwzhboYOTkkBEwk
\r
55 1u5+yQJhi0lcuLeerYuRi0NIYB+jROuen0wQzgZGiQ2Ni9khnJNMEvtWnWKFcJYwSmy78Ays
\r
56 n0VAVeLc0b9gNpuAhsS2/csZQWwRARWJB23rWUFsZgFpiW+/m5lAbGGBFIn+9hlgcV4BHYn9
\r
57 fesYIYYeYZQ4cPsjI0RCUOLkzCcsEM1aEjf+vQRq5gAbtPwfB0iYU8BA4sChPWDlokC7ppzc
\r
58 xjaBUWgWku5ZSLpnIXQvYGRexSibklulm5uYmVOcmqxbnJyYl5dapGukl5tZopeaUrqJERTa
\r
59 nJK8OxjfHVQ6xCjAwajEwzvZRzdAiDWxrLgy9xCjJAeTkihvXodegBBfUn5KZUZicUZ8UWlO
\r
60 avEhRgkOZiURXieQHG9KYmVValE+TEqag0VJnPdKyk1/IYH0xJLU7NTUgtQimKwMB4eSBO/Z
\r
61 SUCNgkWp6akVaZk5JQhpJg5OkOE8QMNPgNTwFhck5hZnpkPkTzEqSonzrgdJCIAkMkrz4Hph
\r
62 qecVozjQK8K8S0GqeIBpC677FdBgJqDBK0V0QQaXJCKkpBoYzcW3dVxYnHTCU2xn8rKwhsCn
\r
63 /zdVhiUqNXYuUGAIyre/WZDeIXjI4vhC/e7GhZf/v025eUmluTxfiOfm/WPLVBui9LRqu8/G
\r
64 t4lN/ce0YuPBCRunRTXHT5/dVH87LmJu+1Ux//9l761zU48mWjBXdYfYGPRwFm6bxDKr+aPc
\r
65 sqXNrbql3MpKLMUZiYZazEXFiQBi0b0OGAMAAA==
\r
66 Cc: notmuch@notmuchmail.org
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.13
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Fri, 17 Aug 2012 18:55:06 -0000
\r
81 Quoth Tomi Ollila on Aug 16 at 10:44 am:
\r
82 > On Mon, Aug 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
84 > > Quoth Tomi Ollila on Aug 05 at 2:13 pm:
\r
85 > >> When running emacs tests using emacs 23.1.1 the tests block (until timeout)
\r
86 > >> when emacs function (notmuch-test-wait) is called.
\r
88 > >> There is an emacs bug #2930 titled:
\r
89 > >> 23.0.92; `accept-process-output' and `sleep-for' do not run sentinel
\r
91 > >> It seems this is present in emacs 23.1.
\r
93 > >> Calling list-processes after accept-process-output seems work around
\r
94 > >> this problem; in case Emacs version is 23.1 a defadvice is activated
\r
95 > >> to do just that.
\r
97 > > Should this workaround perhaps go in notmuch-test-wait directly,
\r
98 > > instead of being implemented as advice?
\r
100 > This way the fact that this is workaround for bug that exists only in
\r
101 > 23.1(*) is emphasized; The notmuch-test-wait can exist in a (simpler)
\r
102 > format where it doesn't need to know about this bug.
\r
106 > (*) This bug probably exists in emacs 22 but the MUA has not worked
\r
107 > on emacs 22 at least for a year now.
\r
109 > > If we do want to keep it as advice, should it go in notmuch-lib.el
\r
110 > > along with the few other compatibility functions?
\r
112 > In tests we have fixed environment where we can write workarounds
\r
113 > as "global" advices. If we did this in notmuch-lib.el we'd be changing
\r
114 > users' environment, possibly causing surprises...
\r
116 Oh, right, of course. I'd forgotten that this was in test-lib.el and
\r
117 not in the general notmuch Emacs code.
\r
119 > ... but neither sleep-for or accept-process-output are used in
\r
120 > any of the notmuch elisp code so such "fixes" are not needed now...
\r
122 > ... and this would ever be a problem, we might already support only
\r
123 > emacs 24 or newer >;) ...
\r
131 > >> Thanks to Austin for the comments and IRC discussions on the matter.
\r
133 > >> test/test-lib.el | 8 ++++++++
\r
134 > >> 1 files changed, 8 insertions(+), 0 deletions(-)
\r
136 > >> diff --git a/test/test-lib.el b/test/test-lib.el
\r
137 > >> index 52d9936..4330352 100644
\r
138 > >> --- a/test/test-lib.el
\r
139 > >> +++ b/test/test-lib.el
\r
140 > >> @@ -35,6 +35,16 @@
\r
141 > >> "Disable yes-or-no-p before executing kill-emacs"
\r
142 > >> (defun yes-or-no-p (prompt) t)))
\r
144 > >> +;; Emacs bug #2930:
\r
145 > >> +;; 23.0.92; `accept-process-output' and `sleep-for' do not run sentinels
\r
146 > >> +;; seems to be present in Emacs 23.1.
\r
147 > >> +;; Running `list-processes' after `accept-process-output' seems to work
\r
148 > >> +;; around this problem.
\r
149 > >> +(if (and (= emacs-major-version 23) (= emacs-minor-version 1))
\r
150 > >> + (defadvice accept-process-output (after run-list-processes activate)
\r
151 > >> + "run list-processes after executing accept-process-output"
\r
152 > >> + (list-processes)))
\r
154 > >> (defun notmuch-test-wait ()
\r
155 > >> "Wait for process completion."
\r
156 > >> (while (get-buffer-process (current-buffer))
\r