1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id A16E56DE0217
\r
6 for <notmuch@notmuchmail.org>; Sat, 7 May 2016 10:59:25 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.599 tagged_above=-999 required=5 tests=[AWL=-0.053,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id J0k4efExWTRK for <notmuch@notmuchmail.org>;
\r
16 Sat, 7 May 2016 10:59:17 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 3729D6DE00EB
\r
19 for <notmuch@notmuchmail.org>; Sat, 7 May 2016 10:59:17 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id DFA7E100063;
\r
22 Sat, 7 May 2016 20:59:15 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [Patch v3 10/11] lib: make a global constant for query parser
\r
27 In-Reply-To: <1462065879-29860-11-git-send-email-david@tethera.net>
\r
28 References: <1462065879-29860-1-git-send-email-david@tethera.net>
\r
29 <1462065879-29860-11-git-send-email-david@tethera.net>
\r
30 User-Agent: Notmuch/0.22+9~gb26b5ad (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sat, 07 May 2016 20:59:15 +0300
\r
36 Message-ID: <m2twi9eolo.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.20
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 07 May 2016 17:59:25 -0000
\r
53 On Sun, May 01 2016, David Bremner <david@tethera.net> wrote:
\r
55 > It's already kindof gross that this is hardcoded in two different
\r
56 > places. We will also need these later in field processors calling back
\r
57 > into the query parser.
\r
59 > lib/database-private.h | 4 ++++
\r
60 > lib/query.cc | 16 ++--------------
\r
61 > 2 files changed, 6 insertions(+), 14 deletions(-)
\r
63 > diff --git a/lib/database-private.h b/lib/database-private.h
\r
64 > index e1962f4..b5c1f90 100644
\r
65 > --- a/lib/database-private.h
\r
66 > +++ b/lib/database-private.h
\r
67 > @@ -144,6 +144,10 @@ operator&=(_notmuch_features &a, _notmuch_features b)
\r
71 > +#define NOTMUCH_QUERY_PARSER_FLAGS (Xapian::QueryParser::FLAG_BOOLEAN | Xapian::QueryParser::FLAG_PHRASE | \
\r
72 > + Xapian::QueryParser::FLAG_LOVEHATE | Xapian::QueryParser::FLAG_BOOLEAN_ANY_CASE | \
\r
73 > + Xapian::QueryParser::FLAG_WILDCARD | Xapian::QueryParser::FLAG_PURE_NOT)
\r
75 #define NOTMUCH_QUERY_PARSER_FLAGS (Xapian::QueryParser::FLAG_BOOLEAN | \
\r
76 Xapian::QueryParser::FLAG_PHRASE | \
\r
77 Xapian::QueryParser::FLAG_LOVEHATE | \
\r
78 Xapian::QueryParser::FLAG_BOOLEAN_ANY_CASE | \
\r
79 Xapian::QueryParser::FLAG_WILDCARD | \
\r
80 Xapian::QueryParser::FLAG_PURE_NOT)
\r
82 Instead, one line goes up to column 82, but..
\r
84 No other nits in this file.
\r
86 Some previous ones had more of spacing around = and
\r
87 opening brace in the same line as function definition.
\r
89 There were also more notmuch_options_sanitize () calls (I wonder how did
\r
90 your tests pass before you sent this series :O)
\r
92 The next one, id:1462065879-29860-12-git-send-email-david@tethera.net
\r
93 has inconsistent spacing:
\r
96 + $(dir)/query-fp.cc \
\r
100 Other than these I don't have more comments on the implementation (I may
\r
101 have not look deep enough, remembering all these nits disturbs me ;). I have
\r
102 not tested these (as CXXLAGS do not apply >;) and I will not run configure
\r
103 w/o set -u anymore :D)
\r