1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 150BC429E59
\r
6 for <notmuch@notmuchmail.org>; Sat, 1 Jun 2013 12:48:31 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id UZiVTC0QxCoi for <notmuch@notmuchmail.org>;
\r
16 Sat, 1 Jun 2013 12:48:23 -0700 (PDT)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 7DB2F431FDE
\r
21 for <notmuch@notmuchmail.org>; Sat, 1 Jun 2013 12:48:23 -0700 (PDT)
\r
22 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
23 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r51JmJ8V020719;
\r
24 Sat, 1 Jun 2013 16:48:19 -0300
\r
25 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
26 ([156.34.82.78] helo=zancas.localnet)
\r
27 by tesseract.cs.unb.ca with esmtpsa
\r
28 (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
\r
29 (envelope-from <david@tethera.net>)
\r
30 id 1Uirml-00077Q-GK; Sat, 01 Jun 2013 16:48:19 -0300
\r
31 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
32 (envelope-from <david@tethera.net>)
\r
33 id 1Uirmf-0001Xr-QG; Sat, 01 Jun 2013 16:48:13 -0300
\r
34 From: David Bremner <david@tethera.net>
\r
35 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
36 Subject: Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving)
\r
38 In-Reply-To: <1354970914-18342-3-git-send-email-markwalters1009@gmail.com>
\r
39 References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com>
\r
40 <1354970914-18342-3-git-send-email-markwalters1009@gmail.com>
\r
41 User-Agent: Notmuch/0.15.2+114~g3b2344e (http://notmuchmail.org) Emacs/24.3.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Sat, 01 Jun 2013 16:48:13 -0300
\r
44 Message-ID: <87zjv91uki.fsf@zancas.localnet>
\r
46 Content-Type: text/plain
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Sat, 01 Jun 2013 19:48:31 -0000
\r
62 Mark Walters <markwalters1009@gmail.com> writes:
\r
64 > Previously pick had no actions based on the entire thread: this adds
\r
65 > some. Note in this version '*' is bound to `tag thread' which is not
\r
66 > consistent with search or show. However it still might be the most
\r
67 > natural thing (as it is similar to running * in the show pane).
\r
69 Hmm. not sure about this. But since nobody complained in six months,
\r
70 let's go with it unless they wake up.
\r
72 > + (setq tag-changes (funcall 'notmuch-tag
\r
73 > (notmuch-pick-get-messages-ids-thread-search) tag-changes))
\r
75 Why "(funcall 'notmuch-tag ...) instead of a "(notmuch-tag ...)" here?
\r
76 Personally I'd use let instead of setq here, but ymmv.
\r
78 > +Archive each message currently shown by applying the tag changes
\r
79 > +in `notmuch-archive-tags' to each (remove the \"inbox\" tag by
\r
80 > +default). If a prefix argument is given, the messages will be
\r
81 > +\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'
\r
82 > +will be reversed.
\r
84 It seems to me the default value for notmuch-archive-tags should not be
\r
85 hard-coded into this docstring, especially since notmuch-archive-tags
\r
86 turns into a link in the help text.
\r