1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 64519431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 27 Jul 2014 09:24:37 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id QVy2XywitfgS for <notmuch@notmuchmail.org>;
\r
16 Sun, 27 Jul 2014 09:24:30 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id C5282431FAE
\r
22 for <notmuch@notmuchmail.org>; Sun, 27 Jul 2014 09:24:30 -0700 (PDT)
\r
23 X-AuditID: 1209190d-f79c06d000002f07-02-53d527beb812
\r
24 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
25 (using TLS with cipher AES256-SHA (256/256 bits))
\r
26 (Client did not present a certificate)
\r
27 by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP
\r
28 id 24.5A.12039.EB725D35; Sun, 27 Jul 2014 12:24:30 -0400 (EDT)
\r
29 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
30 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s6RGOSr6016595;
\r
31 Sun, 27 Jul 2014 12:24:29 -0400
\r
32 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
33 (authenticated bits=0)
\r
34 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
35 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s6RGORcp014954
\r
36 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
37 Sun, 27 Jul 2014 12:24:28 -0400
\r
38 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
39 (envelope-from <amdragon@mit.edu>)
\r
40 id 1XBRFK-00071D-NH; Sun, 27 Jul 2014 12:24:26 -0400
\r
41 Date: Sun, 27 Jul 2014 12:24:26 -0400
\r
42 From: Austin Clements <amdragon@MIT.EDU>
\r
43 To: Mark Walters <markwalters1009@gmail.com>
\r
44 Subject: Re: [PATCH 04/14] new: Don't report version after upgrade
\r
45 Message-ID: <20140727162426.GF13893@mit.edu>
\r
46 References: <1406433173-19169-1-git-send-email-amdragon@mit.edu>
\r
47 <1406433173-19169-5-git-send-email-amdragon@mit.edu>
\r
48 <87y4vfywmp.fsf@qmul.ac.uk>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 Content-Disposition: inline
\r
52 In-Reply-To: <87y4vfywmp.fsf@qmul.ac.uk>
\r
53 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
54 X-Brightmail-Tracker:
\r
55 H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hRV1t2nfjXYYP9jXovVc3ksrt+cyezA
\r
56 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZSw79oCp4LRkxf0NB5kaGJeLdDFyckgImEhs
\r
57 /b2ZHcIWk7hwbz1bFyMXh5DAbCaJFZPXsUA4Gxkl1lz/A+WcZpKYvXUdWIuQwBJGiS9PM0Fs
\r
58 FgFVid2/m1lAbDYBDYlt+5czgtgiAjoStw8tAKtnFpCW+Pa7mQnEFhZwktg9fRVQnIODF6jm
\r
59 7vQoiPlTGSWmbn7HBlLDKyAocXLmExaIXi2JG/9eMoHUg8xZ/o8DJMwJtGr3+rVgJaICKhJT
\r
60 Tm5jm8AoNAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3SNdLLzSzRS00p3cQI
\r
61 DmpJ3h2M7w4qHWIU4GBU4uHNYLsSLMSaWFZcmXuIUZKDSUmUt0v1arAQX1J+SmVGYnFGfFFp
\r
62 TmrxIUYJDmYlEd7Ct0DlvCmJlVWpRfkwKWkOFiVx3rfWVsFCAumJJanZqakFqUUwWRkODiUJ
\r
63 3vNqQEMFi1LTUyvSMnNKENJMHJwgw3mAhs8AWcxbXJCYW5yZDpE/xagoJc7bAdIsAJLIKM2D
\r
64 64UlnVeM4kCvCPOGglTxABMWXPcroMFMQINZ/C+DDC5JREhJNTB2NlQbPNi5OdJzrUhW4zwR
\r
65 sxNlfHME2Na8XHR6Z9YboTVL4mrcGH+Ft7Jx/ZXeyrr9x5ENKbwL/z6bPTW3N2mGiraZiVuE
\r
66 4ZK4u+kbN13veiiWUBztxzNl0a9ih/CPGZEpL140BdfP0/3y3FaotJh7+1yFFutnJ12fq0af
\r
67 kzyWuTKs7ETf92AlluKMREMt5qLiRACxHkqzFQMAAA==
\r
68 Cc: notmuch@notmuchmail.org
\r
69 X-BeenThere: notmuch@notmuchmail.org
\r
70 X-Mailman-Version: 2.1.13
\r
72 List-Id: "Use and development of the notmuch mail system."
\r
73 <notmuch.notmuchmail.org>
\r
74 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
76 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
77 List-Post: <mailto:notmuch@notmuchmail.org>
\r
78 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
79 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
80 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
81 X-List-Received-Date: Sun, 27 Jul 2014 16:24:37 -0000
\r
83 Quoth Mark Walters on Jul 27 at 10:33 am:
\r
84 > On Sun, 27 Jul 2014, Austin Clements <amdragon@MIT.EDU> wrote:
\r
85 > > The version number has always been pretty meaningless to the user and
\r
86 > > it's about to become even more meaningless with the introduction of
\r
87 > > "features". Hopefully, the database will remain on version 3 for some
\r
88 > > time to come; however, the introduction of new features over time in
\r
89 > > version 3 will necessitate upgrades within version 3. It would be
\r
90 > > confusing if we always tell the user they've been "upgraded to version
\r
91 > > 3". If the user wants to know what's new, they should read the news.
\r
93 > Two thoughts on this:
\r
95 > first, we could print the names of the new features here to make it
\r
96 > easier for the user to find them in NEWS.
\r
98 Interesting. Transparency is good, though I worry that this would
\r
99 expose the user to internal implementation details (certainly some
\r
100 features will translate to user-visible features, but others will be
\r
101 entirely internal to the library).
\r
103 > Secondly, would it be worth having something like notmuch
\r
104 > --database-version or similar which prints the features? If I understand
\r
105 > the series then notmuch clients don't necessarily need to upgrade the
\r
106 > database unless they want the new features. This means that knowing what
\r
107 > version they are running might not tell us which features they have
\r
108 > enabled (which could make debugging difficult)
\r
110 Good idea, though I'd be inclined to do it in a follow-up series just
\r
111 so this series doesn't get even longer. It won't be a problem for
\r
112 now: this series doesn't touch our current policy of unconditionally
\r
113 upgrading on notmuch new (a policy I think we should keep, though
\r
114 that's a separate discussion) so the notmuch version should still tell
\r
115 us the database version/features.
\r
122 > > notmuch-new.c | 3 +--
\r
123 > > test/T530-upgrade.sh | 2 +-
\r
124 > > 2 files changed, 2 insertions(+), 3 deletions(-)
\r
126 > > diff --git a/notmuch-new.c b/notmuch-new.c
\r
127 > > index d269c7c..b7590a8 100644
\r
128 > > --- a/notmuch-new.c
\r
129 > > +++ b/notmuch-new.c
\r
130 > > @@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])
\r
131 > > add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,
\r
132 > > &add_files_state);
\r
133 > > if (add_files_state.verbosity >= VERBOSITY_NORMAL)
\r
134 > > - printf ("Your notmuch database has now been upgraded to database format version %u.\n",
\r
135 > > - notmuch_database_get_version (notmuch));
\r
136 > > + printf ("Your notmuch database has now been upgraded.\n");
\r
139 > > add_files_state.total_files = 0;
\r
140 > > diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh
\r
141 > > index 7d5d5aa..c4c4ac8 100755
\r
142 > > --- a/test/T530-upgrade.sh
\r
143 > > +++ b/test/T530-upgrade.sh
\r
144 > > @@ -33,7 +33,7 @@ test_expect_equal "$output" "\
\r
145 > > Welcome to a new version of notmuch! Your database will now be upgraded.
\r
146 > > This process is safe to interrupt.
\r
147 > > Backing up tags to FILENAME
\r
148 > > -Your notmuch database has now been upgraded to database format version 2.
\r
149 > > +Your notmuch database has now been upgraded.
\r
152 > > test_begin_subtest "tag backup matches pre-upgrade dump"
\r