bb/1d663fe460b05182e3c729e7dfebf61729e2ac

   1 Return-Path: <jani@nikula.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 7D00F431FD6\r
   6         for <notmuch@notmuchmail.org>; Thu, 15 Jan 2015 09:16:10 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 1.738\r
  10 X-Spam-Level: *\r
  11 X-Spam-Status: No, score=1.738 tagged_above=-999 required=5\r
  12         tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7]\r
  13         autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id tyOWUoktZpWF for <notmuch@notmuchmail.org>;\r
  17         Thu, 15 Jan 2015 09:16:07 -0800 (PST)\r
  18 Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com\r
  19         [209.85.212.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 1910B431FBC\r
  22         for <notmuch@notmuchmail.org>; Thu, 15 Jan 2015 09:16:07 -0800 (PST)\r
  23 Received: by mail-wi0-f176.google.com with SMTP id z2so10879169wiv.3\r
  24         for <notmuch@notmuchmail.org>; Thu, 15 Jan 2015 09:16:06 -0800 (PST)\r
  25 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  26         d=1e100.net; s=20130820;\r
  27         h=x-gm-message-state:from:to:subject:in-reply-to:references\r
  28         :user-agent:date:message-id:mime-version:content-type;\r
  29         bh=8oSH/4shRj56nAIqB4r7Mwz07uD1DCMO20eEPGkXvfo=;\r
  30         b=CRi5PhJHqkHyi1sGe4rtyBIERABM+ej/bqOeJWWPSYkDXp9Xvw77667jI8ky0LKh6x\r
  31         h4CZ6Ydjd+h0K5SnFxw9MDr6zY1O0PwaaSs/D4BkCWRQ1ywMxE/cUkytcWR9rwdmAWP7\r
  32         x60hiUDhUyxA05ononSNBVUrTz96woVvV+lkbW4Sm/yO1ZGUIQa2w7fhY/jrsOd36WeJ\r
  33         uj3HM3fV1dSe/bbgZvrX/BUQLqnfp1AKa27E6h8OEWvg0B8XdtpwneQWryYuT4wUrdLL\r
  34         6o3Q90Mx/AVx+evkYUYQNWoc6Kw6PUVev17NyOWbtEN4ADbXnYtx5RwkYcAnIj/mnksW\r
  35         IFfQ==\r
  36 X-Gm-Message-State:\r
  37  ALoCoQn2cYYFTK1uHhi9VLGRC4nAFMJUxhyLnY4LJpVnQgfXyYViPZS+Zct5h9Jtok9kEAdJSO6r\r
  38 X-Received: by 10.180.103.6 with SMTP id fs6mr28725130wib.11.1421342165836;\r
  39         Thu, 15 Jan 2015 09:16:05 -0800 (PST)\r
  40 Received: from localhost (mobile-internet-bcee14-89.dhcp.inet.fi.\r
  41         [188.238.20.89])\r
  42         by mx.google.com with ESMTPSA id pl1sm8230607wic.16.2015.01.15.09.16.04\r
  43         (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  44         Thu, 15 Jan 2015 09:16:05 -0800 (PST)\r
  45 From: Jani Nikula <jani@nikula.org>\r
  46 To: Todd <todd@electricoding.com>, notmuch@notmuchmail.org\r
  47 Subject: Re: [PATCH v2 3/5] Add indexing for the mimetype term\r
  48 In-Reply-To: <1421193628-2699-4-git-send-email-todd@electricoding.com>\r
  49 References: <1421193628-2699-1-git-send-email-todd@electricoding.com>\r
  50         <1421193628-2699-4-git-send-email-todd@electricoding.com>\r
  51 User-Agent: Notmuch/0.19+19~g9060a1f (http://notmuchmail.org) Emacs/24.4.1\r
  52         (x86_64-pc-linux-gnu)\r
  53 Date: Thu, 15 Jan 2015 19:16:17 +0200\r
  54 Message-ID: <877fwo9d7i.fsf@nikula.org>\r
  55 MIME-Version: 1.0\r
  56 Content-Type: text/plain\r
  57 X-BeenThere: notmuch@notmuchmail.org\r
  58 X-Mailman-Version: 2.1.13\r
  59 Precedence: list\r
  60 List-Id: "Use and development of the notmuch mail system."\r
  61         <notmuch.notmuchmail.org>\r
  62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  65 List-Post: <mailto:notmuch@notmuchmail.org>\r
  66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  69 X-List-Received-Date: Thu, 15 Jan 2015 17:16:10 -0000\r
  70 \r
  71 \r
  72 Please add a commit message.\r
  73 \r
  74 On Wed, 14 Jan 2015, Todd <todd@electricoding.com> wrote:\r
  75 > ---\r
  76 >  lib/database.cc | 1 +\r
  77 >  lib/index.cc    | 6 ++++++\r
  78 >  2 files changed, 7 insertions(+)\r
  79 >\r
  80 > diff --git a/lib/database.cc b/lib/database.cc\r
  81 > index 2de60f8..7c7a267 100644\r
  82 > --- a/lib/database.cc\r
  83 > +++ b/lib/database.cc\r
  84 > @@ -254,6 +254,7 @@ static prefix_t PROBABILISTIC_PREFIX[]= {\r
  85 >      { "from",                        "XFROM" },\r
  86 >      { "to",                  "XTO" },\r
  87 >      { "attachment",          "XATTACHMENT" },\r
  88 > +    { "mimetype",            "XMIMETYPE"},\r
  89 >      { "subject",             "XSUBJECT"},\r
  90 >  };\r
  91 >  \r
  92 > diff --git a/lib/index.cc b/lib/index.cc\r
  93 > index 1a2e63d..2e27558 100644\r
  94 > --- a/lib/index.cc\r
  95 > +++ b/lib/index.cc\r
  96 > @@ -318,6 +318,12 @@ _index_mime_part (notmuch_message_t *message,\r
  97 >       return;\r
  98 >      }\r
  99 >  \r
 100 > +\r
 101 \r
 102 Superfluous newline.\r
 103 \r
 104 > +    GMimeContentType*  content_type = g_mime_object_get_content_type(part);\r
 105 \r
 106 Please replace "*  " with " *".\r
 107 \r
 108 > +    if (content_type) {\r
 109 > +     _notmuch_message_gen_terms (message, "mimetype", g_mime_content_type_to_string(content_type));\r
 110 > +    }\r
 111 \r
 112 Check g_mime_content_type_to_string return value, and g_free the result\r
 113 afterwards.\r
 114 \r
 115 BR,\r
 116 Jani.\r
 117 \r
 118 > +\r
 119 >      if (GMIME_IS_MULTIPART (part)) {\r
 120 >       GMimeMultipart *multipart = GMIME_MULTIPART (part);\r
 121 >       int i;\r
 122 > -- \r
 123 > 1.9.1\r
 124 >\r
 125 > _______________________________________________\r
 126 > notmuch mailing list\r
 127 > notmuch@notmuchmail.org\r
 128 > http://notmuchmail.org/mailman/listinfo/notmuch\r