1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 17BC4429E27
\r
6 for <notmuch@notmuchmail.org>; Sun, 20 Nov 2011 10:36:02 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id M+RrE5pyCc6E for <notmuch@notmuchmail.org>;
\r
17 Sun, 20 Nov 2011 10:36:01 -0800 (PST)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 593C5431FD0
\r
22 for <notmuch@notmuchmail.org>; Sun, 20 Nov 2011 10:36:01 -0800 (PST)
\r
23 Received: by bkaq10 with SMTP id q10so6299106bka.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 20 Nov 2011 10:35:59 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=G8KPs7awpCSAGG4HEOdxZkgFx+L9fEc4mf2ubVN8SiE=;
\r
29 b=mE4/HY4mhO48A9mUUR9ToGutNJEeX391V94eRhKN/RPRPbzcqmhrU2kWcqBGvqC9P4
\r
30 1+jdZXV8j3I0eTgMlKzhexOy2dPwyorFbY+mghi54CAZtj5jSHTAC9Z5C9ggFZfcM8Z3
\r
31 GRfqgvqWdaSmvWK8/Z7aZeKMo4hrv0G6Agwl8=
\r
32 Received: by 10.205.118.132 with SMTP id fq4mr4131029bkc.126.1321814159895;
\r
33 Sun, 20 Nov 2011 10:35:59 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id z7sm5442345bka.1.2011.11.20.10.35.58
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sun, 20 Nov 2011 10:35:58 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH v2] Output unmodified Content-Type header value for JSON
\r
42 In-Reply-To: <87sjlktgi6.fsf@zancas.localnet>
\r
43 References: <1321659905-24367-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <1321676321-27745-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
45 <87sjlktgi6.fsf@zancas.localnet>
\r
46 User-Agent: Notmuch/0.10~rc1+20~gec94ced (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Sun, 20 Nov 2011 22:35:42 +0400
\r
49 Message-ID: <87obw6prpd.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Sun, 20 Nov 2011 18:36:02 -0000
\r
66 On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner <david@tethera.net> wrote:
\r
67 > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
68 > > Before the change, notmuch used g_mime_content_type_to_string(3)
\r
69 > > function to output Content-Type header value. Turns out it outputs
\r
70 > > only "type/subtype" part and ignores all parameters. Also, if there
\r
71 > > is no Content-Type header, default "text/plain" value is used.
\r
75 > I haven't analyzed the substance of your patch yet, but I did have a
\r
76 > couple thoughts while reading your mail.
\r
78 > - It seems that every time we change the json format, we have a round of
\r
79 > suffering because people are unable to detect a mismatch between their
\r
80 > emacs code and the cli. Not that this is your problem necessarily, but
\r
81 > it would be nice if someone (TM), would come up with some version info
\r
82 > for the json output, and a patch to check it on the emacs side.
\r
85 IMO this is a good idea.
\r
87 > - The previous point is a bit of a counterargument to this, but in
\r
88 > general, I think I prefer patches that modify the core seperate from
\r
89 > those that do emacs (or python, or ...) stuff.
\r
92 I couls separate it. I made is a single patch to avoid having a
\r
93 revision with broken emacs UI (and tests).
\r
98 > - I understand you want to make your patches reviewable without applying
\r
99 > by including lots of context, but at a certain point it has actually
\r
100 > the opposite effect for me. I just don't read 900+ line emails ;). Of
\r
101 > course, I can still apply the patch and look at it, so it's really up
\r