1 Return-Path: <schnouki@schnouki.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B226C431FD0
\r
6 for <notmuch@notmuchmail.org>; Wed, 9 Nov 2011 10:51:02 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id uhLNE7XGZ6yN for <notmuch@notmuchmail.org>;
\r
17 Wed, 9 Nov 2011 10:51:02 -0800 (PST)
\r
18 Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222])
\r
19 by olra.theworths.org (Postfix) with ESMTP id 03F3E431FB6
\r
20 for <notmuch@notmuchmail.org>; Wed, 9 Nov 2011 10:51:01 -0800 (PST)
\r
21 Received: from odin.local (4va54-1-87-88-247-156.dsl.sta.abo.bbox.fr
\r
23 by ks3536.kimsufi.com (Postfix) with ESMTPSA id A7FA36A0026;
\r
24 Wed, 9 Nov 2011 19:50:59 +0100 (CET)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net;
\r
26 s=key-schnouki; t=1320864659;
\r
27 bh=zNTWUuYd3mm5WkDD7NlPEHwBQpfNxtq1w2zaz+eIzm0=;
\r
28 h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
\r
29 MIME-Version:Content-Type;
\r
30 b=MPYMZQNzHN7cayKu8U51T8kWCSV+Tf6gc7WWB77fgllYnLMHJbEuZJV5nCpUD3Kfr
\r
31 dcbe3QuYCLQbgySZ2Qk7pDv6dB5VHhmKsItG5YwNpZsWvjXP29YcSB07VooqElyQ4W
\r
32 vq/mu/ew2RpblVFcws4e5MqofXEwNxpFcJS3r+1Q=
\r
33 From: Thomas Jost <schnouki@schnouki.net>
\r
34 To: Austin Clements <amdragon@mit.edu>
\r
35 Subject: Re: [PATCH] emacs: Let the user choose where to compose new mails
\r
37 <CAH-f9WvuSFJJC+e0JRFwKD8xYtyncNYZreCXxxMDeSahpWAuRw@mail.gmail.com>
\r
38 References: <87pqhlh64c.fsf@thor.loria.fr>
\r
39 <1319528464-22654-1-git-send-email-schnouki@schnouki.net>
\r
40 <CAH-f9WvuSFJJC+e0JRFwKD8xYtyncNYZreCXxxMDeSahpWAuRw@mail.gmail.com>
\r
41 User-Agent: Notmuch/0.9+66~g79e6e2e (http://notmuchmail.org) Emacs/24.0.90.1
\r
42 (x86_64-unknown-linux-gnu)
\r
43 Date: Wed, 09 Nov 2011 19:50:55 +0100
\r
44 Message-ID: <87ipmt8700.fsf@schnouki.net>
\r
46 Content-Type: multipart/signed; boundary="=-=-=";
\r
47 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
48 Cc: notmuch@notmuchmail.org
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Wed, 09 Nov 2011 18:51:02 -0000
\r
64 Content-Type: text/plain
\r
65 Content-Transfer-Encoding: quoted-printable
\r
67 On Fri, 4 Nov 2011 23:51:55 -0400, Austin Clements <amdragon@mit.edu> wrote:
\r
68 > This seems like a good option to have, but your approach seems
\r
69 > unnecessarily complicated. I'm always wary of defcustom's :set because
\r
70 > it means you can't just setq the variable, which defeats the
\r
71 > underlying beauty of the customize system.
\r
73 Actually I use it with setq without any problem. But yes, it's too
\r
76 > You could eliminate the other two variables and compute them on the
\r
77 > fly, or, if you really feel they may need to be controlled
\r
78 > independently, make the custom variable a pair or alist (which you can
\r
79 > hide behind a few const choices).
\r
81 Computing them on the fly is probably cleaner. But I'm not sure if the
\r
82 switch-function and dedicated flag must be independent or not. From what
\r
83 I've tested it's *much* more pleasant to use with the dedicated flag,
\r
84 but I don't know how other people feel about this...
\r
86 > Alternatively, it seems like the variable could instead
\r
87 > take a single function (basically what notmuch-mua-switch-function is
\r
88 > now) and you could provide two new functions that simply combine
\r
89 > switch-to-buffer-other-x and set-window-dedicated-p.
\r
91 I've tried that, but for some reason it doesn't work when forwarding a
\r
92 message: the dedicated flag is reset somewhere inside message-forward,
\r
93 but I don't know where nor why. (I haven't investigated much though.)
\r
95 > The defcustom would be more user-friendly if it gave a choice between
\r
96 > const values, rather than requiring the user to enter a symbol value
\r
97 > (and then possibly rejecting it on validation). Something like
\r
98 > :type '(choice (const :tag "Compose in the current window" current-wind=
\r
100 > (const :tag "Compose mail in a new window" new-window)
\r
101 > (const :tag "Compose mail in a new frame" new-frame))
\r
103 Yep, that's much better. I'll try to rewrite this patch using this and
\r
104 on-the-fly computations of the switch-function and dedicated flag.
\r
106 Thank you for the review!
\r
114 Content-Type: application/pgp-signature
\r
116 -----BEGIN PGP SIGNATURE-----
\r
117 Version: GnuPG v1.4.11 (GNU/Linux)
\r
119 iQEcBAEBAgAGBQJOusuPAAoJEMPdciX+bh5Ib1AH/0xzI3WK64F9CxZ/gucsFPgp
\r
120 hmIDbEIavRe2fxcv74PiTtRvA/QgQU490jp2zMo+EySlMulRNgoONMZYS+dd/6Fz
\r
121 1Uz3lzqtXLLvHQI/1FKQdQLo+VoBMtsP7IetYlO5pFzoQElrCTe6ST/CIgvqsqkW
\r
122 4Pg5BMon8ZjzNht2SLIizrUVCRFnB6VU0YrLfYDQt0Xigbok+3reUJoVLl8UNl1w
\r
123 m2Ug+eyx9DiGfE4zVackd27EQdRQgwLavw92eqmJYS06EhrP71CheTFEJy++3Vxo
\r
124 6ko8XzGWJsYPUDBQrDHzDQdRcMmCo15kJD+NQmG5/rRvmGScBiXHqsF+7XleZBU=
\r
126 -----END PGP SIGNATURE-----
\r