1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 914C4431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 2 Jan 2015 09:52:53 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 107YemJ5X4cX for <notmuch@notmuchmail.org>;
\r
16 Fri, 2 Jan 2015 09:52:50 -0800 (PST)
\r
17 Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com
\r
18 [74.125.82.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 221EC431FAE for <notmuch@notmuchmail.org>; Fri, 2 Jan 2015 09:52:50 -0800
\r
22 Received: by mail-wg0-f53.google.com with SMTP id x13so6647061wgg.12
\r
23 for <notmuch@notmuchmail.org>; Fri, 02 Jan 2015 09:52:49 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=yblz8LTxZGxCXv6C3KfPPK0L5CHPGBJbVsXKsgSJbCw=;
\r
29 b=KfD/tmddy/mnSbGaJvEQ4qu0EHql5XS2KKsqcX7G7OqWw/rS4zevdFoaYIWuMJidBW
\r
30 SfVRWnoBpy/Qqtk6R+XKSQMAnZz6O4NR/bKA/z3/x6WsDp9p6vwQdDtmn8a+CMMQuOCe
\r
31 TzEH7mWAIj//90xFsNpwk2dmrsQAqal2KUeqeQhtv9FdM2jzccJ/0Ie+MbcQSV6poQls
\r
32 BvchnCOggz5CgynriJJk/X8FfjE4qWzoWnraPVBc7Os0rrd7LZHQgKWgW9jn+LB+HDgx
\r
33 c8MF/IWFrFQcXxfC6c59TOyFWBrmN+IK5n7zHezWm6WiumpaEEWwHRT6YVlxOxwWG3+5
\r
36 ALoCoQmrdhH9VNIn1rKp4O4nBgyO3HCURTpCKMpQvYou4445YeF6y4m2wzcDd3YU8rYF/hlSCrgu
\r
37 X-Received: by 10.180.83.42 with SMTP id n10mr106979123wiy.54.1420221169007;
\r
38 Fri, 02 Jan 2015 09:52:49 -0800 (PST)
\r
39 Received: from localhost (mobile-internet-bceeb5-193.dhcp.inet.fi.
\r
41 by mx.google.com with ESMTPSA id s9sm54861597wiz.12.2015.01.02.09.52.47
\r
42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
43 Fri, 02 Jan 2015 09:52:48 -0800 (PST)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH] lib: convert two "iterator copy strings" into references.
\r
47 In-Reply-To: <1420215652-4131-1-git-send-email-david@tethera.net>
\r
48 References: <1419763508-11902-1-git-send-email-david@tethera.net>
\r
49 <1420215652-4131-1-git-send-email-david@tethera.net>
\r
50 User-Agent: Notmuch/0.19+6~gf2e3d2c (http://notmuchmail.org) Emacs/24.4.1
\r
51 (x86_64-pc-linux-gnu)
\r
52 Date: Fri, 02 Jan 2015 19:52:55 +0200
\r
53 Message-ID: <871tnd1348.fsf@nikula.org>
\r
55 Content-Type: text/plain
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Fri, 02 Jan 2015 17:52:53 -0000
\r
70 On Fri, 02 Jan 2015, David Bremner <david@tethera.net> wrote:
\r
71 > Apparently this is a supported and even idiomatic way of keeping a
\r
72 > temporary object (e.g. like that returned from an operator
\r
73 > dereference) alive.
\r
76 > I decided it was better to do both of these "keepalive" strings the
\r
77 > same way, so I applied the parent patch as is.
\r
82 > lib/message.cc | 4 ++--
\r
83 > 1 file changed, 2 insertions(+), 2 deletions(-)
\r
85 > diff --git a/lib/message.cc b/lib/message.cc
\r
86 > index bacb4d4..956a70a 100644
\r
87 > --- a/lib/message.cc
\r
88 > +++ b/lib/message.cc
\r
89 > @@ -283,7 +283,7 @@ _notmuch_message_get_term (notmuch_message_t *message,
\r
93 > - std::string term = *i;
\r
94 > + const std::string &term = *i;
\r
95 > if (strncmp (term.c_str(), prefix, prefix_len))
\r
98 > @@ -641,7 +641,7 @@ _notmuch_message_add_directory_terms (void *ctx, notmuch_message_t *message)
\r
99 > unsigned int directory_id;
\r
100 > const char *direntry, *directory;
\r
102 > - const std::string term = *i;
\r
103 > + const std::string &term = *i;
\r
105 > /* Terminate loop at first term without desired prefix. */
\r
106 > if (strncmp (term.c_str (), direntry_prefix, direntry_prefix_len))
\r
110 > _______________________________________________
\r
111 > notmuch mailing list
\r
112 > notmuch@notmuchmail.org
\r
113 > http://notmuchmail.org/mailman/listinfo/notmuch
\r