1 Return-Path: <daniel.schoepe@googlemail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D9F94431FD0
\r
6 for <notmuch@notmuchmail.org>; Tue, 5 Jul 2011 01:25:05 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id K4bgJrjeGjwS for <notmuch@notmuchmail.org>;
\r
17 Tue, 5 Jul 2011 01:25:05 -0700 (PDT)
\r
18 Received: from mail-fx0-f46.google.com (mail-fx0-f46.google.com
\r
19 [209.85.161.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id B6722431FB6
\r
22 for <notmuch@notmuchmail.org>; Tue, 5 Jul 2011 01:25:04 -0700 (PDT)
\r
23 Received: by fxh19 with SMTP id 19so5822435fxh.19
\r
24 for <notmuch@notmuchmail.org>; Tue, 05 Jul 2011 01:25:03 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
26 d=googlemail.com; s=gamma;
\r
27 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
28 :mime-version:content-type;
\r
29 bh=2l2lgg+WbGKsA/wUrk+/blbFMIHvFmaOiOMTBDr1UkM=;
\r
30 b=OSKaelQKIPPeBNz6akRkUf1pybBu/Ny68qrMNGpd7njEgi4S7YaDz25xDu9gqWqnpH
\r
31 d9zmDt/5EDHO0X3jB2pLHug57Z8sDXUPDyVoC5RhXlBBmd+HrBWzgKuVWrV8Jd6ICpIE
\r
32 kGWA+pjP7SLH2moeaa7aLF7xISM9s1hkNOkHI=
\r
33 Received: by 10.223.158.72 with SMTP id e8mr10726435fax.39.1309854303279;
\r
34 Tue, 05 Jul 2011 01:25:03 -0700 (PDT)
\r
35 Received: from localhost (s1132.dyn.hrz.tu-darmstadt.de [130.83.108.108])
\r
36 by mx.google.com with ESMTPS id o23sm5114048faa.9.2011.07.05.01.25.00
\r
37 (version=TLSv1/SSLv3 cipher=OTHER);
\r
38 Tue, 05 Jul 2011 01:25:01 -0700 (PDT)
\r
39 From: Daniel Schoepe <daniel.schoepe@googlemail.com>
\r
40 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH 0/2] emacs: User-defined sections in notmuch-hello
\r
42 In-Reply-To: <87wrfxk34u.fsf@steelpick.2x.cz>
\r
43 References: <1309379221-5617-1-git-send-email-daniel.schoepe@googlemail.com>
\r
44 <87wrfxk34u.fsf@steelpick.2x.cz>
\r
45 User-Agent: Notmuch/0.5-321-g0ef06a2 (http://notmuchmail.org) Emacs/23.3.1
\r
47 Date: Tue, 05 Jul 2011 10:24:53 +0200
\r
48 Message-ID: <87pqlpjfsa.fsf@tredergarh.home.box>
\r
50 Content-Type: multipart/signed; boundary="=-=-=";
\r
51 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Tue, 05 Jul 2011 08:25:06 -0000
\r
67 Content-Type: text/plain
\r
68 Content-Transfer-Encoding: quoted-printable
\r
70 On Tue, 05 Jul 2011 02:00:33 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrot=
\r
72 > First, the customization interface for the custom sections (not the
\r
73 > predefined ones) is very confusing. I was not able to use it at all.
\r
74 > Instead I hacked the source code (see below) to add my section to the
\r
75 > notmuch-hello-sections list.
\r
77 What specifically did you find confusing? The first customization-option
\r
78 is intended for sections like the all tags section which various
\r
79 configuration options which should be explained by the docstrings next
\r
80 to the options. The second item allows saved-searches-like sections.
\r
82 By the way: Instead of editing the source directly, you can also put all
\r
83 customizations like that in your configuration files and set
\r
84 notmuch-hello-sections from there. Nevertheless your inbox-display
\r
85 functions look useful in general so they should indeed be included.
\r
87 > Second, when I tried to understand your patch, I found some names of
\r
88 > functions and variables quite confusing. In the patch below, I tried to
\r
89 > give them a better names and I also updated the documentation. Feel free
\r
90 > to use my changes for your later patch submission.
\r
92 Thanks, those look quite a bit clearer, naming things like that is
\r
93 really not my strong suit. I'll include them in the next version of the
\r
97 > And last but not least, you allow quite wild modifications of tag
\r
98 > searches (e.g. in notmuch-hello-generate-tag-alist), but is might be
\r
99 > also useful to use such modifications for other searches. For example, I
\r
100 > want to modify the saved searches in a similar way.
\r
103 Are you referring to things like specifying a filter for each tag or
\r
104 count in saved-searches? My thinking was that since you specify each
\r
105 item manually anyway, you can append any filter you might want to use
\r
106 there. But I guess you're right that it's a bit more convenient to be
\r
107 able to specify those once and not having to repeat it for each item.
\r
109 > And here are my changes to your patch, which you might use as a
\r
110 > suggestions for a next version of your patch. As I wrote above, it
\r
111 > renames some functions and variables to more understandable names,
\r
112 > updates documentation and adds a custom section for my personal use (I
\r
113 > can live with this custom section in my .emacs if others do not like
\r
116 If we add the same configuration options that
\r
117 notmuch-hello-generate-tag-alist accepts, this section should be easy to
\r
118 specify in your ~/.emacs with one or two lines anyway.
\r
124 Content-Type: application/pgp-signature
\r
126 -----BEGIN PGP SIGNATURE-----
\r
127 Version: GnuPG v1.4.11 (GNU/Linux)
\r
129 iQIcBAEBAgAGBQJOEspVAAoJEIaTAtce+Z+JyfUQAIcQOA9FUWB90uOWBXwP970/
\r
130 Huh0w7NfjVIwP02vBjSt+Z0N4sylqpLCeBxF1YA7xvum5zLqvPZAaMSHE9rwhi0m
\r
131 F4wsb67FzGOTWo7c1zMv/DmheOvgQ669yc3juQWaldRebij5pRCjj8AUcpd2PEXj
\r
132 WYNYGamk3WVOTzs0gETC7UKtOmS8ORhkK67UBw80UhinUiT65xJv1TnHLZzfrJMQ
\r
133 YBheW4UqSNQsGllEzcGiei7pXffqBL0PYwKNCXHLTaiK3GK/7saaXc+d/G9V1lod
\r
134 acDMlzpuLPU7I5MgsHcKaZ1Tw2fZuH7/4GCNOPXZbDjTmDPzHiTMLFLvRqh/+SGz
\r
135 r0FnuDHr8D0QATM6dgkkfjwn411JMndLFOItxfGF86bpxN/YMJxCDB2l5ODwk5nH
\r
136 3mcWPnIKs16+UbHiVA6VYAhldZdsBiFghKWogbRc//derVEr4n4/E4gNkPBluzhr
\r
137 1Yd45gZNIADHd/Sjb40wF1BqgfKKpxkMDW/9Mn8EexClKAKldbeIRAiPdUH5sQDT
\r
138 TXPm2RZmzybb+6XjdYeHHzyxNCyoV6nBrmHmJsBnkM8F2h8W6g7W6gUIN9SQtxEu
\r
139 dA6N6uI4bqa9fkctF3PEBAR5n7z36LeCmQu1KtjbnGgRdpxOolszkh6n7Qxtx6rg
\r
140 Wj+mtwE4AJIph4g1qVkD
\r
142 -----END PGP SIGNATURE-----
\r