1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3E59C431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 17 Oct 2013 01:11:39 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.148 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_BL_SPAMCOP_NET=1.246,
\r
14 RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id W76O8k8t69f5 for <notmuch@notmuchmail.org>;
\r
18 Thu, 17 Oct 2013 01:11:35 -0700 (PDT)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 4990A431FAE
\r
23 for <notmuch@notmuchmail.org>; Thu, 17 Oct 2013 01:11:35 -0700 (PDT)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1VWig9-00015Q-A6; Thu, 17 Oct 2013 09:11:33 +0100
\r
28 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1VWig8-0002Nu-WD; Thu, 17 Oct 2013 09:11:33 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 3/6] cli: make the hacky from guessing more liberal
\r
36 <7dd03cd9c1677be8c5937d11b376d4cbd26c64f5.1381948853.git.jani@nikula.org>
\r
37 References: <cover.1381948853.git.jani@nikula.org>
\r
38 <7dd03cd9c1677be8c5937d11b376d4cbd26c64f5.1381948853.git.jani@nikula.org>
\r
39 User-Agent: Notmuch/0.15.2+334~gafd5c6a (http://notmuchmail.org) Emacs/23.4.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Thu, 17 Oct 2013 09:11:31 +0100
\r
42 Message-ID: <87li1sb9l8.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 93.97.24.31
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: 5ba659eccdfd841c24be8792a840488c (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: 0.0
\r
49 X-SpamAssassin-SpamBar: /
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored 0.0 points. Summary of the scoring:
\r
54 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
55 provider * (markwalters1009[at]gmail.com)
\r
56 * 0.0 AWL AWL: From: address is in the auto white-list
\r
57 X-QM-Scan-Virus: ClamAV says the message is clean
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Thu, 17 Oct 2013 08:11:39 -0000
\r
72 On Wed, 16 Oct 2013, Jani Nikula <jani@nikula.org> wrote:
\r
73 > This is in preparation of switching to gmime header parsing. Accept
\r
74 > "for" and "by" preceded by tabs in the received header. This is a bit
\r
75 > flaky, but so is the whole guessing code.
\r
77 I am happy with the change but I think a little more explanation of the
\r
78 problem it fixes would be helpful. Is it that there could be a \n \t
\r
79 before the "for"/"by" or something else?
\r
82 > notmuch-reply.c | 4 ++--
\r
83 > 1 file changed, 2 insertions(+), 2 deletions(-)
\r
85 > diff --git a/notmuch-reply.c b/notmuch-reply.c
\r
86 > index 9d6f843..4b67e66 100644
\r
87 > --- a/notmuch-reply.c
\r
88 > +++ b/notmuch-reply.c
\r
89 > @@ -423,7 +423,7 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message
\r
90 > /* First we look for a " for <email@add.res>" in the received
\r
93 > - ptr = strstr (received, " for ");
\r
94 > + ptr = strstr (received, "for ");
\r
96 The comment should be updated to match the code (and depending on the
\r
97 answer to the above maybe explain that too)
\r
103 > /* Note: ptr potentially contains a list of email addresses. */
\r
104 > addr = user_address_in_string (ptr, config);
\r
105 > @@ -440,7 +440,7 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message
\r
106 > * system in this step of the receive chain
\r
109 > - while((by = strstr (by, " by ")) != NULL) {
\r
110 > + while((by = strstr (by, "by ")) != NULL) {
\r
117 > _______________________________________________
\r
118 > notmuch mailing list
\r
119 > notmuch@notmuchmail.org
\r
120 > http://notmuchmail.org/mailman/listinfo/notmuch
\r