1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4C08B431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 26 Dec 2012 06:31:11 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id yOsMGDjee3T5 for <notmuch@notmuchmail.org>;
\r
16 Wed, 26 Dec 2012 06:31:10 -0800 (PST)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id DAF5A431FAE
\r
21 for <notmuch@notmuchmail.org>; Wed, 26 Dec 2012 06:31:10 -0800 (PST)
\r
22 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.82.78] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa
\r
25 (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
\r
26 (envelope-from <bremner@unb.ca>)
\r
27 id 1Tns0g-0002Tq-WC; Wed, 26 Dec 2012 10:31:07 -0400
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
29 (envelope-from <bremner@unb.ca>)
\r
30 id 1Tns0b-0005y1-Bg; Wed, 26 Dec 2012 10:31:01 -0400
\r
31 From: David Bremner <david@tethera.net>
\r
32 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v2 2/5] util: Function to parse boolean term queries
\r
34 In-Reply-To: <1356493723-11085-3-git-send-email-amdragon@mit.edu>
\r
35 References: <1356493723-11085-1-git-send-email-amdragon@mit.edu>
\r
36 <1356493723-11085-3-git-send-email-amdragon@mit.edu>
\r
37 User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Wed, 26 Dec 2012 10:31:01 -0400
\r
40 Message-ID: <87ip7oril6.fsf@zancas.localnet>
\r
42 Content-Type: text/plain
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Wed, 26 Dec 2012 14:31:11 -0000
\r
58 Austin Clements <amdragon@MIT.EDU> writes:
\r
60 > + char *out = talloc_strdup (ctx, pos + 1);
\r
62 > + /* Find the closing quote and un-double doubled internal
\r
64 > + for (pos = *term_out = out; *pos; ) {
\r
66 Since you strdup anyway, wouldn't it be easier to understand if pos read
\r
67 from the input string and out wrote to term_out? Something like
\r
70 index db01b4b..e4157d0 100644
\r
71 --- a/util/string-util.c
\r
72 +++ b/util/string-util.c
\r
73 @@ -112,11 +112,12 @@ parse_boolean_term (void *ctx, const char *str,
\r
75 /* Implement de-quoting compatible with make_boolean_term. */
\r
77 - char *out = talloc_strdup (ctx, pos + 1);
\r
80 + *term_out= talloc_strdup (ctx, pos + 1);
\r
81 /* Find the closing quote and un-double doubled internal
\r
83 - for (pos = *term_out = out; *pos; ) {
\r
84 + for (out = *term_out; *pos; ) {
\r
89 Perhaps the two talloc_strdups can even be unified, but I wouldn't worry
\r
90 too much about that.
\r