1 Return-Path: <novalazy@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 17A40431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 13 May 2013 06:53:52 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 0OI65rGjU-wO for <notmuch@notmuchmail.org>;
\r
17 Mon, 13 May 2013 06:53:47 -0700 (PDT)
\r
18 Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com
\r
19 [209.85.192.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 33DFF431FAE
\r
22 for <notmuch@notmuchmail.org>; Mon, 13 May 2013 06:53:47 -0700 (PDT)
\r
23 Received: by mail-pd0-f174.google.com with SMTP id u10so4456310pdi.19
\r
24 for <notmuch@notmuchmail.org>; Mon, 13 May 2013 06:53:45 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=x-received:date:message-id:from:to:cc:subject:in-reply-to
\r
27 :references:mime-version:content-type:content-disposition
\r
28 :content-transfer-encoding;
\r
29 bh=KRSnQYQwCjiYZl16fLFkml1pbhCArpZ8GFNIUBvQu8I=;
\r
30 b=PIIdv7EnSKUU+Ubg+WaHDJpwPTZGdvfAoDA59cpu6TUlWapDj22qF0HHaFVih6WWqx
\r
31 OhW2FCjCcXi482P9Hfr2B/UwmJLIZwXdVWLpWqnbRaEFlpD9ORUur7YXVHfHcZAnZDXc
\r
32 rFR12HpsstbY/EeKION0h2eX3DrlRcgVUnZL/GnzpbwpvbcVf/AIcebAVQFRMHebxO+Q
\r
33 h3WTXONB4BIAe8XTqdBguJ14NaDyFYBDygZvt6+u2nHjo4m/MIpWCEt+bXIPvM9xpUVv
\r
34 8zyw4mXaIiCdI/OX4EUIOWTYvVCRbfeqxrz1Ku77PxsbiZN4Ga12NiCHMVXVVNUmG2ls
\r
36 X-Received: by 10.68.100.98 with SMTP id ex2mr24918925pbb.19.1368453225326;
\r
37 Mon, 13 May 2013 06:53:45 -0700 (PDT)
\r
38 Received: from localhost (215.42.233.220.static.exetel.com.au.
\r
39 [220.233.42.215]) by mx.google.com with ESMTPSA id
\r
40 br2sm14132896pbc.46.2013.05.13.06.53.42 for <multiple recipients>
\r
41 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
42 Mon, 13 May 2013 06:53:44 -0700 (PDT)
\r
43 Date: Mon, 13 May 2013 23:53:38 +1000
\r
44 Message-ID: <20130513235338.GA20690@hili.localdomain>
\r
45 From: Peter Wang <novalazy@gmail.com>
\r
46 To: David Bremner <david@tethera.net>
\r
47 Subject: Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t
\r
48 In-Reply-To: <87zjw0la1n.fsf@zancas.localnet>
\r
49 References: <1368301809-12532-1-git-send-email-markwalters1009@gmail.com>
\r
50 <1368301809-12532-8-git-send-email-markwalters1009@gmail.com>
\r
51 <87zjw0la1n.fsf@zancas.localnet>
\r
53 Content-Type: text/plain; charset=utf-8
\r
54 Content-Disposition: inline
\r
55 Content-Transfer-Encoding: 8bit
\r
56 Cc: notmuch@notmuchmail.org
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Mon, 13 May 2013 13:53:52 -0000
\r
71 On Sun, 12 May 2013 08:20:04 -0300, David Bremner <david@tethera.net> wrote:
\r
72 > Mark Walters <markwalters1009@gmail.com> writes:
\r
74 > > - notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FALSE);
\r
75 > > + notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FLAG);
\r
77 > Shouldn't the documentation be updated to cover NOTMUCH_EXCLUDE_FLAG? I
\r
78 > realize it is not _wrong_ as written, but it is a bit confusing not to
\r
79 > cover all possible values of the enum.
\r
81 Actually, please drop patch 7 and patch 8. It was wrong to combine the
\r
82 CLI-level EXCLUDE_* constants with the lib-level NOTMUCH_EXCLUDE_* constants.
\r