1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1827C431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 6 May 2014 00:45:05 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id MVesYUx4f+sh for <notmuch@notmuchmail.org>;
\r
16 Tue, 6 May 2014 00:45:01 -0700 (PDT)
\r
17 Received: from mail-we0-f176.google.com (mail-we0-f176.google.com
\r
18 [74.125.82.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 98EE8431FAE
\r
21 for <notmuch@notmuchmail.org>; Tue, 6 May 2014 00:45:01 -0700 (PDT)
\r
22 Received: by mail-we0-f176.google.com with SMTP id q59so6123997wes.21
\r
23 for <notmuch@notmuchmail.org>; Tue, 06 May 2014 00:45:00 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:to:subject:in-reply-to:references:user-agent
\r
27 :from:date:message-id:mime-version:content-type;
\r
28 bh=zne+Kx5l+3vGiNAF0R4Y+LXD/flBfFv8LPgkWD9+hGY=;
\r
29 b=cBd9WMiUPZYfkiCjwHg3FnPszE4hUCQHxvirIkZwWXaHO1vROG0i45CFtJtY7qTlV0
\r
30 LwWbq0sYfePYk0uPnYjmY7OmeKS6bFHgbRFM7QHmersi45TLoYCwoGxlZIXZ0YZ/dj/s
\r
31 mOfsnZeEBTxo8qbD+PY+2nCbpAQ9/aB9fj8h2uYq8pbZS1vwLgj5mvCyZjkS16iFTcZh
\r
32 2v1gp8lfCo+BKPWNbT8ci1AFLLZFZE97Rls+o0z1PBMb7XgMMQrrXfzm7bs4D4//DllX
\r
33 9t0uu//r9CLP+uNm04xgu9YBJWkTbtGa2oCElqv1sLg+ZU+QaFqqzyW0ODrmJt/FvY6x
\r
36 ALoCoQmq0e2Mau6DYfD4EiPCnfwIXm09qQWB/TwRhSHhHco8d4m9BRqXGci1bBgh1jLXu9ZPHuaa
\r
37 X-Received: by 10.180.13.208 with SMTP id j16mr1147778wic.58.1399362300321;
\r
38 Tue, 06 May 2014 00:45:00 -0700 (PDT)
\r
39 Received: from localhost (disaster-area.hh.sledj.net. [81.149.164.25])
\r
40 by mx.google.com with ESMTPSA id
\r
41 by1sm20745331wjc.26.2014.05.06.00.44.58 for <multiple recipients>
\r
42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
43 Tue, 06 May 2014 00:44:59 -0700 (PDT)
\r
44 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
45 Subject: Re: [PATCH] emacs: put current query as default value
\r
46 in notmuch-read-query
\r
47 In-Reply-To: <874n134bbi.fsf@qmul.ac.uk>
\r
48 References: <1399133579-9106-1-git-send-email-markwalters1009@gmail.com>
\r
49 <cunha53fm8v.fsf@hotblack-desiato.hh.sledj.net>
\r
50 <874n134bbi.fsf@qmul.ac.uk>
\r
51 User-Agent: Notmuch/0.18~rc0 (http://notmuchmail.org) Emacs/24.3.1
\r
52 (x86_64-pc-linux-gnu)
\r
53 From: David Edmondson <dme@dme.org>
\r
54 Date: Tue, 06 May 2014 08:44:53 +0100
\r
55 Message-ID: <cund2frfj0q.fsf@hotblack-desiato.hh.sledj.net>
\r
57 Content-Type: multipart/signed; boundary="=-=-=";
\r
58 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Tue, 06 May 2014 07:45:05 -0000
\r
74 Content-Type: text/plain
\r
75 Content-Transfer-Encoding: quoted-printable
\r
77 On Tue, May 06 2014, Mark Walters wrote:
\r
80 > On Tue, 06 May 2014, David Edmondson <dme@dme.org> wrote:
\r
81 >> On Sat, May 03 2014, Mark Walters wrote:
\r
82 >>> An alternative to putting the logic in notmuch-read-query would be to
\r
83 >>> store the query in a consistently named buffer local variable in all
\r
84 >>> the modes. If we want to show the actually run query in notmuch-show
\r
85 >>> above then this is probably the neatest solution.
\r
87 >> Could per-mode query functions not simply pass the default as an
\r
88 >> optional second argument to `notmuch-read-query'?
\r
90 > They could but at the moment notmuch-search and notmuch-tree are both
\r
91 > bound in the global key map and they in turn call notmuch-read-query.=20
\r
93 > I guess we could add an argument to notmuch-search and notmuch-tree
\r
94 > for the default argument (which they would pass to
\r
95 > notmuch-read-query). Then calling modes which know a search value
\r
96 > (show,search and tree) could override the global keymap (probably using
\r
97 > remap or something to mean that they keep any customised binding) to
\r
98 > link into something which passes the default value through.
\r
100 I would probably replace the global keymap bindings, but others should
\r
103 > One variant which might be nicer than the current version would be to
\r
104 > have something like
\r
105 > (let ((current-query (case major-mode
\r
106 > (notmuch-show-mode (notmuch-show-get-current-q=
\r
108 > (notmuch-tree-mode (notmuch-tree-get-current-q=
\r
110 > (notmuch-search-mode (notmuch-search-get-curre=
\r
113 > so at least all the logic for calculating the current query can live in
\r
114 > the relevant file.
\r
116 > What do you think?
\r
118 This is nicer than the current patch.
\r
121 Content-Type: application/pgp-signature; name="signature.asc"
\r
123 -----BEGIN PGP SIGNATURE-----
\r
126 iKYEARECAGYFAlNokvZfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
\r
127 bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5
\r
128 RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRYscACfeF4wpsLhmlckRc7MdGZEcye9
\r
129 +HoAnA1nLKezzb1zRr2jZbE0WFDeSdR0
\r
131 -----END PGP SIGNATURE-----
\r