1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 25B49431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:11:07 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id lj0AE7WL-Csf for <notmuch@notmuchmail.org>;
\r
16 Wed, 18 Apr 2012 06:11:06 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 7EC32431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:11:06 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 6786A68055; Wed, 18 Apr 2012 16:11:02 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH] vim: simplify build
\r
25 In-Reply-To: <1334751115-7216-1-git-send-email-felipe.contreras@gmail.com>
\r
26 References: <1334751115-7216-1-git-send-email-felipe.contreras@gmail.com>
\r
27 User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1
\r
28 (x86_64-unknown-linux-gnu)
\r
29 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
30 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
31 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
32 Date: Wed, 18 Apr 2012 16:11:02 +0300
\r
33 Message-ID: <m2ty0hxk0p.fsf@guru.guru-group.fi>
\r
35 Content-Type: text/plain; charset=us-ascii
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.13
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Wed, 18 Apr 2012 13:11:07 -0000
\r
50 On Wed, Apr 18 2012, Felipe Contreras <felipe.contreras@gmail.com> wrote:
\r
52 > There should be no functional changes, except that you don't need to
\r
53 > make the directories before installing.
\r
55 > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
\r
58 Hmm, Where is $(PWD) make variable documented; I found only $(CURDIR)
\r
59 anyway, te following test makefile works OK.
\r
65 (i.e. both echo the current directory)
\r
67 If this is not an issue, then LGTM.
\r
71 > vim/Makefile | 19 +++++++++----------
\r
72 > 1 file changed, 9 insertions(+), 10 deletions(-)
\r
74 > diff --git a/vim/Makefile b/vim/Makefile
\r
75 > index 89e18be..e7b7faa 100644
\r
76 > --- a/vim/Makefile
\r
77 > +++ b/vim/Makefile
\r
79 > .PHONY: all help install link symlink
\r
81 > -FILES = plugin/notmuch.vim \
\r
82 > - $(wildcard syntax/notmuch-*.vim)
\r
83 > +files = plugin/notmuch.vim \
\r
84 > + $(wildcard syntax/notmuch-*.vim)
\r
85 > +prefix = $(HOME)/.vim
\r
86 > +destdir = $(prefix)/plugin
\r
88 > -PREFIX = $(shell ls -d ~/.vim/)
\r
90 > -OUT_FILES = $(FILES:%=${PREFIX}/%)
\r
91 > +INSTALL = install -D -m644
\r
95 > @@ -16,9 +16,8 @@ help:
\r
96 > @echo " make install - copy plugin scripts and syntax files to ~/.vim"
\r
97 > @echo " make symlink - create symlinks in ~/.vim (useful for development)"
\r
99 > -install: ${OUT_FILES}
\r
101 > - ${MAKE} SYMLINK=1 install
\r
103 > + @for x in $(files); do $(INSTALL) $(PWD)/$$x $(prefix)/$$x; done
\r
105 > -${OUT_FILES}: ${PREFIX}/%: %
\r
106 > - $(if ${SYMLINK},ln -fs,cp) `pwd`/$< $@
\r
107 > +link symlink: INSTALL = ln -fs
\r
108 > +link symlink: install
\r
112 > _______________________________________________
\r
113 > notmuch mailing list
\r
114 > notmuch@notmuchmail.org
\r
115 > http://notmuchmail.org/mailman/listinfo/notmuch
\r