1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4D866429E25
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 13:21:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 4GzzROLEwXLh for <notmuch@notmuchmail.org>;
\r
17 Fri, 3 Jun 2011 13:21:43 -0700 (PDT)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E5B08431FB6
\r
22 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 13:21:42 -0700 (PDT)
\r
23 Received: by bwg12 with SMTP id 12so2235026bwg.26
\r
24 for <notmuch@notmuchmail.org>; Fri, 03 Jun 2011 13:21:41 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=domainkey-signature:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=iF0NXSwJuOa5sdbVHBehW3+jhit6R0dJghVLfkbctwQ=;
\r
29 b=P65NDbNFIEejt788NfH1zcEP1ogNULbUE9jg4ibGMPneFRzacS5n6UMrsSAmky6U4T
\r
30 dAoXtk3GbvxwLo4P/hdxnjLloye7481KXgFFYRSY+zeeeqiOwp7mKnQDMaVaFwXYBNi1
\r
31 ikifO4PXrrvzgYaauFJ5LZA5euF8Rj19UEkck=
\r
32 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
33 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
34 :mime-version:content-type;
\r
35 b=Oc2X8cOjN32QbQ9i5kwj7gyJ7kASXxxuWJjrhbnZBpYOVjpkhiwe0q22zyA8Kx4VUS
\r
36 47Nkr155cLPrKEj0T6EUcSVKhZFkM9QMynBoqmS0loE5uOKLzWCkX3w6RHdPoV1AuBHw
\r
37 /KVW3H7jzv49fs+5T9duSy+Vplc0/Auk+1Mnw=
\r
38 Received: by 10.204.38.194 with SMTP id c2mr2219135bke.90.1307132501388;
\r
39 Fri, 03 Jun 2011 13:21:41 -0700 (PDT)
\r
40 Received: from localhost ([91.144.186.21])
\r
41 by mx.google.com with ESMTPS id k10sm1498019bkq.22.2011.06.03.13.21.39
\r
42 (version=TLSv1/SSLv3 cipher=OTHER);
\r
43 Fri, 03 Jun 2011 13:21:39 -0700 (PDT)
\r
44 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
45 To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>
\r
46 Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.
\r
47 In-Reply-To: <87oc2ellzn.fsf@yoom.home.cworth.org>
\r
48 References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>
\r
49 <1306619520-25730-2-git-send-email-jrollins@finestructure.net>
\r
50 <1306619520-25730-3-git-send-email-jrollins@finestructure.net>
\r
51 <1306619520-25730-4-git-send-email-jrollins@finestructure.net>
\r
52 <1306619520-25730-5-git-send-email-jrollins@finestructure.net>
\r
53 <1306619520-25730-6-git-send-email-jrollins@finestructure.net>
\r
54 <1306619520-25730-7-git-send-email-jrollins@finestructure.net>
\r
55 <1306619520-25730-8-git-send-email-jrollins@finestructure.net>
\r
56 <1306619520-25730-9-git-send-email-jrollins@finestructure.net>
\r
57 <1306619520-25730-10-git-send-email-jrollins@finestructure.net>
\r
58 <1306619520-25730-11-git-send-email-jrollins@finestructure.net>
\r
59 <1306619520-25730-12-git-send-email-jrollins@finestructure.net>
\r
60 <1306619520-25730-13-git-send-email-jrollins@finestructure.net>
\r
61 <1306619520-25730-14-git-send-email-jrollins@finestructure.net>
\r
62 <1306619520-25730-15-git-send-email-jrollins@finestructure.net>
\r
63 <874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com>
\r
64 <87oc2ellzn.fsf@yoom.home.cworth.org>
\r
65 User-Agent: Notmuch/0.5-208-g109ec1a (http://notmuchmail.org) Emacs/23.3.1
\r
66 (x86_64-pc-linux-gnu)
\r
67 Date: Sat, 04 Jun 2011 00:22:04 +0400
\r
68 Message-ID: <87ipsmpswj.fsf@gmail.com>
\r
70 Content-Type: text/plain; charset=us-ascii
\r
71 X-BeenThere: notmuch@notmuchmail.org
\r
72 X-Mailman-Version: 2.1.13
\r
74 List-Id: "Use and development of the notmuch mail system."
\r
75 <notmuch.notmuchmail.org>
\r
76 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
78 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
79 List-Post: <mailto:notmuch@notmuchmail.org>
\r
80 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
81 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
82 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
83 X-List-Received-Date: Fri, 03 Jun 2011 20:21:44 -0000
\r
85 On Fri, 03 Jun 2011 13:05:00 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
86 Non-text part: multipart/signed
\r
87 > On Thu, 02 Jun 2011 10:49:57 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
88 > > Well, it says that changes are in notmuch 0.5. So "old" and "previous"
\r
89 > > refer to pre-0.5 (i.e. 0.4) and "new" refers to 0.5.
\r
91 > Sure, but I happen to ahve already forgotten the details of how the
\r
92 > variable could be configured in 0.4 and in 0.5. More importantly, anyone
\r
93 > in the future reading the commit log is much more likely not to
\r
96 > > Any configuration when `notmuch-fcc-dirs' is a list. That variable has
\r
97 > > a nice documentation.
\r
99 > Again, I'd like our commit messages to be self-contained. They are much
\r
100 > more useful if the describe the change being made without assuming to
\r
101 > much outside knowledge.
\r
103 > > > It would be easier to understand the code if there were a corresponding
\r
104 > > > test case for it.
\r
106 > > I do not think we need a test for this fix. What we need are tests for
\r
107 > > FCC functionality when notmuch-fcc-dirs is a list.
\r
111 > > Old configuration format was changed in 0.5 in an incompatible way.
\r
112 > > There is a check for the unsupported old-style configuration. But the
\r
113 > > check is broken and results in an error when running with a valid
\r
114 > > new-style configuration.
\r
116 > This is actually what I meant by "corresponding test case". If the bug
\r
117 > here is that a "new-style configuration" doesn't work , (and I still
\r
118 > don't like that wording---don't say "new style"---explain what it
\r
119 > actually *is*), then yes, we need a test case showing that bug.
\r
121 > > I am not sure what you expect from the commit message here. IMO it is
\r
122 > > enough for this small bugfix and those who interested can always refer
\r
123 > > to documentation for details.
\r
125 > The commit message should provide a self-contained description of the
\r
126 > change. It should be along the lines of:
\r
128 > When fcc-dirs is set to
\r
129 > <some-particular-datatype-that-should-work> notmuch was
\r
130 > incorecctly detecting this as the
\r
131 > <old-style-that-is-no-longer-supported> and generating an error
\r
132 > message. Fix the test so that this configuration now works.
\r
134 > Where the <phrases> above should be replaced with actual descriptions,
\r
135 > not relative pointers to information like "old style" or "new style".
\r
137 > Does that make sense?
\r
140 "notmuch was incorecctly detecting this as the ..." is not right. It is
\r
141 a wrong-type-argument lisp error (evaluating (length '(a . b))). How
\r
144 Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup' when
\r
145 `notmuch-fcc-dirs' is set to a list. The error was in the
\r
146 `notmuch-fcc-dirs' format check which was changed in an incompatible
\r
147 way from 0.4 to 0.5.
\r
153 Non-text part: application/pgp-signature
\r