1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 480D4431FBC
\r
6 for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 19:19:22 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id fF72-gr0aVq7 for <notmuch@notmuchmail.org>;
\r
16 Mon, 27 Aug 2012 19:19:21 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 9AD5D431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 19:19:21 -0700 (PDT)
\r
21 X-AuditID: 1209190e-b7fc36d00000399b-ca-503c2aa8f34d
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id DD.2F.14747.8AA2C305; Mon, 27 Aug 2012 22:19:20 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q7S2JJFn028900;
\r
27 Mon, 27 Aug 2012 22:19:20 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q7S2JHPt019763
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Mon, 27 Aug 2012 22:19:18 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1T6BOf-0001ha-MC; Mon, 27 Aug 2012 22:19:17 -0400
\r
37 Date: Mon, 27 Aug 2012 22:19:17 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Michal Nazarewicz <mpn@google.com>
\r
40 Subject: Re: [PATCH] emacs: notmuch-search: fix faces
\r
41 Message-ID: <20120828021917.GC11179@mit.edu>
\r
43 <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com>
\r
44 <87ipc4jcfv.fsf@servo.finestructure.net> <xa1t3938ue0m.fsf@mina86.com>
\r
45 <20120828002215.GB11179@mit.edu> <xa1twr0ju9cq.fsf@mina86.com>
\r
47 Content-Type: text/plain; charset=utf-8
\r
48 Content-Disposition: inline
\r
49 Content-Transfer-Encoding: 8bit
\r
50 In-Reply-To: <xa1twr0ju9cq.fsf@mina86.com>
\r
51 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
52 X-Brightmail-Tracker:
\r
53 H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsUixCmqrLtCyybA4PBWEYtX3/vYLa7fnMns
\r
54 wOSxYFOpx7NVt5gDmKK4bFJSczLLUov07RK4Mg48uMtScF+44unuacwNjO/4uxg5OSQETCT+
\r
55 X+pihrDFJC7cW8/WxcjFISSwj1Hixpm1LBDOBkaJ6bfOMEE4J5kkmq4cgsosYZSYOWkZO0g/
\r
56 i4CqxLKvj1lBbDYBDYlt+5czgtgiAmoSF/88ZgKxmQWkJb79bgazhQVMJebNXM0CYvMK6Ehc
\r
57 vLgXasNTRonNs74xQiQEJU7OfMIC0awu8WfeJaBjOcAGLf/HARGWl2jeOhvsB04BLYlDT5eA
\r
58 3SAqoCIx5eQ2tgmMwrOQTJqFZNIshEmzkExawMiyilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdY
\r
59 LzezRC81pXQTIzgSJPl2MH49qHSIUYCDUYmH98VK6wAh1sSy4srcQ4ySHExKoryT1WwChPiS
\r
60 8lMqMxKLM+KLSnNSiw8xSnAwK4nwsggC5XhTEiurUovyYVLSHCxK4rxXUm76CwmkJ5akZqem
\r
61 FqQWwWRlODiUJHgVgREvJFiUmp5akZaZU4KQZuLgBBnOAzT8gybI8OKCxNzizHSI/ClGRSlx
\r
62 3j8gCQGQREZpHlwvLFG9YhQHekWYlx1kBQ8wycF1vwIazAQ0eL+iNcjgkkSElFQD43zDyqDG
\r
63 3fEWOoWMTst/Vn6tOGwap6m2ynzHsnWLZ74uucKRYDhL5s88x0PfphV8n/EgJ7R/TSHbLyF+
\r
64 gSct0dqPPnT8/LqtpNru44Xcg9qLQ+QYPyw7UbL/d0jpo4sxKfFNi9eEWllKVWm8emyYf6dv
\r
65 pebXLzYf3s98yGOmv9//4CIp5pXH7imxFGckGmoxFxUnAgCFc9zQLwMAAA==
\r
66 Cc: notmuch@notmuchmail.org
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.13
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Tue, 28 Aug 2012 02:19:22 -0000
\r
81 Quoth Michal Nazarewicz on Aug 28 at 2:51 am:
\r
82 > > Quoth Michal Nazarewicz on Aug 28 at 1:11 am:
\r
83 > >> I'm not an expert either, but with this patch applied I see colours,
\r
84 > >> without this patch, I don't see colours, ie. everything is rendered
\r
85 > >> using the default face.
\r
87 > >> I'm also not entirely sure if that's the correct way of doing things
\r
88 > >> since 'face seems to be working in other modes (most notably
\r
89 > >> notmuch-show). By posting, I'm also hoping that someone more
\r
90 > >> experienced will maybe take a look to see what's going on here... ;)
\r
92 > >> For some more info, in notmuch-show mode, I get-text-property of nil for
\r
93 > >> both 'face and 'font-lock-face, but in message-mode or in *scratch*
\r
94 > >> buffer I'm getting nil for 'font-lock-face but non-nil for 'face. With
\r
95 > >> the patch, I'm getting the same non-nil for both 'face and
\r
96 > >> 'font-lock-face; without the patch, I'm getting nil for both.
\r
98 > Austin Clements <amdragon@MIT.EDU> writes:
\r
99 > > This is odd. Could you give more details about your environment? In
\r
100 > > particular, what Emacs version are you running and might you have any
\r
101 > > unusual Emacs packages installed or customizations set?
\r
103 > I'm running Emacs compiled from a week old bzr head, emacs-version
\r
104 > reports: “GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08-21
\r
107 > I don't think I have any “unusual” packages, but I do have quite a bit
\r
108 > of customization, which you might find at
\r
109 > <https://github.com/mina86/dot-files/blob/master/dot-emacs>.
\r
111 I think the culprit is your "Show blanks and FIXME"
\r
112 font-lock-mode-hook.
\r
114 > > The unusual thing about font-lock-face is that it only gets applied if
\r
115 > > font-lock is enabled; otherwise it's ignored. One theory is that the
\r
116 > > nil font-lock-face (without your patch) is causing font-lock to
\r
117 > > *override* the face property that we set. I don't think font-lock
\r
118 > > usually does that, but perhaps in some situations, it will?
\r
120 > Ha! That could be the cause. I've disabled global-font-lock-mode, and
\r
121 > the colours appeared. Getting property returns non-nil for 'face and
\r
122 > nil for 'font-lock-face. When I enable font-lock-mode the property seem
\r
123 > to disappear and disabling font-lock-mode again does not help.
\r
125 It's possible we should use font-lock-face. I'm not sure. Poking
\r
126 around the standard elisp, it looks like some things use 'face and
\r
127 some things use 'font-lock-face. I think 'face is more common, but
\r
128 it's hard to grep for.
\r