b1/658c383592b1f0bed5365674a9f46f28b95882

   1 Return-Path: <novalazy@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id C61D4431FAF\r
   6         for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 07:14:03 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.099\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id sUFlCAMFQnlh for <notmuch@notmuchmail.org>;\r
  17         Wed, 11 Sep 2013 07:13:58 -0700 (PDT)\r
  18 Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com\r
  19         [209.85.192.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 366AF431FAE\r
  22         for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 07:13:58 -0700 (PDT)\r
  23 Received: by mail-pd0-f172.google.com with SMTP id z10so9245750pdj.31\r
  24         for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 07:13:56 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
  26         h=date:message-id:from:to:cc:subject:in-reply-to:references\r
  27         :mime-version:content-type:content-disposition\r
  28         :content-transfer-encoding;\r
  29         bh=ty5zMNmhBdqZEu4Sm/avDtvcBpTPSj3kIcERbW6Pp48=;\r
  30         b=iSNfK1maHfwWuSBsTp5bKDoRVEos8JAIpQWcW6n4BqOyAelINVzgKwU7dIk6j+7plF\r
  31         D2Ks5ga+DjVkTbyTsiKj75ANKmETMnUkocWK7NSuiXHUgnWZPsFzpHEHjUShnl3NS7nb\r
  32         pE/45D5xcwHlyCoFvX+kntlAtW7+Mmj2Vt+I0V9bcMr65mj3vdCuszHlnEnwOxs8DkX+\r
  33         s80BVqDunret8EUXpK4YM+/nbY18fK0/VDWxQHPl3PiCSVxR5+EViuJqDN/ZOKwkwRrG\r
  34         /OqxQdN/9GTwGbXmKnXqqU107lCg+2AxNugq+iVTf12RS0tSXBme+fC6LnoA3/obq6h2\r
  35         Wlcw==\r
  36 X-Received: by 10.67.14.67 with SMTP id fe3mr3959503pad.134.1378908835283;\r
  37         Wed, 11 Sep 2013 07:13:55 -0700 (PDT)\r
  38 Received: from localhost (215.42.233.220.static.exetel.com.au.\r
  39         [220.233.42.215]) by mx.google.com with ESMTPSA id\r
  40         sy2sm30087727pbc.16.1969.12.31.16.00.00\r
  41         (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
  42         Wed, 11 Sep 2013 07:13:54 -0700 (PDT)\r
  43 Date: Thu, 12 Sep 2013 00:13:49 +1000\r
  44 Message-ID: <20130912001349.GA18821@hili.localdomain>\r
  45 From: Peter Wang <novalazy@gmail.com>\r
  46 To: Mark Walters <markwalters1009@gmail.com>\r
  47 Subject: Re: [PATCH 1/3] cli: add insert --must-index option\r
  48 In-Reply-To: <87hadtxfrr.fsf@qmul.ac.uk>\r
  49 References: <1374365254-13227-1-git-send-email-novalazy@gmail.com>\r
  50         <87ip048gbj.fsf@qmul.ac.uk>\r
  51         <20130727151510.GA13750@hili.localdomain>\r
  52         <87hadtxfrr.fsf@qmul.ac.uk>\r
  53 MIME-Version: 1.0\r
  54 Content-Type: text/plain; charset=utf-8\r
  55 Content-Disposition: inline\r
  56 Content-Transfer-Encoding: 8bit\r
  57 Cc: notmuch@notmuchmail.org\r
  58 X-BeenThere: notmuch@notmuchmail.org\r
  59 X-Mailman-Version: 2.1.13\r
  60 Precedence: list\r
  61 List-Id: "Use and development of the notmuch mail system."\r
  62         <notmuch.notmuchmail.org>\r
  63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  64         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  66 List-Post: <mailto:notmuch@notmuchmail.org>\r
  67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  70 X-List-Received-Date: Wed, 11 Sep 2013 14:14:04 -0000\r
  71 \r
  72 On Tue, 10 Sep 2013 09:06:00 +0100, Mark Walters <markwalters1009@gmail.com> wrote:\r
  73 > \r
  74 > Alternatively maybe add notmuch_database_destroy_with_flush or something\r
  75 > which does give a return value. notmuch_database_close is only called 3\r
  76 > times and notmuch_database_destroy lots of times so changing close is\r
  77 > much less intrusive than changing destroy. But I don't know whether we\r
  78 > would break any  bindings or external programs etc.\r
  79 > \r
  80 > What do you think?\r
  81 \r
  82 I think notmuch_database_close and notmuch_database_destroy should\r
  83 return the status, and we update the three language bindings\r
  84 and bump the soname.\r
  85 \r
  86 Peter\r