1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7E4C0431FC0
\r
6 for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:04:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id OVOPu+CDdQ8A for <notmuch@notmuchmail.org>;
\r
16 Sat, 13 Dec 2014 13:04:23 -0800 (PST)
\r
17 Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com
\r
18 [74.125.82.42]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 1A6F4431FB6 for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:04:23 -0800
\r
22 Received: by mail-wg0-f42.google.com with SMTP id z12so11700640wgg.1
\r
23 for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:04:22 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=HdS/IysqM1EiMVrJYa9uceX/2fJMEnTiyhBqB5fVwOw=;
\r
30 b=InFBznqRnLeHPEngVWBU3USkERqNiNEQPXDwxCTjdSHVlAQi/BqgHWFKdM4PA4d6OT
\r
31 2cWVqDr7poTT4DR6TZR7LilVZMIuy6mPkMVXbRVbux2E6IznETPfDtoPVK+av3CoaqXo
\r
32 9UgQAO4bvLpedluhRb5Ts9JDDBjQVwS6XEnU4R/r0or8vU+qZy/9VJsLsnzY2/sJ0Ou6
\r
33 8TjU7kKQZ5vssZ3uWxT6AjJwV14/hBX1JhTnQZPgTvyqU38i7RruPOIniLMzbAFUPeWD
\r
34 NLBzmH9NBn4yyCmZvmwluptstE1sqXiuNnrm9eAnaVf2fh1Q5Ll3FZJo2/1okCMQdy6f
\r
37 ALoCoQnM4U9nV5B5+9uV4qj5CxfVPZBSqRpSTEFgLNLuvGcfhy8hlLC6+S2+iHZ7AW8ro/hBF47b
\r
38 X-Received: by 10.194.8.232 with SMTP id u8mr12506743wja.47.1418504661883;
\r
39 Sat, 13 Dec 2014 13:04:21 -0800 (PST)
\r
40 Received: from localhost (dsl-hkibrasgw2-58c37d-174.dhcp.inet.fi.
\r
42 by mx.google.com with ESMTPSA id bj3sm6943750wib.3.2014.12.13.13.04.20
\r
43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
44 Sat, 13 Dec 2014 13:04:21 -0800 (PST)
\r
45 From: Jani Nikula <jani@nikula.org>
\r
46 To: =?utf-8?Q?=C5=81ukasz?= Stelmach <stlman@poczta.fm>,
\r
47 notmuch@notmuchmail.org
\r
48 Subject: Re: [PATCH] emacs: do not change users' mail agent configuration
\r
49 In-Reply-To: <1418410466-26604-1-git-send-email-stlman@poczta.fm>
\r
50 References: <1418410466-26604-1-git-send-email-stlman@poczta.fm>
\r
51 User-Agent: Notmuch/0.19+3~g7585e8c (http://notmuchmail.org) Emacs/24.4.1
\r
52 (x86_64-pc-linux-gnu)
\r
53 Date: Sat, 13 Dec 2014 23:04:26 +0200
\r
54 Message-ID: <87k31vqn1h.fsf@nikula.org>
\r
56 Content-Type: text/plain; charset=utf-8
\r
57 Content-Transfer-Encoding: quoted-printable
\r
58 Cc: =?utf-8?Q?=C5=81ukasz?= Stelmach <stlman@poczta.fm>
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Sat, 13 Dec 2014 21:04:26 -0000
\r
73 On Fri, 12 Dec 2014, =C5=81ukasz Stelmach <stlman@poczta.fm> wrote:
\r
74 > `mail-user-agent' is defined with defcustom and may be customised
\r
75 > by users. It should not be set to arbitrary values in modules.
\r
79 > To make use of that configuration value call `compose-mail' which
\r
80 > starts user's preferred mail composition package as selected with
\r
81 > the variable `mail-user-agent' instead of notmuch's hardcoded
\r
84 So your proposed change is that `notmuch-mua-mail` should start
\r
85 whichever mua the user has configured in `mail-user-agent` instead of
\r
86 the notmuch mail composition window, as described in the function
\r
87 documentation? I don't think I like that either.
\r
89 Maybe we should let bind `mail-user-agent` instead?
\r
92 > NEWS | 10 ++++++++++
\r
93 > emacs/notmuch-mua.el | 2 +-
\r
94 > emacs/notmuch.el | 2 --
\r
95 > 3 files changed, 11 insertions(+), 3 deletions(-)
\r
97 > diff --git a/NEWS b/NEWS
\r
98 > index 44e8d05..cf5b3c3 100644
\r
101 > @@ -64,6 +64,16 @@ Added `notmuch address` subcommand
\r
105 > +Fixed `mail-user-agent` handling
\r
107 > + The value of the mail-user-agent variable is not forcibly set to
\r
108 > + `notmuch-user-agent`, regardles of how a user has customised it,
\r
109 > + everytime notmuch.el is loaded. This way, someone who used for example
\r
110 > + Gnus has her MUA and notmuch just as a search engine, doesn't have her
\r
111 > + configuration broken everytime notmuch.el is loaded. The user can now
\r
112 > + use her favourite mail composing package when replying messages in
\r
115 I understand you're annoyed at the current behaviour, but please don't
\r
116 pour that annoyance into notmuch NEWS. Thank you.
\r
123 > Use the `j` key to access saved searches from anywhere in notmuch
\r
125 > `j` is now globally bound to `notmuch-jump`, which provides fast,
\r
126 > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
127 > index 2c58886..f02c7b5 100644
\r
128 > --- a/emacs/notmuch-mua.el
\r
129 > +++ b/emacs/notmuch-mua.el
\r
130 > @@ -263,7 +263,7 @@ OTHER-ARGS are passed through to `message-mail'."
\r
131 > (push (cons 'From (concat
\r
132 > (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) oth=
\r
135 > - (apply #'message-mail to subject other-headers other-args)
\r
136 > + (apply #'compose-mail to subject other-headers other-args)
\r
137 > (message-sort-headers)
\r
138 > (message-hide-headers)
\r
139 > (set-buffer-modified-p nil)
\r
140 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
141 > index 218486a..80cab57 100644
\r
142 > --- a/emacs/notmuch.el
\r
143 > +++ b/emacs/notmuch.el
\r
144 > @@ -1037,8 +1037,6 @@ notmuch buffers exist, run `notmuch'."
\r
145 > (switch-to-buffer first))
\r
148 > -(setq mail-user-agent 'notmuch-user-agent)
\r
150 > (provide 'notmuch)
\r
152 > ;; After provide to avoid loops if notmuch was require'd via notmuch-ini=
\r
157 > _______________________________________________
\r
158 > notmuch mailing list
\r
159 > notmuch@notmuchmail.org
\r
160 > http://notmuchmail.org/mailman/listinfo/notmuch
\r