1 Return-Path: <bgamari.foss@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 71459431FC4
\r
6 for <notmuch@notmuchmail.org>; Wed, 30 Oct 2013 21:10:10 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id trQe4N74x9W4 for <notmuch@notmuchmail.org>;
\r
17 Wed, 30 Oct 2013 21:10:06 -0700 (PDT)
\r
18 Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com
\r
19 [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 05B8D431FC2
\r
22 for <notmuch@notmuchmail.org>; Wed, 30 Oct 2013 21:10:05 -0700 (PDT)
\r
23 Received: by mail-qa0-f46.google.com with SMTP id j15so4243250qaq.5
\r
24 for <notmuch@notmuchmail.org>; Wed, 30 Oct 2013 21:10:03 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=aoUHqBCu/QG50sSwZaf+RK0XZTE6wL3kmoOcgJ1gcQ0=;
\r
29 b=oBo76EQX+IZDhkb+cEcYJTNxXNnTVyzRW5w2MUgw5aMgHx43lIS/aSfQp+FWB2MHtU
\r
30 QqC+cg0FdhJ5lQ++PTowwD1M/bs4Zz6Rpqp1RhhfcOPrTOmrKQz1nblyHDTfj2bafCxA
\r
31 h6J/YCoBlvwaP01grLz0XaJc5h8xM7E5hVLLRgRnfYAMncpYfhX+Zi3hZAhEadBKwdSQ
\r
32 VGZgcHVZLVWIQcA7ouUvcEjXVh2vnxIgp+OZlt+1G/FterTI7jL4zLqGYnHsc7TppJvh
\r
33 A5+fg+fUKksaKdxbZeG8btmgH7mywolr6ryRPUIWHsQluRqBKuinaLc2/u/efJ339IXR
\r
35 X-Received: by 10.224.32.66 with SMTP id b2mr2414766qad.80.1383192603354;
\r
36 Wed, 30 Oct 2013 21:10:03 -0700 (PDT)
\r
37 Received: from localhost (pool-96-240-254-51.spfdma.east.verizon.net.
\r
39 by mx.google.com with ESMTPSA id r1sm5126596qam.4.2013.10.30.21.10.01
\r
40 for <multiple recipients>
\r
41 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
42 Wed, 30 Oct 2013 21:10:02 -0700 (PDT)
\r
43 From: Ben Gamari <bgamari.foss@gmail.com>
\r
44 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
45 Subject: Re: [PATCH 1/4] test: Add compact test
\r
46 In-Reply-To: <m24n80qqy2.fsf@guru.guru-group.fi>
\r
47 References: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com>
\r
48 <m24n80qqy2.fsf@guru.guru-group.fi>
\r
49 User-Agent: Notmuch/0.16+107~g1ef2773 (http://notmuchmail.org) Emacs/24.3.1
\r
50 (x86_64-pc-linux-gnu)
\r
51 Date: Thu, 31 Oct 2013 00:10:00 -0400
\r
52 Message-ID: <87r4b2hyhz.fsf@gmail.com>
\r
54 Content-Type: multipart/signed; boundary="=-=-=";
\r
55 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Thu, 31 Oct 2013 04:10:10 -0000
\r
71 Content-Type: text/plain
\r
72 Content-Transfer-Encoding: quoted-printable
\r
74 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
76 > On Tue, Oct 29 2013, Ben Gamari <bgamari.foss@gmail.com> wrote:
\r
78 >> Signed-off-by: Ben Gamari <bgamari.foss@gmail.com>
\r
81 > Patches 2, 3 & 4 Looks OK To Me. Thanks. A few comments on this patch=20
\r
84 Thanks again for the review!
\r
86 >> test/compact | 35 +++++++++++++++++++++++++++++++++++
\r
87 >> test/notmuch-test | 1 +
\r
88 >> 2 files changed, 36 insertions(+)
\r
89 >> create mode 100755 test/compact
\r
91 >> diff --git a/test/compact b/test/compact
\r
92 >> new file mode 100755
\r
93 >> index 0000000..54e85ab
\r
95 >> +++ b/test/compact
\r
97 >> +#!/usr/bin/env bash
\r
98 >> +test_description=3D'"notmuch compact"'
\r
101 >> +add_message '[subject]=3DOne'
\r
102 >> +add_message '[subject]=3DTwo'
\r
103 >> +add_message '[subject]=3DThree'
\r
105 >> +notmuch tag +tag1 \*
\r
106 >> +notmuch tag +tag2 subject:Two
\r
107 >> +notmuch tag -tag1 +tag3 subject:Three
\r
109 >> +test_begin_subtest "Compacting"
\r
110 >> +notmuch compact
\r
111 >> +test_expect_success "compact" "notmuch compact"
\r
113 > test_expect_success executes "$2" ("notmuch compact" in this case)
\r
114 > do you mean to run notmuch 'compact twice' ?
\r
116 It's been a while but I suspect I just never cleaned up the patch after
\r
117 coming to this realization. Anyways, it's fixed in the revised patch
\r
120 >> +notmuch search \*
\r
121 >> +output=3D$(notmuch search \* | notmuch_search_sanitize)
\r
123 > Now do you mean to run 'notmuch search \*' twice ?
\r
125 >> +test_expect_equal "$output" "\
\r
126 >> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag1 unrea=
\r
128 >> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Two (inbox tag1 tag2 =
\r
130 >> +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Three (inbox tag3 unr=
\r
133 >> +test_begin_subtest "Restoring backup"
\r
134 >> +rm -Rf ${TEST_TMPDIR}/mail/xapian
\r
135 >> +mv ${TEST_TMPDIR}/mail/xapian.old ${TEST_TMPDIR}/mail/xapian
\r
137 >> +notmuch search \*
\r
138 >> +output=3D$(notmuch search \* | notmuch_search_sanitize)
\r
143 > ... actually David Bremner had even more insightful comments in=20
\r
144 > id:874n8cw2yq.fsf@zancas.localnet to these same issues :D
\r
146 Hmm, it seems I overlooked these. Thanks for the reference.
\r
153 Content-Type: application/pgp-signature
\r
155 -----BEGIN PGP SIGNATURE-----
\r
156 Version: GnuPG v1.4.14 (GNU/Linux)
\r
158 iQEcBAEBAgAGBQJScdgYAAoJEErkyLZmeNiDPSoH+wRC+gErdvsUW8Cwp2WmhfCf
\r
159 sHgZv6xrmvDHiVmkzfyf0vlf9XVyVIV3swTb1pzI0vb1DtGzdagOX7LR6nAb0+bK
\r
160 D6ulf+EKCsk5vy4wdaTcQcYEFY6WWXzH3/sWR1MUkN0h+5+R9xm1r1CBsoviioHt
\r
161 CFhkF/GdRsTHi0yczh7ifCXqNWGJav1PtrRLzBTlA8XtT96f0JtBpO+LJxtIwJYB
\r
162 knMAMdeObXd7oeqJ+LApglSOOMzKtkboKV8u2G8FKtEgVSCcue/KV+jJ/3wIFmxL
\r
163 ryDdwuKsGvfFogtZt7n/Xp7dUFI5TIn1sRs3iABH09IJxFClG4YWU/sY5W5bVus=
\r
165 -----END PGP SIGNATURE-----
\r