1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8EBB5431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 28 Apr 2012 17:57:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Mw2OGjw0zHbi for <notmuch@notmuchmail.org>;
\r
16 Sat, 28 Apr 2012 17:57:40 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id F262F431FAE
\r
20 for <notmuch@notmuchmail.org>; Sat, 28 Apr 2012 17:57:39 -0700 (PDT)
\r
21 X-AuditID: 12074425-b7f4a6d0000008e0-ab-4f9c9202e9f5
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 20.F4.02272.2029C9F4; Sat, 28 Apr 2012 20:57:38 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q3T0vcPt006381;
\r
27 Sat, 28 Apr 2012 20:57:38 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3T0vbbp021021
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Sat, 28 Apr 2012 20:57:37 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1SOISH-0000Z2-0N; Sat, 28 Apr 2012 20:57:37 -0400
\r
37 Date: Sat, 28 Apr 2012 20:57:36 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [Patch v4 1/3] emacs: split notmuch-show-apply-state
\r
41 Message-ID: <20120429005736.GK2704@mit.edu>
\r
42 References: <1335658006-20161-1-git-send-email-markwalters1009@gmail.com>
\r
43 <1335658006-20161-2-git-send-email-markwalters1009@gmail.com>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Content-Disposition: inline
\r
47 In-Reply-To: <1335658006-20161-2-git-send-email-markwalters1009@gmail.com>
\r
48 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
49 X-Brightmail-Tracker:
\r
50 H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT0WWaNMffYNN3NYvVc3ksrt+cyezA
\r
51 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZSz6eoa1YItIxfOuJcwNjP/4uxg5OSQETCTa
\r
52 L81kh7DFJC7cW88GYgsJ7GOU2LvBsYuRC8jewChx6MZFNgjnJJPEseXnmCGcJYwSd4+eZAJp
\r
53 YRFQlXjxqwNsFJuAhsS2/csZQWwRAR2J24cWgMWZBaQlvv1uBqsXFnCUmHf9NjOIzSugLdG8
\r
54 7QILxNBORokTF/+zQSQEJU7OfMIC0awlcePfS6BmDrBBy/9xgIQ5BbwkDr06BrZLVEBFYsrJ
\r
55 bWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRboWermZJXqpKaWbGMFh
\r
56 7aK6g3HCIaVDjAIcjEo8vLuy5vgLsSaWFVfmHmKU5GBSEuUVmgAU4kvKT6nMSCzOiC8qzUkt
\r
57 PsQowcGsJMKrLQ6U401JrKxKLcqHSUlzsCiJ82pqvfMTEkhPLEnNTk0tSC2CycpwcChJ8EpP
\r
58 BGoULEpNT61Iy8wpQUgzcXCCDOcBGi4MUsNbXJCYW5yZDpE/xagoJc7rBZIQAElklObB9cLS
\r
59 zitGcaBXhHnVQKp4gCkLrvsV0GAmoMFMnrNABpckIqSkGhinlYifTbpp5jLxwkQjDTU3c965
\r
60 Hms+HV1Xvcb2U67E6c8uK48xbZx8++s/6aeCqZ+F4lf9crl4Iy5Bm2uJdiGr+ummxuCsiZub
\r
61 n1oZH8hW0L/PGdnwYmrZLrX5aYuXhDVGn6kq8N/T96R0UeivqNlnF2/T3yrmbSRRdazNqH/O
\r
62 hY/zDDf4Bx1VYinOSDTUYi4qTgQAPcRM4RYDAAA=
\r
63 Cc: notmuch@notmuchmail.org
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Sun, 29 Apr 2012 00:57:40 -0000
\r
78 Hmm. I think this will wind up spuriously marking messages read. If
\r
79 notmuch-show-refresh-view is called with reset-state set to t, it will
\r
80 mark the first open message read, before you move to the previously
\r
83 IMO, notmuch-show-refresh-view should not be marking messages read at
\r
84 all, but I tried to separate out that functionality before and failed.
\r
85 Perhaps you can find a good way to do it. A more incremental but
\r
86 slightly lame approach could be to pass some symbol for reset-state
\r
87 that indicates it should reset the open state, but not the
\r
88 position... and not mark anything read. Ugh.
\r
90 Quoth Mark Walters on Apr 29 at 1:06 am:
\r
91 > Separate out a notmuch-show-goto-msg-id sub-function from
\r
92 > notmuch-show-apply-state. There should be no functional change but the
\r
93 > next patch will call the new function.
\r
95 > emacs/notmuch-show.el | 18 +++++++++++-------
\r
96 > 1 files changed, 11 insertions(+), 7 deletions(-)
\r
98 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
99 > index 30b26d1..3bd9a64 100644
\r
100 > --- a/emacs/notmuch-show.el
\r
101 > +++ b/emacs/notmuch-show.el
\r
102 > @@ -1085,6 +1085,16 @@ This includes:
\r
103 > - the current message."
\r
104 > (list (notmuch-show-get-message-id) (notmuch-show-get-message-ids-for-open-messages)))
\r
106 > +(defun notmuch-show-goto-message (msg-id)
\r
107 > + "Go to message with msg-id."
\r
108 > + (goto-char (point-min))
\r
109 > + (unless (loop if (string= msg-id (notmuch-show-get-message-id))
\r
111 > + until (not (notmuch-show-goto-message-next)))
\r
112 > + (goto-char (point-min))
\r
113 > + (message "Message-id not found."))
\r
114 > + (notmuch-show-message-adjust))
\r
116 > (defun notmuch-show-apply-state (state)
\r
117 > "Apply STATE to the current buffer.
\r
119 > @@ -1102,13 +1112,7 @@ This includes:
\r
120 > until (not (notmuch-show-goto-message-next)))
\r
122 > ;; Go to the previously open message.
\r
123 > - (goto-char (point-min))
\r
124 > - (unless (loop if (string= current (notmuch-show-get-message-id))
\r
126 > - until (not (notmuch-show-goto-message-next)))
\r
127 > - (goto-char (point-min))
\r
128 > - (message "Previously current message not found."))
\r
129 > - (notmuch-show-message-adjust)))
\r
130 > + (notmuch-show-goto-message current)))
\r
132 > (defun notmuch-show-refresh-view (&optional reset-state)
\r
133 > "Refresh the current view.
\r
136 Austin Clements MIT/'06/PhD/CSAIL
\r
137 amdragon@mit.edu http://web.mit.edu/amdragon
\r
138 Somewhere in the dream we call reality you will find me,
\r
139 searching for the reality we call dreams.
\r