1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8AD17431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 12:55:31 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id DHDygNhRxF8G for <notmuch@notmuchmail.org>;
\r
16 Sun, 19 Feb 2012 12:55:31 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id C5FBB431FAE
\r
21 for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 12:55:30 -0800 (PST)
\r
22 Received: by wibhi8 with SMTP id hi8so3112374wib.26
\r
23 for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 12:55:29 -0800 (PST)
\r
24 Received-SPF: pass (google.com: domain of pieter@praet.org designates
\r
25 10.180.86.105 as permitted sender) client-ip=10.180.86.105;
\r
26 Authentication-Results: mr.google.com;
\r
27 spf=pass (google.com: domain of pieter@praet.org
\r
28 designates 10.180.86.105 as permitted sender)
\r
29 smtp.mail=pieter@praet.org
\r
30 Received: from mr.google.com ([10.180.86.105])
\r
31 by 10.180.86.105 with SMTP id o9mr12082813wiz.4.1329684929715 (num_hops
\r
32 = 1); Sun, 19 Feb 2012 12:55:29 -0800 (PST)
\r
33 Received: by 10.180.86.105 with SMTP id o9mr10108269wiz.4.1329684929632;
\r
34 Sun, 19 Feb 2012 12:55:29 -0800 (PST)
\r
35 Received: from localhost (104.218-242-81.adsl-dyn.isp.belgacom.be.
\r
37 by mx.google.com with ESMTPS id dr5sm29418049wib.0.2012.02.19.12.55.28
\r
38 (version=TLSv1/SSLv3 cipher=OTHER);
\r
39 Sun, 19 Feb 2012 12:55:29 -0800 (PST)
\r
40 From: Pieter Praet <pieter@praet.org>
\r
41 To: Jani Nikula <jani@nikula.org>,
\r
42 Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
43 Subject: Re: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag'
\r
46 <CAB+hUn834oJ+XGx-YyYSGxSnzrBYCMvcu4Vd73ws28qTS2riuA@mail.gmail.com>
\r
47 References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
48 <1327727143-24455-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
49 <CAB+hUn834oJ+XGx-YyYSGxSnzrBYCMvcu4Vd73ws28qTS2riuA@mail.gmail.com>
\r
50 User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1
\r
51 (x86_64-unknown-linux-gnu)
\r
52 Date: Sun, 19 Feb 2012 21:53:19 +0100
\r
53 Message-ID: <87fwe6sfy8.fsf@praet.org>
\r
55 Content-Type: text/plain; charset=us-ascii
\r
57 ALoCoQnoIY1DpczZU7ThbuWQE897pegR8aoH61aYbblMMqce+8I9ooSe1PoeKExtNU6ovHRQVjAN
\r
58 Cc: notmuch@notmuchmail.org
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Sun, 19 Feb 2012 20:55:31 -0000
\r
73 On Sat, 28 Jan 2012 10:56:21 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
74 > On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" <dmitry.kurochkin@gmail.com>
\r
77 > > The tag syntax check in `notmuch-tag' function was too strict and did
\r
78 > > not allow nmbug tags with "::". Since the check is done for all
\r
79 > > tagging operations in Emacs UI, this basically means that no nmbug
\r
80 > > tags can be changed. The patch relaxes the tag syntax check to allow
\r
81 > > any tag names that do not include whitespace characters.
\r
83 > Imho the syntax check should be in cli, or lib even. I posted a patch to
\r
84 > cli some time ago when I realized it's possible to add tag "-" but you
\r
85 > can't remove it with the current cli. (On the road, can't find the message
\r
90 id:"3da260c7687fafe2cbc17bad129a8b1edb05c6d0.1320958534.git.jani@nikula.org"
\r
93 > > emacs/notmuch.el | 2 +-
\r
94 > > 1 files changed, 1 insertions(+), 1 deletions(-)
\r
96 > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
97 > > index 9813e0a..0de6123 100644
\r
98 > > --- a/emacs/notmuch.el
\r
99 > > +++ b/emacs/notmuch.el
\r
100 > > @@ -555,7 +555,7 @@ notmuch-after-tag-hook will be run."
\r
101 > > ;; Perform some validation
\r
102 > > (when (null tags) (error "No tags given"))
\r
103 > > (mapc (lambda (tag)
\r
104 > > - (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag)
\r
105 > > + (unless (string-match-p "^[-+]\\S-+$" tag)
\r
106 > > (error "Tag must be of the form `+this_tag' or `-that_tag'")))
\r
108 > > (run-hooks 'notmuch-before-tag-hook)
\r
112 > > _______________________________________________
\r
113 > > notmuch mailing list
\r
114 > > notmuch@notmuchmail.org
\r
115 > > http://notmuchmail.org/mailman/listinfo/notmuch
\r
116 Non-text part: text/html
\r
117 > _______________________________________________
\r
118 > notmuch mailing list
\r
119 > notmuch@notmuchmail.org
\r
120 > http://notmuchmail.org/mailman/listinfo/notmuch
\r