ae/b4e796d96ed4585b95c7e0ca37a7809f98c8c0

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 948C9431FAF\r
   6         for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 14:57:25 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id s4HEjwPW0Ytm for <notmuch@notmuchmail.org>;\r
  16         Tue, 27 Mar 2012 14:57:25 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
  18         [18.9.25.13])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 1BCCE431FAE\r
  20         for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 14:57:25 -0700 (PDT)\r
  21 X-AuditID: 1209190d-b7fbf6d0000008ba-91-4f7237c44618\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 07.FC.02234.4C7327F4; Tue, 27 Mar 2012 17:57:24 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q2RLvNaQ022696; \r
  27         Tue, 27 Mar 2012 17:57:23 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2RLvKQc013697\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Tue, 27 Mar 2012 17:57:22 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SCeOG-0002Dr-30; Tue, 27 Mar 2012 17:57:20 -0400\r
  37 Date: Tue, 27 Mar 2012 17:57:20 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Tomi Ollila <tomi.ollila@iki.fi>\r
  40 Subject: Re: [PATCH 0/3] Rewrite default reply format\r
  41 Message-ID: <20120327215720.GX2670@mit.edu>\r
  42 References: <1332473647-9133-1-git-send-email-amdragon@mit.edu>\r
  43         <m2d382ia9d.fsf@guru.guru-group.fi>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain; charset=us-ascii\r
  46 Content-Disposition: inline\r
  47 In-Reply-To: <m2d382ia9d.fsf@guru.guru-group.fi>\r
  48 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  49 X-Brightmail-Tracker:\r
  50  H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1j1iXuRvcPoTn8X1mzOZLd6snMfq\r
  51         wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGX8/NnMUjCDs6J39SaWBsY57F2MnBwSAiYS\r
  52         8y4sZYSwxSQu3FvP1sXIxSEksI9RouX0JDaQhJDABkaJ3xsyIRInmSRaD+6CSixhlFi7UxvE\r
  53         ZhFQlbjTdYgZxGYT0JDYtn852FQRARWJB23rWUFsZgFpiW+/m5lAbGEBU4lZa+6DXcEroC2x\r
  54         8NEWJoiZqRIrD6xghogLSpyc+YQFoldL4sa/l0A1HGBzlv/jAAlzChhI/PzxAmy8KNCqKSe3\r
  55         sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrp5WaW6KWmlG5iBAe1\r
  56         JO8OxncHlQ4xCnAwKvHwVjMV+QuxJpYVV+YeYpTkYFIS5VUwBQrxJeWnVGYkFmfEF5XmpBYf\r
  57         YpTgYFYS4dWOKvQX4k1JrKxKLcqHSUlzsCiJ86pqvfMTEkhPLEnNTk0tSC2CycpwcChJ8PIB\r
  58         o1dIsCg1PbUiLTOnBCHNxMEJMpwHaPhnM6Aa3uKCxNzizHSI/ClGRSlx3o8gCQGQREZpHlwv\r
  59         LOm8YhQHekWY9xtIFQ8wYcF1vwIazAQ0eMmRfJDBJYkIKakGxv3zZtTdC//h+mlx0bL2XNUr\r
  60         050rn8WlTdWb6PYulO9PJuvXyMrTG84cyXCxZD7oNyvfgDk9bqVh2c+ttc/DK72THtenhS00\r
  61         r4jacH3bOoFV8amMn3Z1hbKHP5mtMbvotb0J0+8y13xGKfuq+Ts8tJTEH1/Kkha9wfO8TGx6\r
  62         wALtbcFvd/cnKbEUZyQaajEXFScCAJEwQKEVAwAA\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Tue, 27 Mar 2012 21:57:25 -0000\r
  77 \r
  78 Thanks for the review.  New version coming shortly...\r
  79 \r
  80 Quoth Tomi Ollila on Mar 24 at 12:06 pm:\r
  81 > Austin Clements <amdragon@MIT.EDU> writes:\r
  82 > \r
  83 > > The default reply format is the last bastion of the old message\r
  84 > > formatter style.  This series converts it to the new self-recursive\r
  85 > > style.  After this, there will be one last series to rip out the\r
  86 > > compatibility code and do final cleanup.\r
  87 > \r
  88 > Works fine, patches look good... just 2 "spacing" questions:\r
  89 > \r
  90 > in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu"\r
  91 > \r
  92 > + typedef enum {\r
  93 > +     NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0,\r
  94 > + } notmuch_show_text_part_flags;\r
  95 > \r
  96 > Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0),\r
  97 \r
  98 Changed to NOTMUCH_SHOW_TEXT_PART_REPLY = 1 << 0 to be consistent with\r
  99 operator spacing.  I left out the parens since they aren't necessary.\r
 100 \r
 101 > and this\r
 102 > \r
 103 > + * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each\r
 104 > + * output line.\r
 105 > + *\r
 106 > \r
 107 > like:\r
 108 > \r
 109 > + * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each\r
 110 \r
 111 Changed.  On this one I put in parens to better distinguish it from\r
 112 the surrounding prose.\r
 113 \r
 114 > Tomi\r