1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1AD0A4196F2
\r
6 for <notmuch@notmuchmail.org>; Wed, 14 Apr 2010 11:41:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
\r
12 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id vvug4gcGHly2; Wed, 14 Apr 2010 11:41:43 -0700 (PDT)
\r
17 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 31569431FC1;
\r
19 Wed, 14 Apr 2010 11:41:43 -0700 (PDT)
\r
20 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
21 id D1A38568DE1; Wed, 14 Apr 2010 11:41:42 -0700 (PDT)
\r
22 From: Carl Worth <cworth@cworth.org>
\r
23 To: Dirk Hohndel <hohndel@infradead.org>, Tomas Carnecky <tom@dbservice.com>,
\r
24 Dirk Hohndel <hohndel@x200.gr8dns.org>
\r
25 Subject: Re: [PATCH] Add strcasestr v.3 - add compat implementation of
\r
27 In-Reply-To: <m3mxx7azkb.fsf@x200.gr8dns.org>
\r
28 References: <m3vdbvb8p7.fsf@x200.gr8dns.org> <4BC4BC26.1060803@dbservice.com>
\r
29 <m3mxx7azkb.fsf@x200.gr8dns.org>
\r
30 Date: Wed, 14 Apr 2010 11:41:42 -0700
\r
31 Message-ID: <87pr21g9ll.fsf@yoom.home.cworth.org>
\r
33 Content-Type: multipart/signed; boundary="=-=-=";
\r
34 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
35 Cc: notmuch@notmuchmail.org
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.13
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Wed, 14 Apr 2010 18:41:44 -0000
\r
51 Content-Transfer-Encoding: quoted-printable
\r
53 On Tue, 13 Apr 2010 13:05:08 -0700, Dirk Hohndel <hohndel@infradead.org> wr=
\r
55 > On Tue, 13 Apr 2010 20:47:02 +0200, Tomas Carnecky <tom@dbservice.com> wr=
\r
57 > > On 4/13/10 6:47 PM, Dirk Hohndel wrote:
\r
58 > > > v.3 of this patch, now with the changes to makefiles, configure script
\r
59 > > > compat.h and all new files that I need
\r
60 > > > Please test on platforms lacking strcasestr
\r
62 > > Tested-by: Tomas Carnecky <tom@dbservice.com>
\r
64 > Thanks Tomas, I really appreciate it.
\r
66 Thanks to both Dirk and Thomas for this portability fix.
\r
68 I've pushed it now, with a few minor changes:
\r
70 * Delete trailing whitespace
\r
72 * Add include of "compat.h" from strcasestr.c
\r
74 * Use original commit message from Dirk
\r
76 Dirk, the commit message you sent with version 1 of the patch was
\r
77 perfect. When you send followup patches, please leave a good commit
\r
78 message as the initial content of the email. Then add any explanatory
\r
79 text, ("v.3 of this patch...", "Please test..."), in the email *after*
\r
80 the "---" separator (just before the diffstat). That way it won't become
\r
81 part of the commit message and our indelible history.
\r
83 For now, I manually touched things up, but it would be nice to not have
\r
84 to do that in the future.
\r
91 Content-Type: application/pgp-signature
\r
93 -----BEGIN PGP SIGNATURE-----
\r
94 Version: GnuPG v1.4.10 (GNU/Linux)
\r
96 iD8DBQFLxgxm6JDdNq8qSWgRApPxAKCEB4AN8ykZ/n3ERkhPnd6Pf3i4ogCfSGXF
\r
97 FdxsBSuiHfzeTWbS651dLvI=
\r
99 -----END PGP SIGNATURE-----
\r