1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 149C0431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 10 Sep 2014 03:04:22 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id TKYDjAmPxaKE for <notmuch@notmuchmail.org>;
\r
16 Wed, 10 Sep 2014 03:04:14 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 8D97D431FBC
\r
19 for <notmuch@notmuchmail.org>; Wed, 10 Sep 2014 03:04:14 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 2D77610008C;
\r
22 Wed, 10 Sep 2014 13:04:01 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] test: simplify T360-symbol-hiding,
\r
26 use nm instead of objdump
\r
27 In-Reply-To: <1410331271-1403-1-git-send-email-david@tethera.net>
\r
28 References: <1410331271-1403-1-git-send-email-david@tethera.net>
\r
29 User-Agent: Notmuch/0.18.1+93~gaa65b5d (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Wed, 10 Sep 2014 13:04:00 +0300
\r
35 Message-ID: <m2r3zjpzan.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Wed, 10 Sep 2014 10:04:22 -0000
\r
52 On Wed, Sep 10 2014, David Bremner <david@tethera.net> wrote:
\r
54 > After yet another variation in objdump output caused this test to fail
\r
55 > (on a Debian port, no less), I decided whatever putative benefit we
\r
56 > get from looking at the object files instead of the library isn't
\r
57 > worth the maintenence headache.
\r
59 > This version uses nm -P. nm -P should be portable, and fixed format.
\r
60 > It purposely doesn't use the -D argument, since that is non-POSIX and
\r
61 > nm on GNU/Linux seems do the right thing without it.
\r
63 > It still won't work out of the box on e.g. Mac OS/X. I think the right
\r
64 > thing to do there is to move some more configuration information into
\r
72 > test/T360-symbol-hiding.sh | 2 +-
\r
73 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
75 > diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
\r
76 > index 636ec91..8fc4bdf 100755
\r
77 > --- a/test/T360-symbol-hiding.sh
\r
78 > +++ b/test/T360-symbol-hiding.sh
\r
79 > @@ -26,7 +26,7 @@ test_begin_subtest 'checking output'
\r
80 > test_expect_equal "$result" "$output"
\r
82 > test_begin_subtest 'comparing existing to exported symbols'
\r
83 > -objdump -t $TEST_DIRECTORY/../lib/*.o | awk '$4 == ".text" && $6 ~ "^notmuch" {print $6}' | sort | uniq > ACTUAL
\r
84 > +nm -P $TEST_DIRECTORY/../lib/libnotmuch.so | awk '$2 == "T" && $1 ~ "^notmuch" {print $1}' | sort | uniq > ACTUAL
\r
85 > sed -n 's/[[:blank:]]*\(notmuch_[^;]*\);/\1/p' $TEST_DIRECTORY/../notmuch.sym | sort | uniq > EXPORTED
\r
86 > test_expect_equal_file EXPORTED ACTUAL
\r
91 > _______________________________________________
\r
92 > notmuch mailing list
\r
93 > notmuch@notmuchmail.org
\r
94 > http://notmuchmail.org/mailman/listinfo/notmuch
\r