1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 90C39431FBF
\r
6 for <notmuch@notmuchmail.org>; Fri, 16 Mar 2012 23:02:36 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 4nl6GIIqeWgz for <notmuch@notmuchmail.org>;
\r
16 Fri, 16 Mar 2012 23:02:35 -0700 (PDT)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 67F61431FB6
\r
20 for <notmuch@notmuchmail.org>; Fri, 16 Mar 2012 23:02:34 -0700 (PDT)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id E030F66E00DD;
\r
23 Fri, 16 Mar 2012 23:02:31 -0700 (PDT)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from finestructure.net (cpe-74-66-81-190.nyc.res.rr.com
\r
26 [74.66.81.190]) (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id 106D066E0108;
\r
28 Fri, 16 Mar 2012 23:02:29 -0700 (PDT)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id 154A74A8; Fri, 16 Mar 2012 23:02:26 -0700 (PDT)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [Patch v2 0/3] Add test and fix exclude bug
\r
34 In-Reply-To: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>
\r
35 References: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>
\r
36 User-Agent: Notmuch/0.11.1+306~g05d342c (http://notmuchmail.org) Emacs/23.3.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Fri, 16 Mar 2012 23:02:25 -0700
\r
39 Message-ID: <87limzepe6.fsf@servo.finestructure.net>
\r
41 Content-Type: multipart/signed; boundary="=-=-=";
\r
42 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Sat, 17 Mar 2012 06:02:37 -0000
\r
58 Content-Transfer-Encoding: quoted-printable
\r
60 On Wed, 14 Mar 2012 12:26:51 +0000, Mark Walters <markwalters1009@gmail.com=
\r
62 > The test in the previous patches
\r
63 > id:"1331551914-28323-1-git-send-email-markwalters1009@gmail.com"
\r
64 > triggered the bug accidentally. It accidentally set the exclude tags
\r
65 > to be "=3D" and "deleted" rather than just "deleted". The non-existent
\r
66 > "=3D" tag (i.e., the tag that does not occur anywhere in the Xapian
\r
67 > database) triggered the bug. First we correct the tests to just set
\r
68 > the "deleted" tag, then we add some tests including one with a
\r
69 > deliberately non-existent tag. Finally, we modify the exclusion code
\r
72 > The modification also appears to fix a similar problem for jrollins
\r
73 > that I have not yet been able to reproduce.
\r
75 > Since the code is now more clearly correct, cleaner and we do
\r
76 > definitely avoid a Xapian bug I think these patches can be committed
\r
77 > even without knowing why it fixed jrollins' bug.
\r
79 > Finally these apply to current master (not to the --with-excluded series).
\r
81 tested, and it works for me, so LGTM.
\r
86 Content-Type: application/pgp-signature
\r
88 -----BEGIN PGP SIGNATURE-----
\r
89 Version: GnuPG v1.4.11 (GNU/Linux)
\r
91 iQIcBAEBCAAGBQJPZCjxAAoJEO00zqvie6q88ZsQALW3GWKh7IXsI/Z/s2gjdNqh
\r
92 FwVhXQjsibRLxvZ8FvXhPp7iU6mwn8maBLLe8uEUdvGdf4e55/Uf4GF1zjWHOQvN
\r
93 eevD9wiV55z+uVA4hmp0VGC69rgoPGlb+BUcdQKUj2CnbRuydOObXUUqJbNKFksA
\r
94 LrneTwEGgiw0ogSoymjkXd3Jj+aaWuEyx9FPyvme16Q3JcqMeeCpqXOb0n8m2x8c
\r
95 9a+4nD7TxeRkCSVDbvVfV0ecOmPr7D6IrcLUYZd8wK//hdKTWVSN1DY8De4mQA78
\r
96 vthnh1p4ArCXoiSlf4yUotLz0h0xNmvsKWoY6wGIvgYVaEVeClj7ELNsubx8mu3J
\r
97 J2OvXN8gU1TM8X122r8/rIdQBXy0zgqus6ysqgcCDo0zsb4tI44xnZMAy+yixwqs
\r
98 OBFkAMQrfL10KzECSvts9J4geXG9CJovAFbSSWCFwdI391zuaCXhVYJaqljsbuHg
\r
99 aSqxdne8ukcK/oPf8doXq/rHoeAgBy4e62MZjKISGHpm9T1MWTL9Vr5TmKtHskDB
\r
100 sFqOCPj8bbzrfbwOi06B40lEB8zg1MX2untTBsKj3449eoWl1DCHdn8JlS40IpDF
\r
101 snJD1efGqvRtLkxlpsekp/+zjXfax4ppsehGdPB7C4f2/aU4gv4D64HRKiQs8L6E
\r
102 Yy1ZFNJOMr06CJARZAbe
\r
104 -----END PGP SIGNATURE-----
\r